Re: [PATCH v2 xserver 1/3] xfree86: Silence always true condition warning.

2017-03-27 Thread walter harms
looks nice Reviewed-by: wha...@bfs.de Am 27.03.2017 17:36, schrieb Michal Srb: > xf86pciBus.c:1464:21: warning: comparison of constant 256 with expression of > type 'uint8_t' (aka 'unsigned char') is always true > [-Wtautological-constant-out-of-range-compare] > if (pVideo->bus < 256) > >

[PATCH v2 xserver 1/3] xfree86: Silence always true condition warning.

2017-03-27 Thread Michal Srb
xf86pciBus.c:1464:21: warning: comparison of constant 256 with expression of type 'uint8_t' (aka 'unsigned char') is always true [-Wtautological-constant-out-of-range-compare] if (pVideo->bus < 256) The code used to be in xf86FormatPciBusNumber and compared parameter which was int, but