Re: [PATCH xquartz 04/10] randr: Silence -Wshift-negative-value warnings

On Wed, 2015-10-14 at 15:44 -0700, Jeremy Huddleston Sequoia wrote: > > On Oct 14, 2015, at 15:33, Alan Coopersmith wrote: > > > > On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote: > > > rrtransform.c:199:23: warning: shifting a negative signed value > > > is undefined

Re: [PATCH xquartz 04/10] randr: Silence -Wshift-negative-value warnings

> On Oct 19, 2015, at 08:31, Adam Jackson wrote: > > On Wed, 2015-10-14 at 15:44 -0700, Jeremy Huddleston Sequoia wrote: >>> On Oct 14, 2015, at 15:33, Alan Coopersmith wrote: >>> >>> On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote: rrtransform.c:199:23: warning:

Re: [PATCH xquartz 04/10] randr: Silence -Wshift-negative-value warnings

Am 15.10.2015 00:33, schrieb Alan Coopersmith: > On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote: >> rrtransform.c:199:23: warning: shifting a negative signed value is >> undefined [-Wshift-negative-value,Semantic Issue] >> rot_cos = F(-1); > > >> -rot_cos =

[PATCH xquartz 04/10] randr: Silence -Wshift-negative-value warnings

rrtransform.c:199:23: warning: shifting a negative signed value is undefined [-Wshift-negative-value,Semantic Issue] rot_cos = F(-1); ^ rrtransform.c:114:14: note: expanded from macro 'F' ^~ ../render/picture.h:200:24: note:

Re: [PATCH xquartz 04/10] randr: Silence -Wshift-negative-value warnings

> On Oct 14, 2015, at 15:33, Alan Coopersmith > wrote: > > On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote: >> rrtransform.c:199:23: warning: shifting a negative signed value is undefined >> [-Wshift-negative-value,Semantic Issue] >> rot_cos =

Re: [PATCH xquartz 04/10] randr: Silence -Wshift-negative-value warnings

On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote: rrtransform.c:199:23: warning: shifting a negative signed value is undefined [-Wshift-negative-value,Semantic Issue] rot_cos = F(-1); -rot_cos = F(-1); +rot_cos = F(~0u); Is -1 guaranteed to be ~0u