Re: [PATCH xserver] AttendClient of grab-pervious client should queue to saved_ready_clients

2017-01-11 Thread Adam Jackson
On Wed, 2017-01-11 at 09:02 -0800, Keith Packard wrote: > Adam Jackson writes: > > > 80 columns max, please. > > Wrapped. D'oh, this was in two places but I only commented on the one. > > The conditional is always true, which makes me wonder what > > conditional > > you meant

Re: [PATCH xserver] AttendClient of grab-pervious client should queue to saved_ready_clients

2017-01-11 Thread Keith Packard
bject: [PATCH xserver] AttendClient of grab-pervious client should queue to saved_ready_clients [v2] A client which is attended while a grab is blocking execution of its requests needs to be placed in the saved_ready_clients list so that it will get scheduled once the grab terminates. Otherwise, if t

Re: [PATCH xserver] AttendClient of grab-pervious client should queue to saved_ready_clients

2017-01-11 Thread Adam Jackson
On Mon, 2017-01-09 at 18:14 -0800, Keith Packard wrote: > +/* Client has requests queued or data on the network, but awaits a server > grab release */ 80 columns max, please. > @@ -1067,6 +1067,10 @@ AttendClient(ClientPtr client) Additional context here:      oc->flags &=

[PATCH xserver] AttendClient of grab-pervious client should queue to saved_ready_clients

2017-01-09 Thread Keith Packard
A client which is attended while a grab is blocking execution of its requests needs to be placed in the saved_ready_clients list so that it will get scheduled once the grab terminates. Otherwise, if the client never sends another request, there is no way for it to be placed in the ready_clients