> There is a fundamental logical problem with this patch though, because
> glamor_upload_picture_to_texture() does:
>
> assert(glamor_pixmap_is_memory(pixmap));
>
> which is basically priv->type == GLAMOR_MEMORY;
>
> So glamor_upload_picture_to_texture() clearly expects a pixmap of type
>
Hi
> If the pixmap type is neither GLAMOR_TEXTURE_ONLY nor GLAMOR_TEXTURE_DRM
> we might have the fbo field set but the gl_fbo still set to the default
> GLAMOR_FBO_UNATTACHED, which later may fail an assert in
> glamor_upload_picture_to_texture().
>
> Bugzilla:
If the pixmap type is neither GLAMOR_TEXTURE_ONLY nor GLAMOR_TEXTURE_DRM
we might have the fbo field set but the gl_fbo still set to the default
GLAMOR_FBO_UNATTACHED, which later may fail an assert in
glamor_upload_picture_to_texture().
Bugzilla:
