Re: [PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-18 Thread Adam Jackson
On Sat, 2016-07-16 at 15:34 +0200, Michael Thayer wrote: > On 15.07.2016 17:33, Adam Jackson wrote: > > On Tue, 2016-07-12 at 15:56 +0200, Michael Thayer wrote: > > > > > I know it has just been two days, but still, a polite ping.  I would > > > also generally be interested in the question of

Re: [PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-16 Thread Michael Thayer
On 15.07.2016 17:33, Adam Jackson wrote: On Tue, 2016-07-12 at 15:56 +0200, Michael Thayer wrote: I know it has just been two days, but still, a polite ping. I would also generally be interested in the question of what I can do to get this sort of patch moving. Would reviewing other people's

Re: [PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-15 Thread Adam Jackson
On Tue, 2016-07-12 at 15:56 +0200, Michael Thayer wrote: > I know it has just been two days, but still, a polite ping.  I would  > also generally be interested in the question of what I can do to get  > this sort of patch moving.  Would reviewing other people's patches be  > the right way to go,

Re: [PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-12 Thread Michael Thayer
On 10.07.2016 12:23, Michael Thayer wrote: Hello Adam, On 05.07.2016 20:40, Adam Jackson wrote: On Mon, 2016-07-04 at 21:43 +0200, Michael Thayer wrote: When submitting dirty rectangles to the kernel driver, modesetting checks the return value, and if it gets ENOSYS (driver does not support

Re: [PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-10 Thread Michael Thayer
Hello Adam, On 05.07.2016 20:40, Adam Jackson wrote: On Mon, 2016-07-04 at 21:43 +0200, Michael Thayer wrote: When submitting dirty rectangles to the kernel driver, modesetting checks the return value, and if it gets ENOSYS (driver does not support reporting) or EINVAL (invalid data submitted

Re: [PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-05 Thread Michael Thayer
On 05.07.2016 22:15, Michael Thayer wrote: On 05.07.2016 20:40, Adam Jackson wrote: On Mon, 2016-07-04 at 21:43 +0200, Michael Thayer wrote: When submitting dirty rectangles to the kernel driver, modesetting checks the return value, and if it gets ENOSYS (driver does not support reporting) or

Re: [PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-05 Thread Michael Thayer
On 05.07.2016 20:40, Adam Jackson wrote: On Mon, 2016-07-04 at 21:43 +0200, Michael Thayer wrote: When submitting dirty rectangles to the kernel driver, modesetting checks the return value, and if it gets ENOSYS (driver does not support reporting) or EINVAL (invalid data submitted to the kernel

Re: [PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-05 Thread Adam Jackson
On Mon, 2016-07-04 at 21:43 +0200, Michael Thayer wrote: > When submitting dirty rectangles to the kernel driver, modesetting checks > the return value, and if it gets ENOSYS (driver does not support reporting) > or EINVAL (invalid data submitted to the kernel driver) it disables reporting > for

[PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-04 Thread Michael Thayer
When submitting dirty rectangles to the kernel driver, modesetting checks the return value, and if it gets ENOSYS (driver does not support reporting) or EINVAL (invalid data submitted to the kernel driver) it disables reporting for the rest of the session. The second is clearly wrong, and has