Re: [PATCH xserver] sdksyms: Skip empty symbols

2018-04-12 Thread Jeff Smith
> my awk skills are non-existent but shouldn't this be $symbol? The condition a > few > lines above uses $n == "" instead of n == "" > > with that change, Reviewed-by: Peter Hutterer > > Cheers, >Peter Well, awk is a bit peculiar in that respect. Noting that awk

Re: [PATCH xserver] sdksyms: Skip empty symbols

2018-04-12 Thread Thomas Klausner
On Wed, Apr 11, 2018 at 03:39:33PM -0400, Adam Jackson wrote: > Apparently on NetBSD we can hit failures like this: > > sdksyms.c:1773:15: error: expected expression before ',' token > (void *) &, /* > ../../dri3/dri3.h:110 */ > > I've been

Re: [PATCH xserver] sdksyms: Skip empty symbols

2018-04-11 Thread Peter Hutterer
On Wed, Apr 11, 2018 at 03:39:33PM -0400, Adam Jackson wrote: > Apparently on NetBSD we can hit failures like this: > > sdksyms.c:1773:15: error: expected expression before ',' token > (void *) &, /* > ../../dri3/dri3.h:110 */ > > I've been

[PATCH xserver] sdksyms: Skip empty symbols

2018-04-11 Thread Adam Jackson
Apparently on NetBSD we can hit failures like this: sdksyms.c:1773:15: error: expected expression before ',' token (void *) &, /* ../../dri3/dri3.h:110 */ I've been unable to reproduce that locally (even in a NetBSD vm), but an obvious