Re: [PATCH xserver] xf86-video-modesetting: Lease planes as well if using atomic

2018-07-03 Thread Adam Jackson
On Wed, 2018-06-27 at 10:41 +0100, Daniel Stone wrote: > Hi, > > On Wed, 27 Jun 2018 at 00:35, Keith Packard wrote: > > @@ -3251,6 +3251,9 @@ drmmode_create_lease(RRLeasePtr lease, int *fd) > > > > nobjects = ncrtc + noutput; > > > > +if (ms->atomic_modeset) > > +nobjects +=

Re: [PATCH xserver] xf86-video-modesetting: Lease planes as well if using atomic

2018-06-27 Thread Daniel Stone
Hi, On Wed, 27 Jun 2018 at 00:35, Keith Packard wrote: > @@ -3251,6 +3251,9 @@ drmmode_create_lease(RRLeasePtr lease, int *fd) > > nobjects = ncrtc + noutput; > > +if (ms->atomic_modeset) > +nobjects += ncrtc; This seems like it definitely wants a comment as to why we add ncrtc

[PATCH xserver] xf86-video-modesetting: Lease planes as well if using atomic

2018-06-26 Thread Keith Packard
If we're using atomic modesetting, then we're also using universal planes, and so the lease we create needs to include the plane. Signed-off-by: Keith Packard --- hw/xfree86/drivers/modesetting/drmmode_display.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git