On Wed, Mar 16, 2011 at 10:35:22AM +0200, Rami Ylimäki wrote:
> On 03/16/2011 02:43 AM, Peter Hutterer wrote:
> >
> >>-memcpy(&wire[2],str,len);
> >>-wire+= ((2+len+3)/4)*4;
> >>+paddedLen= pad_to_int32(sizeof(len)+len)-sizeof(len);
> >>+strncpy(&wire[sizeof(len)],str,paddedLen);
>
Hi,
On Wed, Mar 16, 2011 at 10:35:22AM +0200, Rami Ylimäki wrote:
> On 03/16/2011 02:43 AM, Peter Hutterer wrote:
> >
> >>-memcpy(&wire[2],str,len);
> >>-wire+= ((2+len+3)/4)*4;
> >>+paddedLen= pad_to_int32(sizeof(len)+len)-sizeof(len);
> >>+strncpy(&wire[sizeof(len)],str,paddedLen
On 03/16/2011 02:43 AM, Peter Hutterer wrote:
-memcpy(&wire[2],str,len);
-wire+= ((2+len+3)/4)*4;
+paddedLen= pad_to_int32(sizeof(len)+len)-sizeof(len);
+strncpy(&wire[sizeof(len)],str,paddedLen);
+wire+= sizeof(len)+paddedLen;
looking at this again, does this really fix
On Wed, Mar 09, 2011 at 03:45:40PM +0200, Rami Ylimäki wrote:
> Valgrind complains about uninitialized data being written to clients.
>
> Reviewed-by: Erkki Seppälä
> Signed-off-by: Rami Ylimäki
> ---
> xkb/xkb.c | 12 +---
> 1 files changed, 9 insertions(+), 3 deletions(-)
>
> diff
On Wed, Mar 09, 2011 at 03:45:40PM +0200, Rami Ylimäki wrote:
> Valgrind complains about uninitialized data being written to clients.
>
> Reviewed-by: Erkki Seppälä
> Signed-off-by: Rami Ylimäki
merged, thanks.
Cheers,
Peter
> ---
> xkb/xkb.c | 12 +---
> 1 files changed, 9 inser
On Wed, Mar 09, 2011 at 03:45:40PM +0200, Rami Ylimäki wrote:
> Valgrind complains about uninitialized data being written to clients.
>
> Reviewed-by: Erkki Seppälä
> Signed-off-by: Rami Ylimäki
Reviewed-by: Daniel Stone
signature.asc
Description: Digital signature
__
Valgrind complains about uninitialized data being written to clients.
Reviewed-by: Erkki Seppälä
Signed-off-by: Rami Ylimäki
---
xkb/xkb.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/xkb/xkb.c b/xkb/xkb.c
index 8d61e01..39dbab4 100644
--- a/xkb/xkb.c
+++
