Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi all, Sorry to bring this back again... > Just an addition to my previous explanation. > > The systematic server side key repeating only is also a good solution, > if we made the hypothesis that long key press are a lot less frequent > than short key pressing. > > And this solution is less

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi, Just an addition to my previous explanation. The systematic server side key repeating only is also a good solution, if we made the hypothesis that long key press are a lot less frequent than short key pressing. And this solution is less complex. Best regards. Le 11/03/2016 11:25, Benoit

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi Olivier, Le 11/03/2016 10:22, Olivier Fourdan a écrit : > Hi Benoit, > > - Original Message - >> Hello, >> >> Here is my little contribution to the discussion, following a discussion >> on #wayland irc channel. >> >> The issue discussed here, as far I understood, is due to a client

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi Benoit, - Original Message - > Hello, > > Here is my little contribution to the discussion, following a discussion > on #wayland irc channel. > > The issue discussed here, as far I understood, is due to a client that > miss interpret a high latency of the compositor as a repeating

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hello, Here is my little contribution to the discussion, following a discussion on #wayland irc channel. The issue discussed here, as far I understood, is due to a client that miss interpret a high latency of the compositor as a repeating key. This happen when a client receive a key press event

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi, > This still suffers from your priority-starvation-bug. If a simple > ping/pong protocol barrier doesn't solve the issue, why would the > timer? You'd have to put the timer on lowest priority to make that > work, but then again you can do the same for wl_display_sync. Yup, indeed, you're

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi On Tue, Mar 8, 2016 at 4:41 PM, Ray Strode wrote: > On Tue, Mar 8, 2016 at 7:09 AM, Daniel Stone wrote: >>> If one justification for server-side repeat is that if the compositor >>> is hosed and the user cannot see how many characters have been >>>

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi, On Tue, Mar 8, 2016 at 7:09 AM, Daniel Stone wrote: >> If one justification for server-side repeat is that if the compositor >> is hosed and the user cannot see how many characters have been >> repeated, then you could as well solve that in the client too, by >>

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi, On 8 March 2016 at 12:07, Pekka Paalanen wrote: > If one justification for server-side repeat is that if the compositor > is hosed and the user cannot see how many characters have been > repeated, then you could as well solve that in the client too, by > throttling your

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

On Tue, 8 Mar 2016 11:08:45 +0100 Hans de Goede wrote: > Hi, > > On 08-03-16 10:15, Pekka Paalanen wrote: > > On Mon, 7 Mar 2016 19:25:54 +0100 > > Hans de Goede wrote: > > > >> Hi, > >> > >> On 07-03-16 19:23, Hans de Goede wrote: > >>> Hi, > >>>

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi, On 8 March 2016 at 09:15, Pekka Paalanen wrote: > On Mon, 7 Mar 2016 19:25:54 +0100 > Hans de Goede wrote: >> On 07-03-16 19:23, Hans de Goede wrote: >> > On 07-03-16 18:44, Olivier Fourdan wrote: >> > Why not simply rely on the keyrepeat of the

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi, On 08-03-16 10:15, Pekka Paalanen wrote: On Mon, 7 Mar 2016 19:25:54 +0100 Hans de Goede wrote: Hi, On 07-03-16 19:23, Hans de Goede wrote: Hi, On 07-03-16 18:44, Olivier Fourdan wrote: Key repeat is handled by the X server, but for Wayland, the key press/release

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

On Mon, 7 Mar 2016 19:25:54 +0100 Hans de Goede wrote: > Hi, > > On 07-03-16 19:23, Hans de Goede wrote: > > Hi, > > > > On 07-03-16 18:44, Olivier Fourdan wrote: > >> Key repeat is handled by the X server, but for Wayland, the key > >> press/release events need to be

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi, On 07-03-16 19:23, Hans de Goede wrote: Hi, On 07-03-16 18:44, Olivier Fourdan wrote: Key repeat is handled by the X server, but for Wayland, the key press/release events need to be processed and forwarded by the Wayland compositor first. If the Wayland compositor get stuck for whatever

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Hi, On 07-03-16 18:44, Olivier Fourdan wrote: Key repeat is handled by the X server, but for Wayland, the key press/release events need to be processed and forwarded by the Wayland compositor first. If the Wayland compositor get stuck for whatever reason and does not process the key release

[PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

Key repeat is handled by the X server, but for Wayland, the key press/release events need to be processed and forwarded by the Wayland compositor first. If the Wayland compositor get stuck for whatever reason and does not process the key release event fast enough, this may cause the Xwayland