Re: [PATCH xserver 08/11] kdrive/ephyr: Poll for events in block handler

2016-05-20 Thread Laércio de Sousa
> Your patch looks like a fine > change, although I think it might need to include a change to discard > input events when the input subsystem wasn't running (which is why the > SetNotifyFd calls are where they are) > Thanks for the tip! I'm submitting a v2 of my patch preventing Xephyr windows

Re: [PATCH xserver 08/11] kdrive/ephyr: Poll for events in block handler

2016-05-19 Thread Keith Packard
Laércio de Sousa writes: > Could it be related somehow to my concerns in > https://patchwork.freedesktop.org/patch/86328 ? I don't think so -- my patch only changes where the FD is read, not when that FD is added to the select call. Your patch looks

Re: [PATCH xserver 08/11] kdrive/ephyr: Poll for events in block handler

2016-05-19 Thread Laércio de Sousa
Could it be related somehow to my concerns in https://patchwork.freedesktop.org/patch/86328 ? 2016-05-18 18:51 GMT-03:00 Keith Packard : > With the driver block handler guaranteed to be the last thing called > before the server blocks, we can now reliably check for events

[PATCH xserver 08/11] kdrive/ephyr: Poll for events in block handler

2016-05-18 Thread Keith Packard
With the driver block handler guaranteed to be the last thing called before the server blocks, we can now reliably check for events there and never block with events read but not processed. Signed-off-by: Keith Packard --- hw/kdrive/ephyr/ephyr.c | 14 +-