Re: [PATCH xserver 1/2] glamor: Fix copy-like Render operations between 15 and 16 depth.

2016-01-25 Thread Keith Packard
Eric Anholt writes: > Yes, it's supposed to, but we don't actually store 16bpp anything in > glamor, because we suck. Ouch. -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH xserver 1/2] glamor: Fix copy-like Render operations between 15 and 16 depth.

2016-01-22 Thread Eric Anholt
Keith Packard writes: > Eric Anholt writes: > >> if (op == PictOpSrc) { >> +/* We can't do direct copies between different depths at 16bpp >> + * because r,g,b are allocated to different bits. >> + */ >> +if

[PATCH xserver 1/2] glamor: Fix copy-like Render operations between 15 and 16 depth.

2016-01-21 Thread Eric Anholt
Please cherry-pick this to active stable branches. Reading and writing to 16-depth pixmaps using PICT_x1r5g5b5 ends up failing, unless you're doing a straight copy at the same bpp where the misinterpretation matches on both sides. Fixes rendercheck/blend/over and renderhceck/blend/src in piglit.

Re: [PATCH xserver 1/2] glamor: Fix copy-like Render operations between 15 and 16 depth.

2016-01-21 Thread Dave Airlie
On 22 January 2016 at 07:06, Eric Anholt wrote: > Please cherry-pick this to active stable branches. > > Reading and writing to 16-depth pixmaps using PICT_x1r5g5b5 ends up > failing, unless you're doing a straight copy at the same bpp where the > misinterpretation matches on

Re: [PATCH xserver 1/2] glamor: Fix copy-like Render operations between 15 and 16 depth.

2016-01-21 Thread Keith Packard
Eric Anholt writes: > if (op == PictOpSrc) { > +/* We can't do direct copies between different depths at 16bpp > + * because r,g,b are allocated to different bits. > + */ > +if (dst->pDrawable->bitsPerPixel == 16 && > +