Re: [PATCH xserver 1/2] xwayland: Move sprite invalidation logic into mipointer

2016-05-30 Thread Emil Velikov
On 29 May 2016 at 19:45, Keith Packard wrote: > Emil Velikov writes: > >> - Seems like the exports from mi/ are remnants from the separate >> (non-builtin) extmod days. >> >> Not 100% sure though. Can anyone please shed some light ? > > _X_EXPORT is

Re: [PATCH xserver 1/2] xwayland: Move sprite invalidation logic into mipointer

2016-05-29 Thread Keith Packard
Emil Velikov writes: > - Seems like the exports from mi/ are remnants from the separate > (non-builtin) extmod days. > > Not 100% sure though. Can anyone please shed some light ? _X_EXPORT is intended to mark the boundary between 'internal' bits of the server and

Re: [PATCH xserver 1/2] xwayland: Move sprite invalidation logic into mipointer

2016-05-29 Thread Emil Velikov
On 20 May 2016 at 05:25, Keith Packard wrote: >>> +/* Invalidate current sprite, forcing reload on next >>> + * sprite setting (window crossing, grab action, etc) >>> + */ >>> +extern _X_EXPORT void >>> +miPointerInvalidateSprite(DeviceIntPtr pDev); >>> + >> It doesn't look

Re: [PATCH xserver 1/2] xwayland: Move sprite invalidation logic into mipointer

2016-05-19 Thread Keith Packard
Emil Velikov writes: >> +/* Invalidate current sprite, forcing reload on next >> + * sprite setting (window crossing, grab action, etc) >> + */ >> +extern _X_EXPORT void >> +miPointerInvalidateSprite(DeviceIntPtr pDev); >> + > It doesn't look like this should be

Re: [PATCH xserver 1/2] xwayland: Move sprite invalidation logic into mipointer

2016-05-19 Thread Emil Velikov
On 18 May 2016 at 22:03, Keith Packard wrote: > This creates a function that invalidates the current sprite and forces > a sprite image reload the next time the sprite is checked, moving that > logic out of the xwayland sources and allowing the miPointerRec > structure to be

Re: [PATCH xserver 1/2] xwayland: Move sprite invalidation logic into mipointer

2016-05-19 Thread Simon Thum
Hi Keith! Just saw this patch while I glossed over the input threading patches. Glad to see them land after all these years! But anyway: On 05/18/2016 11:03 PM, Keith Packard wrote: -/* X is very likely to have the wrong idea of what the actual cursor - * sprite is, so in order to

Re: [PATCH xserver 1/2] xwayland: Move sprite invalidation logic into mipointer

2016-05-19 Thread Pekka Paalanen
On Wed, 18 May 2016 16:03:47 -0500 Keith Packard wrote: > This creates a function that invalidates the current sprite and forces > a sprite image reload the next time the sprite is checked, moving that > logic out of the xwayland sources and allowing the miPointerRec >

[PATCH xserver 1/2] xwayland: Move sprite invalidation logic into mipointer

2016-05-18 Thread Keith Packard
This creates a function that invalidates the current sprite and forces a sprite image reload the next time the sprite is checked, moving that logic out of the xwayland sources and allowing the miPointerRec structure to be removed from the server API. Signed-off-by: Keith Packard