Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

2016-07-29 Thread walter harms
Am 28.07.2016 19:11, schrieb Keith Packard: > walter harms writes: > >> 1. I do not want to start an argument here. > > Your comments are welcome and helpful. > >> but i seems i need to explain what i wanted to say: >> "b and c do not change inside the loop" >> >> that does

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

2016-07-28 Thread Keith Packard
walter harms writes: > 1. I do not want to start an argument here. Your comments are welcome and helpful. > but i seems i need to explain what i wanted to say: > "b and c do not change inside the loop" > > that does *not* mean I have to say: const double or so. Right, the

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

2016-07-28 Thread walter harms
>>> output->crtc = NULL; >>> diff --git a/hw/xfree86/modes/xf86RandR12.c b/hw/xfree86/modes/xf86RandR12.c >>> index 9f93270..5b24ebb 100644 >>> --- a/hw/xfree86/modes/xf86RandR12.c >>> +++ b/hw/xfree86/modes/xf86RandR12.c >>> @@ -1313,6 +1313,116 @@ xf86RandR12CrtcGetGamma(ScreenPtr

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

2016-07-27 Thread Keith Packard
Matt Turner writes: > I feel confident the compiler is already doing that transformation. I just tried and couldn't get the compiler to do it as the 'pow' function isn't declared with the 'const' attribute. That appears to be a bug in glibc. This code does what you'd

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

2016-07-27 Thread Matt Turner
On Tue, Jul 26, 2016 at 7:25 AM, walter harms wrote: > > > Am 26.07.2016 11:11, schrieb Michel Dänzer: >> From: Michel Dänzer >> >> RRCrtcGammaSetSize cannot be used yet in xf86InitialConfiguration, >> because randr_crtc isn't allocated yet at that point,

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

2016-07-27 Thread Michel Dänzer
On 27.07.2016 18:09, walter harms wrote: > Am 27.07.2016 04:39, schrieb Michel Dänzer: >> On 26.07.2016 23:25, walter harms wrote: >>> Am 26.07.2016 11:11, schrieb Michel Dänzer: diff --git a/hw/xfree86/modes/xf86RandR12.c b/hw/xfree86/modes/xf86RandR12.c index

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

2016-07-27 Thread walter harms
Am 27.07.2016 04:39, schrieb Michel Dänzer: > On 26.07.2016 23:25, walter harms wrote: >> Am 26.07.2016 11:11, schrieb Michel Dänzer: >>> >>> diff --git a/hw/xfree86/modes/xf86RandR12.c b/hw/xfree86/modes/xf86RandR12.c >>> index 9f93270..5b24ebb 100644 >>> --- a/hw/xfree86/modes/xf86RandR12.c

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

2016-07-26 Thread Michel Dänzer
On 26.07.2016 23:25, walter harms wrote: > Am 26.07.2016 11:11, schrieb Michel Dänzer: >> >> diff --git a/hw/xfree86/modes/xf86RandR12.c b/hw/xfree86/modes/xf86RandR12.c >> index 9f93270..5b24ebb 100644 >> --- a/hw/xfree86/modes/xf86RandR12.c >> +++ b/hw/xfree86/modes/xf86RandR12.c >> @@ -1313,6

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

2016-07-26 Thread walter harms
Am 26.07.2016 11:11, schrieb Michel Dänzer: > From: Michel Dänzer > > RRCrtcGammaSetSize cannot be used yet in xf86InitialConfiguration, > because randr_crtc isn't allocated yet at that point, but a following > change will require RRCrtcGammaSetSize to be called from >

[PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

2016-07-26 Thread Michel Dänzer
From: Michel Dänzer RRCrtcGammaSetSize cannot be used yet in xf86InitialConfiguration, because randr_crtc isn't allocated yet at that point, but a following change will require RRCrtcGammaSetSize to be called from xf86RandR12CrtcInitGamma. v2: * Bail from