Re: [PATCH xserver 2/2] Remove default defines of some directories.

2017-04-25 Thread walter harms
Am 24.04.2017 22:19, schrieb Eric Anholt: > The build defines these, so having the defaults is just a way for the > build system's configuration to get out of sync with the code. > > v2: Drop #ifndefs around the other two defines. > > Signed-off-by: Eric Anholt > --- >

Re: [PATCH xserver 2/2] Remove default defines of some directories.

2017-04-24 Thread Keith Packard
Eric Anholt writes: > The build defines these, so having the defaults is just a way for the > build system's configuration to get out of sync with the code. > > v2: Drop #ifndefs around the other two defines. Reviewed-by: Keith Packard -- -keith

[PATCH xserver 2/2] Remove default defines of some directories.

2017-04-24 Thread Eric Anholt
The build defines these, so having the defaults is just a way for the build system's configuration to get out of sync with the code. v2: Drop #ifndefs around the other two defines. Signed-off-by: Eric Anholt --- hw/xfree86/parser/Makefile.am | 1 - hw/xfree86/parser/scan.c

Re: [PATCH xserver 2/2] Remove default defines of some directories.

2017-04-21 Thread Keith Packard
Eric Anholt writes: > The build defines these, so having the defaults is just a way for the > build system's configuration to get out of sync with the code. > #ifndef XCONFIGSUFFIX > #define XCONFIGSUFFIX".conf" > #endif I think we should get rid of the #ifndef

[PATCH xserver 2/2] Remove default defines of some directories.

2017-04-21 Thread Eric Anholt
The build defines these, so having the defaults is just a way for the build system's configuration to get out of sync with the code. Signed-off-by: Eric Anholt --- hw/xfree86/parser/Makefile.am | 1 - hw/xfree86/parser/scan.c | 15 --- xkb/ddxLoad.c