Re: [PATCH xserver 3/4] glamor: Drop glamor_set_screen_pixmap().

2017-06-02 Thread Eric Anholt
Keith Packard writes: > [ Unknown signature status ] > Eric Anholt writes: > >> All that was left here was updating the FBO's size. However, the FBO >> size was always set correctly already through >> glamor_set_pixmap_texture() from whoever had attached a

Re: [PATCH xserver 3/4] glamor: Drop glamor_set_screen_pixmap().

2017-06-01 Thread Keith Packard
Eric Anholt writes: > Basically I traced that we were currently calling set_pixmap_texture() > and decided that that was complicated enough to prove. I'm betting that > my various other glamoregl cleanups happened to make this be true (there > are more cleanups in the pipeline,

Re: [PATCH xserver 3/4] glamor: Drop glamor_set_screen_pixmap().

2017-06-01 Thread Eric Anholt
Keith Packard writes: > [ Unknown signature status ] > Eric Anholt writes: > >> All that was left here was updating the FBO's size. However, the FBO >> size was always set correctly already through >> glamor_set_pixmap_texture() from whoever had attached a

Re: [PATCH xserver 3/4] glamor: Drop glamor_set_screen_pixmap().

2017-06-01 Thread Keith Packard
Eric Anholt writes: > All that was left here was updating the FBO's size. However, the FBO > size was always set correctly already through > glamor_set_pixmap_texture() from whoever had attached a new BO to the > pixmap. I remember desperately needing this code at some point;

[PATCH xserver 3/4] glamor: Drop glamor_set_screen_pixmap().

2017-06-01 Thread Eric Anholt
All that was left here was updating the FBO's size. However, the FBO size was always set correctly already through glamor_set_pixmap_texture() from whoever had attached a new BO to the pixmap. Signed-off-by: Eric Anholt --- glamor/glamor.c | 13