Re: [PATCH xserver v2 1/2] glamor: Unbreak glamor_fd_from_pixmap()

2018-06-21 Thread Lyude Paul
On Thu, 2018-06-21 at 08:38 +0100, Daniel Stone wrote: > Hey Lyude, > On Thu, 21 Jun 2018 at 00:13, Lyude Paul wrote: > > -/* Pixmaps with multi-planes/modifier are not supported in this > > interface */ > > -if (ret != 1 || offsets[0] != 0) { > > -while (ret > 0) > > -

Re: [PATCH xserver v2 1/2] glamor: Unbreak glamor_fd_from_pixmap()

2018-06-21 Thread Daniel Stone
Hey Lyude, On Thu, 21 Jun 2018 at 00:13, Lyude Paul wrote: > -/* Pixmaps with multi-planes/modifier are not supported in this > interface */ > -if (ret != 1 || offsets[0] != 0) { > -while (ret > 0) > -close(fds[--ret]); > +ret = _glamor_fds_from_pixmap(screen,

[PATCH xserver v2 1/2] glamor: Unbreak glamor_fd_from_pixmap()

2018-06-20 Thread Lyude Paul
When support for allocating GBM BOs with modifiers was added, glamor_fd_from_pixmap() was changed so that it would return an error if it got a bo with modifiers set from glamor_fds_from_pixmap(). The problem is that on systems that support BOs with modifiers, glamor_fds_from_pixmap() will always