Re: [PULL] Accumulated small input changes

2011-05-04 Thread Peter Hutterer
On Tue, May 03, 2011 at 01:48:34AM +0100, Daniel Stone wrote: On Fri, Apr 29, 2011 at 07:34:28AM -0700, Keith Packard wrote: Reviewed-by: Keith Packard kei...@keithp.com I think that's all of them. Ta, and yes. Tree updated again (fa965fd..5bf3439). please don't pull this one yet, it

Re: [PULL] Accumulated small input changes

2011-05-04 Thread Keith Packard
On Wed, 4 May 2011 16:18:58 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: please don't pull this one yet, Thanks for the update; I'll sit tight. -- keith.pack...@intel.com pgpOID5fAgk9F.pgp Description: PGP signature ___

Re: [PULL] Accumulated small input changes

2011-05-02 Thread Daniel Stone
Hi, On Fri, Apr 29, 2011 at 09:35:03AM -0400, Chase Douglas wrote: On 04/29/2011 08:33 AM, Daniel Stone wrote: Ah yes, you're right; forgot about the root window always being present. I've updated my tree now, but that commit is still lacking any R-b tag. I've checked it out here:

Re: [PULL] Accumulated small input changes

2011-04-29 Thread Daniel Stone
On Thu, Apr 28, 2011 at 02:00:10PM -0700, Keith Packard wrote: On Thu, 28 Apr 2011 17:43:05 +0100, Daniel Stone dan...@fooishbar.org wrote: Sure, I've made it an inline function now, but removed Peter's R-b. Do you (or anyone else) want to review it? :) Looks fairly reasonable, the only

Re: [PULL] Accumulated small input changes

2011-04-29 Thread Chase Douglas
On 04/29/2011 08:33 AM, Daniel Stone wrote: On Thu, Apr 28, 2011 at 02:00:10PM -0700, Keith Packard wrote: On Thu, 28 Apr 2011 17:43:05 +0100, Daniel Stone dan...@fooishbar.org wrote: Sure, I've made it an inline function now, but removed Peter's R-b. Do you (or anyone else) want to review

Re: [PULL] Accumulated small input changes

2011-04-29 Thread Keith Packard
On Fri, 29 Apr 2011 13:33:31 +0100, Daniel Stone dan...@fooishbar.org wrote: Ah yes, you're right; forgot about the root window always being present. I've updated my tree now, but that commit is still lacking any R-b tag. Reviewed-by: Keith Packard kei...@keithp.com I think that's all of

[PULL] Accumulated small input changes

2011-04-28 Thread Daniel Stone
Hi Keith, The following changes since commit 918a9c99cf2ebc73acb34b95f597904b93c690d9: Merge remote-tracking branch 'jeremyhu/master' (2011-04-22 11:20:16 -0700) are available in the git repository at: git://people.freedesktop.org/~daniels/xserver for-keith All fairly trivial input

Re: [PULL] Accumulated small input changes

2011-04-28 Thread Keith Packard
On Thu, 28 Apr 2011 15:55:34 +0100, Daniel Stone dan...@fooishbar.org wrote: Daniel Stone (4): Input: Add DeepestSpriteWin macro I think this would be nicer if it were an inline function. -- keith.pack...@intel.com pgp62G4Sa55Oi.pgp Description: PGP signature

Re: [PULL] Accumulated small input changes

2011-04-28 Thread Daniel Stone
Hi, On Thu, Apr 28, 2011 at 09:18:44AM -0700, Keith Packard wrote: On Thu, 28 Apr 2011 15:55:34 +0100, Daniel Stone dan...@fooishbar.org wrote: Daniel Stone (4): Input: Add DeepestSpriteWin macro I think this would be nicer if it were an inline function. Sure, I've made it an

Re: [PULL] Accumulated small input changes

2011-04-28 Thread Keith Packard
On Thu, 28 Apr 2011 17:43:05 +0100, Daniel Stone dan...@fooishbar.org wrote: Sure, I've made it an inline function now, but removed Peter's R-b. Do you (or anyone else) want to review it? :) Looks fairly reasonable, the only comment is that if spriteTraceGood is zero, we've got serious