Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-10-02 Thread Jeremy Huddleston
On Sep 26, 2011, at 1:18 PM, Keith Packard wrote: On Fri, 23 Sep 2011 13:14:57 -0700, Jeremy Huddleston jerem...@apple.com wrote: Thanks for more eyes! As always, I'm looking for rough consensus about this before I merge it in; please let me know what you're looking for before it can

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-10-02 Thread Matthieu Herrb
On Sat, Oct 01, 2011 at 11:26:38PM -0700, Jeremy Huddleston wrote: On Sep 26, 2011, at 1:18 PM, Keith Packard wrote: On Fri, 23 Sep 2011 13:14:57 -0700, Jeremy Huddleston jerem...@apple.com wrote: Thanks for more eyes! As always, I'm looking for rough consensus about this

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-10-02 Thread Jamey Sharp
On Sat, Oct 01, 2011 at 11:26:38PM -0700, Jeremy Huddleston wrote: On Sep 26, 2011, at 1:18 PM, Keith Packard wrote: On Fri, 23 Sep 2011 13:14:57 -0700, Jeremy Huddleston jerem...@apple.com wrote: Thanks for more eyes! As always, I'm looking for rough consensus about this before I

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-10-02 Thread Jeremy Huddleston
On Oct 2, 2011, at 00:10, Matthieu Herrb wrote: Was the libpciaccess issue solved ? You're referring to the missing support from libpciaccess, yes? I'm still waiting on comments from my comments on those patches. http://lists.x.org/archives/xorg-devel/2011-September/025663.html

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-10-02 Thread Matthieu Herrb
On Sun, Oct 02, 2011 at 01:11:50AM -0700, Jeremy Huddleston wrote: On Oct 2, 2011, at 00:10, Matthieu Herrb wrote: Was the libpciaccess issue solved ? You're referring to the missing support from libpciaccess, yes? I'm still waiting on comments from my comments on those patches.

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-10-02 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Sun, 2 Oct 2011 01:11:50 -0700 On Oct 2, 2011, at 00:10, Matthieu Herrb wrote: Was the libpciaccess issue solved ? You're referring to the missing support from libpciaccess, yes? I'm still waiting on comments from my comments on

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-26 Thread Mark Kettenis
Date: Sat, 24 Sep 2011 15:16:49 + From: Daniel Stone dan...@fooishbar.org Hi, On 24 September 2011 13:26, Mark Kettenis mark.kette...@xs4all.nl wrote: It's still work.  And it probably inflicts pain on people like Micahel Daenzer who maintain drivers for older xserver releases.  

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-26 Thread Mark Kettenis
Date: Sat, 24 Sep 2011 18:31:11 +0200 From: Matthieu Herrb matthieu.he...@laas.fr Still only a partial review; looking into the changes to the interfaces that map video memory now. I wanted to look, and more importantly test them, but so far the IOADRESS fallout (plus a few other stuff

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-26 Thread Jeremy Huddleston
On Sep 26, 2011, at 06:10, Mark Kettenis wrote: I don't really object to the canges to the in10 module (although the libpciaccess API uses uint32_t instead of unsigned int). But please keep the IOADDRESS typedef until the majority of the video drivers have been converted to use the

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-26 Thread Keith Packard
On Fri, 23 Sep 2011 13:14:57 -0700, Jeremy Huddleston jerem...@apple.com wrote: Thanks for more eyes! As always, I'm looking for rough consensus about this before I merge it in; please let me know what you're looking for before it can be merged to master. -- keith.pack...@intel.com

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-25 Thread Matthieu Herrb
On Sat, Sep 24, 2011 at 12:35:30PM -0700, Jeremy Huddleston wrote: On Sep 24, 2011, at 09:31, Matthieu Herrb wrote: IOADDRESS is used massively throughout the drivers. I really don't see why it needs to be removed. Leaving the typedef in xf86Pci.h will save you/us a lot of work. At

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-25 Thread Matthieu Herrb
On Sun, Sep 25, 2011 at 09:47:15AM +0200, Matthieu Herrb wrote: Hmm it fails to run because it seems that pci_device_map_legacy() never actually made it in libpciaccess(). I found patches in may for it but no actual commits to libpciaccess. Am I looking at the wrong repository ?

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-25 Thread Jeremy Huddleston
On Sep 25, 2011, at 03:12, Matthieu Herrb wrote: On Sun, Sep 25, 2011 at 09:47:15AM +0200, Matthieu Herrb wrote: Hmm it fails to run because it seems that pci_device_map_legacy() never actually made it in libpciaccess(). I found patches in may for it but no actual commits to libpciaccess.

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-24 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Fri, 23 Sep 2011 20:21:54 -0700 On Sep 23, 2011, at 16:22, Jeremy Huddleston wrote: I'm also testing it on tifa32-linux tinderbox: http://tinderbox.x.org/builds/2011-09-23-0007 A few failures in various video drivers ... but they

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-24 Thread Jeremy Huddleston
On Sep 24, 2011, at 03:01, Mark Kettenis wrote: From: Jeremy Huddleston jerem...@apple.com Date: Fri, 23 Sep 2011 20:21:54 -0700 On Sep 23, 2011, at 16:22, Jeremy Huddleston wrote: I'm also testing it on tifa32-linux tinderbox: http://tinderbox.x.org/builds/2011-09-23-0007 A few

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-24 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Sat, 24 Sep 2011 04:11:31 -0700 Only a few drivers actually use domainIOBase, but among those are xf86-video-vesa and xf86-video-vmware drivers, which are pretty important ones. The others are xf86-video-ark, xf86-video-sis and

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-24 Thread Daniel Stone
Hi, On 24 September 2011 13:26, Mark Kettenis mark.kette...@xs4all.nl wrote: It's still work.  And it probably inflicts pain on people like Micahel Daenzer who maintain drivers for older xserver releases.  And it also inflicts pain on people who maintain drivers out of the git repositories on

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-24 Thread Matthieu Herrb
On Sat, Sep 24, 2011 at 12:01:02PM +0200, Mark Kettenis wrote: From: Jeremy Huddleston jerem...@apple.com Date: Fri, 23 Sep 2011 20:21:54 -0700 On Sep 23, 2011, at 16:22, Jeremy Huddleston wrote: I'm also testing it on tifa32-linux tinderbox:

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-24 Thread Jeremy Huddleston
On Sep 24, 2011, at 09:31, Matthieu Herrb wrote: IOADDRESS is used massively throughout the drivers. I really don't see why it needs to be removed. Leaving the typedef in xf86Pci.h will save you/us a lot of work. At that point you might as well drop the changesto remove IOADDRESS usage in

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-24 Thread Jeremy Huddleston
On Sep 24, 2011, at 12:35, Jeremy Huddleston wrote: On Sep 24, 2011, at 09:31, Matthieu Herrb wrote: IOADDRESS is used massively throughout the drivers. I really don't see why it needs to be removed. Leaving the typedef in xf86Pci.h will save you/us a lot of work. At that point you

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Mark Kettenis
From: Jeremy Huddleston jerem...@apple.com Date: Thu, 22 Sep 2011 19:52:05 -0700 The following changes since commit 7fb4bef0394a5d09680985d34bce8252b61493cb: Merge remote-tracking branch 'mattst88/for-keith' (2011-09-21 14:34:27 -0700) are available in the git repository at:

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Daniel Stone
Hi, On 23 September 2011 15:10, Mark Kettenis mark.kette...@xs4all.nl wrote: Unlike Tiago's origional changes this looks like it is actually going somewhere, and generally this looks like a good idea, even if it breaks some stuff temporarily.  But I'd like to check that not too many

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Matt Turner
On Fri, Sep 23, 2011 at 10:10 AM, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Jeremy Huddleston jerem...@apple.com Date: Thu, 22 Sep 2011 19:52:05 -0700 The following changes since commit 7fb4bef0394a5d09680985d34bce8252b61493cb:   Merge remote-tracking branch 'mattst88/for-keith'

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Keith Packard
On Fri, 23 Sep 2011 16:10:44 +0200 (CEST), Mark Kettenis mark.kette...@xs4all.nl wrote: Unlike Tiago's origional changes this looks like it is actually going somewhere, and generally this looks like a good idea, even if it breaks some stuff temporarily. But I'd like to check that not too

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Jeremy Huddleston
On 09/23/2011 07:10 AM, Mark Kettenis wrote: From: Jeremy Huddlestonjerem...@apple.com Date: Thu, 22 Sep 2011 19:52:05 -0700 The following changes since commit 7fb4bef0394a5d09680985d34bce8252b61493cb: Merge remote-tracking branch 'mattst88/for-keith' (2011-09-21 14:34:27 -0700) are

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Jeremy Huddleston
Hi Keith, I believe this failure is coming from b61950dc616402bbf3fb0774e9289d32c0f42c83 which removed these from xfree86/common/xf86str.h #include xf86Pci.h #include pciaccess.h I squashed your change below into b61950dc616402bbf3fb0774e9289d32c0f42c83 and pushed the new branch. I'm also

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-23 Thread Jeremy Huddleston
On Sep 23, 2011, at 16:22, Jeremy Huddleston wrote: Hi Keith, I believe this failure is coming from b61950dc616402bbf3fb0774e9289d32c0f42c83 which removed these from xfree86/common/xf86str.h #include xf86Pci.h #include pciaccess.h I squashed your change below into

[PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-22 Thread Jeremy Huddleston
The following changes since commit 7fb4bef0394a5d09680985d34bce8252b61493cb: Merge remote-tracking branch 'mattst88/for-keith' (2011-09-21 14:34:27 -0700) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master Adam Jackson (16): xfree86: Move

Re: [PULL] bus cleanup, darwin hw/xfree86, build regression fixes

2011-09-22 Thread Keith Packard
On Thu, 22 Sep 2011 19:52:05 -0700, Jeremy Huddleston jerem...@apple.com wrote: git://people.freedesktop.org/~jeremyhu/xserver master This sequence needs the following patch somewhere: diff --git a/hw/xfree86/modes/xf86Cursors.c b/hw/xfree86/modes/xf86Cursors.c index 23c48eb..e244a2d 100644