Re: [RFC PATCH xserver] xwayland: Avoid assert failure in flips_stop()

2018-09-21 Thread Roman Gilg
Great detailed analysis in the backtrace! :) What confused me at first was that the present_wnmd_flips_stop function is called at all in this state because it should only be called when at least one flip has been done and in this case xwl_window->present_window must have been set to the presenting

[RFC PATCH xserver] xwayland: Avoid assert failure in flips_stop()

2018-09-14 Thread Olivier Fourdan
On `ClipNotify()`, `present_clip_notify()` will possibly end up issuing a `flips_stop()` if `check_flip()` returns `FALSE`. `present_wnmd_check_flip()` however can return `FALSE` in a variety of cases, before eventually checking with the driver's `check_flip2()` which in the case of `xwl_present_c