Re: [libXt:PATCH] XtAsprintf: Fix memory corruption.

2011-03-09 Thread Alan Coopersmith
On 03/ 8/11 01:14 PM, Alan Coopersmith wrote: On 03/ 8/11 07:09 AM, Cyril Brulebois wrote: Don't write the null terminator to a random place, this can trigger some segfault in XtOpenDisplay() and other annoyances. -new_string[len] = '\0'; +(*new_string)[len] = '\0'; Oops! Sorry.

[libXt:PATCH] XtAsprintf: Fix memory corruption.

2011-03-08 Thread Cyril Brulebois
Don't write the null terminator to a random place, this can trigger some segfault in XtOpenDisplay() and other annoyances. Debian Bug #617208 http://bugs.debian.org/617208 Signed-off-by: Cyril Brulebois k...@debian.org --- src/Alloc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [libXt:PATCH] XtAsprintf: Fix memory corruption.

2011-03-08 Thread Alan Coopersmith
On 03/ 8/11 07:09 AM, Cyril Brulebois wrote: Don't write the null terminator to a random place, this can trigger some segfault in XtOpenDisplay() and other annoyances. - new_string[len] = '\0'; + (*new_string)[len] = '\0'; Oops! Sorry. Yes. Reviewed-by: Alan Coopersmith