Re: [xserver,1/4] os: move xf86PrivsElevated here

2018-03-13 Thread Ben Crocker
Antoine, thanks for the suggestion and the additional review. V2 patch series forthcoming. -- Ben On Sat, Mar 10, 2018 at 11:58 PM, Antoine Martin wrote: > On 09/03/18 05:11, Ben Crocker wrote: > > Sent that a little too soon; please consider "Reviewed-by: Ben Crocker

Re: [xserver,1/4] os: move xf86PrivsElevated here

2018-03-10 Thread Antoine Martin
On 09/03/18 05:11, Ben Crocker wrote: > Sent that a little too soon; please consider "Reviewed-by: Ben Crocker > >" to be > added after each of the "Signed-off-by: Nicolai Haehnle > >" lines.

Re: [xserver,1/4] os: move xf86PrivsElevated here

2018-03-08 Thread Ben Crocker
Sent that a little too soon; please consider "Reviewed-by: Ben Crocker < bcroc...@redhat.com>" to be added after each of the "Signed-off-by: Nicolai Haehnle < nicolai.haeh...@amd.com>" lines. Also please note that I rebased Nicolai's original patch,

[xserver,1/4] os: move xf86PrivsElevated here

2018-03-08 Thread Ben Crocker
From: Nicolai Hähnle From: Nicolai Hähnle Having different types of code all trying to check for elevated privileges is a bad idea. This implementation is the most thorough one. Signed-off-by: Nicolai Hähnle ---

[PATCH xserver 1/4] os: move xf86PrivsElevated here

2017-01-27 Thread Nicolai Hähnle
From: Nicolai Hähnle Having different types of code all trying to check for elevated privileges is a bad idea. This implementation is the most thorough one. Signed-off-by: Nicolai Hähnle --- hw/xfree86/common/xf86Init.c | 59