Re: [xkb] Do XkbKSIsLower() and XkbKSIsUpper() matter?

2013-10-26 Thread Ran Benita
On Sat, Oct 26, 2013 at 02:04:55PM -0700, Alan Coopersmith wrote: > Does anyone know of any reason to waste time on this function? Can we just > delete it altogther now? (libxkbfile is undocumented, and was originally > considered private API, but we know software like GNOME has used it in the >

Do XkbKSIsLower() and XkbKSIsUpper() matter?

2013-10-26 Thread Alan Coopersmith
I tried a build with gcc's -Wlogicalops flag to see what other fun it would find, and of course, it triggered in XKB code, in libxkbfile: xkbmisc.c: In function '_XkbKSCheckCase': xkbmisc.c:100:13: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op] xkbmisc.c:114:13: