Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Michal Suchanek
Hello, is this by any chance related to the swap macro changes? ../../Xext/xselinux_ext.c: In function ‘SELinuxSendItemsToClient’: ../../Xext/xselinux_ext.c:340:16: warning: unused variable ‘n’ [-Wunused-variable] In function ‘SProcSELinuxQueryVersion’, inlined from ‘SProcSELinuxDispatch’ at

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Matt Turner
On Tue, Oct 4, 2011 at 9:24 AM, Michal Suchanek hramr...@centrum.cz wrote: Hello, is this by any chance related to the swap macro changes? ../../Xext/xselinux_ext.c: In function ‘SELinuxSendItemsToClient’: ../../Xext/xselinux_ext.c:340:16: warning: unused variable ‘n’ [-Wunused-variable]

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Michal Suchanek
On 4 October 2011 16:02, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011 at 9:24 AM, Michal Suchanek hramr...@centrum.cz wrote: Hello, is this by any chance related to the swap macro changes? ../../Xext/xselinux_ext.c: In function ‘SELinuxSendItemsToClient’:

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Matt Turner
On Tue, Oct 4, 2011 at 2:33 PM, Michal Suchanek hramr...@centrum.cz wrote: BTW it adds a warning about stuff variable being unused  - probably defined in one of the macros. It's because the swap macros stopped taking a second argument. Matt ___

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Michal Suchanek
On 4 October 2011 16:51, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011 at 2:33 PM, Michal Suchanek hramr...@centrum.cz wrote: BTW it adds a warning about stuff variable being unused  - probably defined in one of the macros. It's because the swap macros stopped taking a second

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Michal Suchanek
On 4 October 2011 16:57, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011 at 2:55 PM, Michal Suchanek hramr...@centrum.cz wrote: On 4 October 2011 16:51, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011 at 2:33 PM, Michal Suchanek hramr...@centrum.cz wrote: BTW it adds a

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Daniel Stone
Hi, On 4 October 2011 16:00, Michal Suchanek hramr...@centrum.cz wrote: On 4 October 2011 16:57, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011 at 2:55 PM, Michal Suchanek hramr...@centrum.cz wrote: On 4 October 2011 16:51, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011

Re: Maintaining backwards compatibility with swap macros

2011-10-04 Thread Michal Suchanek
On 4 October 2011 17:18, Daniel Stone dan...@fooishbar.org wrote: Hi, On 4 October 2011 16:00, Michal Suchanek hramr...@centrum.cz wrote: On 4 October 2011 16:57, Matt Turner matts...@gmail.com wrote: On Tue, Oct 4, 2011 at 2:55 PM, Michal Suchanek hramr...@centrum.cz wrote: On 4 October

Re: Maintaining backwards compatibility with swap macros

2011-10-03 Thread Matt Turner
On Mon, Oct 3, 2011 at 1:16 AM, Jeremy Huddleston jerem...@freedesktop.org wrote: Ok, given your agreement here, I'll go ahead with this if you don't beat me to it. --Jeremy Yes, if you have some time, please proceed. Matt ___

Re: Maintaining backwards compatibility with swap macros

2011-10-02 Thread Jeremy Huddleston
ping. I didn't see anything as a followup to my comments below. I'm fine with either approach, but I'd like to get this in soon. On Sep 25, 2011, at 11:22 AM, Jeremy Huddleston wrote: On Sep 25, 2011, at 10:50, Matt Turner wrote: Dave pointed out that there are a couple drivers (sis,

Re: Maintaining backwards compatibility with swap macros

2011-10-02 Thread Matt Turner
On Sun, Oct 2, 2011 at 2:15 AM, Jeremy Huddleston jerem...@freedesktop.org wrote: ping.  I didn't see anything as a followup to my comments below.  I'm fine with either approach, but I'd like to get this in soon. On Sep 25, 2011, at 11:22 AM, Jeremy Huddleston wrote: On Sep 25, 2011, at

Re: Maintaining backwards compatibility with swap macros

2011-10-02 Thread Jeremy Huddleston
On Oct 2, 2011, at 07:51, Matt Turner wrote: On Sun, Oct 2, 2011 at 2:15 AM, Jeremy Huddleston jerem...@freedesktop.org wrote: ping. I didn't see anything as a followup to my comments below. I'm fine with either approach, but I'd like to get this in soon. On Sep 25, 2011, at 11:22 AM,

Re: Maintaining backwards compatibility with swap macros

2011-10-02 Thread Keith Packard
On Sun, 2 Oct 2011 22:16:42 -0700, Jeremy Huddleston jerem...@freedesktop.org wrote: Ok, given your agreement here, I'll go ahead with this if you don't beat me to it. Thanks. I definitely prefer fixing the macros the 'right' way and then making drivers deal with the API change. Leaving API

Maintaining backwards compatibility with swap macros

2011-09-25 Thread Matt Turner
Dave pointed out that there are a couple drivers (sis, sisusb, vmware) that use the swapl/swaps macros. My recent patch series dropped the n argument from the macros, causing these drivers to not build. Ideally, we'd like a deprecation warning when the second argument is given, but by removing

Re: Maintaining backwards compatibility with swap macros

2011-09-25 Thread Jeremy Huddleston
On Sep 25, 2011, at 10:50, Matt Turner wrote: Dave pointed out that there are a couple drivers (sis, sisusb, vmware) that use the swapl/swaps macros. My recent patch series dropped the n argument from the macros, causing these drivers to not build. Ideally, we'd like a deprecation warning

Re: Maintaining backwards compatibility with swap macros

2011-09-25 Thread Jamey Sharp
On Sun, Sep 25, 2011 at 01:50:01PM -0400, Matt Turner wrote: Dave pointed out that there are a couple drivers (sis, sisusb, vmware) that use the swapl/swaps macros. My recent patch series dropped the n argument from the macros, causing these drivers to not build. Ideally, we'd like a