Re: [PATCH:macros 2/2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

2011-04-28 Thread Gaetan Nadon
On Wed, 2011-04-27 at 19:13 -0700, Dan Nicholson wrote: On Wed, Apr 27, 2011 at 5:32 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 04/27/11 03:54 AM, Dan Nicholson wrote: IMO, you should at least AC_SUBST the variable if you want to use it somewhere else. I just wanted to

Re: [PATCH:macros 2/2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

2011-04-27 Thread Dan Nicholson
On Mon, Apr 25, 2011 at 8:35 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Still only adds it to CWARNFLAGS if --enable-strict-compilation is passed, but sets the variable with the right flags for the compiler so it's available for other checks in configure scripts. Signed-off-by:

Re: [PATCH:macros 2/2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

2011-04-27 Thread Jeremy Huddleston
Actually, I think you should do this for gcc since it doesn't automatically error on unknown attributes (then I can pull that into the xorg-tls macro): STRICT_CFLAGS=-pedantic -Werror -Werror=attributes On Apr 27, 2011, at 3:54 AM, Dan Nicholson wrote: On Mon, Apr 25, 2011 at 8:35 PM, Alan

Re: [PATCH:macros 2/2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

2011-04-27 Thread Alan Coopersmith
On 04/27/11 03:54 AM, Dan Nicholson wrote: IMO, you should at least AC_SUBST the variable if you want to use it somewhere else. I just wanted to make it available to the XORG_TLS macro Jeremy's working on, not in a Makefile - is AC_SUBST needed for that? On the other hand it doesn't hurt, so I

Re: [PATCH:macros 2/2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

2011-04-27 Thread Dan Nicholson
On Wed, Apr 27, 2011 at 5:32 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 04/27/11 03:54 AM, Dan Nicholson wrote: IMO, you should at least AC_SUBST the variable if you want to use it somewhere else. I just wanted to make it available to the XORG_TLS macro Jeremy's working on,

Re: [PATCH:macros 2/2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

2011-04-26 Thread Gaetan Nadon
On Mon, 2011-04-25 at 20:35 -0700, Alan Coopersmith wrote: Still only adds it to CWARNFLAGS if --enable-strict-compilation is passed, but sets the variable with the right flags for the compiler so it's available for other checks in configure scripts. Signed-off-by: Alan Coopersmith