I've just confirmed: my openSUSE box is *not* affected by fd unregistering
issue. So I won't treat it as an upstream bug anymore, and I'll drop all
additional verifications from this patch.
2016-02-12 10:13 GMT-02:00 Laércio de Sousa <
laercioso...@sme-mogidascruzes.sp.gov.br>:
>
> 2016-02-11 19:
2016-02-11 19:35 GMT-02:00 Peter Hutterer :
>
> I just checked the kernel sources and there is no specific error case that
> this code can trigger, it's something to do with the fd itself (EBADF,
> EPERM, etc.). I guess fd is already closed/reset by the time you get here.
> What errno do you get?
On Thu, Feb 11, 2016 at 08:23:55AM -0200, Laércio de Sousa wrote:
> 2016-02-11 0:56 GMT-02:00 Peter Hutterer :
>
> > we don't have a 1:1 mapping between devices and fd (e.g. wacom devices all
> > hang off a single fd). Even the fd itself is a DDX concept, so RemoveDevice
> > cannot close the fd.
>
On Thu, Feb 11, 2016 at 04:10:23PM -0200, Laércio de Sousa wrote:
> 2016-02-11 8:23 GMT-02:00 Laércio de Sousa <
> laercioso...@sme-mogidascruzes.sp.gov.br>:
>
> > 2016-02-11 0:56 GMT-02:00 Peter Hutterer :
> >
> >> we don't have a 1:1 mapping between devices and fd (e.g. wacom devices all
> >> ha
2016-02-11 8:23 GMT-02:00 Laércio de Sousa <
laercioso...@sme-mogidascruzes.sp.gov.br>:
> 2016-02-11 0:56 GMT-02:00 Peter Hutterer :
>
>> we don't have a 1:1 mapping between devices and fd (e.g. wacom devices all
>> hang off a single fd). Even the fd itself is a DDX concept, so
>> RemoveDevice
>>
On 10 February 2016 at 18:57, Laércio de Sousa
wrote:
> 2016-02-08 17:45 GMT-02:00 Adam Jackson :
>>
>> This introduces a warning:
>>
>> kdrive.c:1217:1: warning: no previous prototype for
>> 'systemd_logind_release_fd' [-Wmissing-prototypes]
>> systemd_logind_release_fd(int _major, int _minor, i
2016-02-11 0:56 GMT-02:00 Peter Hutterer :
> we don't have a 1:1 mapping between devices and fd (e.g. wacom devices all
> hang off a single fd). Even the fd itself is a DDX concept, so RemoveDevice
> cannot close the fd.
>
> What should happen here though is that the pDev->public.devicePrivate
> p
On Mon, Feb 08, 2016 at 02:45:43PM -0500, Adam Jackson wrote:
> On Fri, 2015-12-11 at 11:43 -0200, Laércio de Sousa wrote:
>
> > +void
> > +systemd_logind_release_fd(int _major, int _minor, int fd)
> > +{
> > +}
> > +
> > +void
> > +systemd_logind_vtenter(void)
> > +{
> > +}
>
> This introduces a
2016-02-08 17:45 GMT-02:00 Adam Jackson :
>
> This introduces a warning:
>
> kdrive.c:1217:1: warning: no previous prototype for
> 'systemd_logind_release_fd' [-Wmissing-prototypes]
> systemd_logind_release_fd(int _major, int _minor, int fd)
> ^
> kdrive.c:1222:1: warning: no previous prototype f
On Fri, 2015-12-11 at 11:43 -0200, Laércio de Sousa wrote:
> +void
> +systemd_logind_release_fd(int _major, int _minor, int fd)
> +{
> +}
> +
> +void
> +systemd_logind_vtenter(void)
> +{
> +}
This introduces a warning:
kdrive.c:1217:1: warning: no previous prototype for 'systemd_logind_release_f
10 matches
Mail list logo
