Re: [PATCH xserver] modesetting: Remove ms_crtc_msc_to_kernel_msc().

On Fri, 2018-05-04 at 14:14 +0200, Mario Kleiner wrote: > The function is ported from intel-ddx uxa backend around > 2013, where its stated purpose was to apply a vblank_offset > to msc values to correct for problems with those kernel > provided msc values. Some (somewhat magic and puzzling to >

Re: [PATCH xserver] modesetting: Remove ms_crtc_msc_to_kernel_msc().

I wrote a little program to simulate how ms_kernel_msc_to_crtc_msc() is implemented in servers 1.16 - 1.20 and how it responds to msc's delivered by the kernel. If i didn't make a mistake, then according to the compiler it turns out that ms_kernel_msc_to_crtc_msc is broken in all servers. The

Re: [PATCH xserver] modesetting: Remove ms_crtc_msc_to_kernel_msc().

On Fri, May 4, 2018 at 6:16 PM, Mike Lothian wrote: > Hi Mario > > Thanks for finding this > > Tested-by: Mike Lothian > That tested-by means it doesn't cause new harm, right? Not that it solves the plasmashell or steam freezes on itself? -mario >

Re: [PATCH xserver] modesetting: Remove ms_crtc_msc_to_kernel_msc().

Hi Mario Thanks for finding this Tested-by: Mike Lothian Cheers Mike On 4 May 2018 at 14:02, Mario Kleiner wrote: > Hi Daniel, Eero, > > On Fri, May 4, 2018 at 2:41 PM, Daniel Stone wrote: >> Hi Mario, >> >> On 4 May

Re: [PATCH xserver] modesetting: Remove ms_crtc_msc_to_kernel_msc().

Hi Daniel, Eero, On Fri, May 4, 2018 at 2:41 PM, Daniel Stone wrote: > Hi Mario, > > On 4 May 2018 at 13:14, Mario Kleiner wrote: >> Indeed, i found a Mesa bug yesterday which can cause Mesa's >> PresentPixmap request to spuriously feed garbage

Re: [PATCH xserver] modesetting: Remove ms_crtc_msc_to_kernel_msc().

Hi Mario, On 4 May 2018 at 13:14, Mario Kleiner wrote: > Indeed, i found a Mesa bug yesterday which can cause Mesa's > PresentPixmap request to spuriously feed garbage targetMSC's > into the driver under some conditions. However, while other > video drivers seem to