Re: [libxkbcommon] Pull request - many changes

2012-03-17 Thread Daniel Stone
Hi, On 16 March 2012 16:54, Ran Benita ran...@gmail.com wrote: On Sat, Mar 10, 2012 at 02:00:46PM +, Daniel Stone wrote: Great stuff - thanks again! I've pushed this, along with a bunch of other changes I've made, now. Great, thanks! And the changed you made are much better; especially

Re: [libxkbcommon] Pull request - many changes

2012-03-17 Thread wettstein509
And the changed you made are much better; especially removing geometry (by far the ugliest part) and overlays and radio groups (what the hell are those again?). Also removing atoms from the public API. Overlays are a very useful feature (I do not say this theoretically, I actually do use

Re: [libxkbcommon] Pull request - many changes

2012-03-17 Thread Daniel Stone
Hi, On 17 March 2012 15:21, wettstein...@solnet.ch wrote: And the changed you made are much better; especially removing geometry (by far the ugliest part) and overlays and radio groups (what the hell are those again?). Also removing atoms from the public API. Overlays are a very useful

Re: [libxkbcommon] Pull request - many changes

2012-03-17 Thread wettstein509
At the moment it just means they won't work in Wayland, but support might (might) be removed from the X server at some stage too. Is there any reason you can't just use a locked group or level rather than an overlay? I currently use overlays to have five layouts in my keymap, which is not

Re: [libxkbcommon] Pull request - many changes

2012-03-17 Thread Daniel Stone
Hi, On 17 March 2012 16:24, wettstein...@solnet.ch wrote: At the moment it just means they won't work in Wayland, but support might (might) be removed from the X server at some stage too.  Is there any reason you can't just use a locked group or level rather than an overlay? I currently

Re: [libxkbcommon] Pull request - many changes

2012-03-16 Thread Ran Benita
On Sat, Mar 10, 2012 at 02:00:46PM +, Daniel Stone wrote: Hi Ran, On 3 March 2012 22:40, Ran Benita ran...@gmail.com wrote: [I know the normal procedure is to send the patches for review in reasonable chunks to the list, however I won't have time the following weeks, and I don't want

Re: [libxkbcommon] Pull request - many changes

2012-03-10 Thread Daniel Stone
Hi Ran, On 3 March 2012 22:40, Ran Benita ran...@gmail.com wrote: [I know the normal procedure is to send the patches for review in reasonable chunks to the list, however I won't have time the following weeks, and I don't want them to get lost. So I'll try my luck now.] I set up a github