Re: [PATCH xserver] was: Re: Two long-standing server bugs

2013-09-05 Thread Peter Hutterer
On Wed, Sep 04, 2013 at 02:25:02PM -0400, Jasper St. Pierre wrote: Reviewed-by: Jasper St. Pierre jstpie...@mecheye.net thanks for the review and the patch. merged into my tree, will be upstream soon. Cheers, Peter On Wed, Sep 4, 2013 at 2:09 PM, Thomas Klausner w...@netbsd.org wrote:

Re: [PATCH xserver] was: Re: Two long-standing server bugs

2013-09-04 Thread Peter Hutterer
On Tue, Sep 03, 2013 at 09:47:28AM +0200, Thomas Klausner wrote: On Sun, Sep 01, 2013 at 01:37:31PM -0400, der Mouse wrote: The first is that CreateCursor (Xlib call XCreatePixmapCursor) with a non-bitmap source pixmap and a None mask is, as I read it, supposed to error out with BadMatch,

Re: [PATCH xserver] was: Re: Two long-standing server bugs

2013-09-04 Thread Thomas Klausner
On Wed, Sep 04, 2013 at 04:05:51PM +1000, Peter Hutterer wrote: On Tue, Sep 03, 2013 at 09:47:28AM +0200, Thomas Klausner wrote: On Sun, Sep 01, 2013 at 01:37:31PM -0400, der Mouse wrote: The first is that CreateCursor (Xlib call XCreatePixmapCursor) with a non-bitmap source pixmap and a

Re: [PATCH xserver] was: Re: Two long-standing server bugs

2013-09-04 Thread Alan Coopersmith
On 09/ 3/13 11:05 PM, Peter Hutterer wrote: From 8057fc810fb2815ea4c069ac9c1bc77709afb778 Mon Sep 17 00:00:00 2001 From: Thomas Klausner w...@netbsd.org Date: Tue, 3 Sep 2013 09:44:18 +0200 Subject: [PATCH:xserver] Fix bug in cursor handling. CreateCursor (Xlib call XCreatePixmapCursor)

Re: [PATCH xserver] was: Re: Two long-standing server bugs

2013-09-04 Thread Jasper St. Pierre
Yeah, this is how I would write it. Can you provide a patch, Alan? On Wed, Sep 4, 2013 at 2:30 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 09/ 3/13 11:05 PM, Peter Hutterer wrote: From 8057fc810fb2815ea4c069ac9c1bc77709afb778 Mon Sep 17 00:00:00 2001 From: Thomas Klausner

Re: [PATCH xserver] was: Re: Two long-standing server bugs

2013-09-04 Thread Thomas Klausner
On Wed, Sep 04, 2013 at 11:13:14AM -0400, Jasper St. Pierre wrote: Yeah, this is how I would write it. Can you provide a patch, Alan? I tried to make the code match Alan's suggestion, attached. While there, I fixed a typo in the configure.ac script, also attached. Thomas On Wed, Sep 4,

Re: [PATCH xserver] was: Re: Two long-standing server bugs

2013-09-04 Thread Jasper St. Pierre
Reviewed-by: Jasper St. Pierre jstpie...@mecheye.net On Wed, Sep 4, 2013 at 2:09 PM, Thomas Klausner w...@netbsd.org wrote: On Wed, Sep 04, 2013 at 11:13:14AM -0400, Jasper St. Pierre wrote: Yeah, this is how I would write it. Can you provide a patch, Alan? I tried to make the code

[PATCH xserver] was: Re: Two long-standing server bugs

2013-09-03 Thread Thomas Klausner
On Sun, Sep 01, 2013 at 01:37:31PM -0400, der Mouse wrote: The first is that CreateCursor (Xlib call XCreatePixmapCursor) with a non-bitmap source pixmap and a None mask is, as I read it, supposed to error out with BadMatch, but doesn't. This is the one I fixed. The second is that pixmap

Two long-standing server bugs

2013-09-01 Thread Mouse
I recently found two very long-standing server bugs (they date back to at least X11R4, possibly farther). I found these in the X shipped with NetBSD 5.2, which is X11R7 of some stripe - I'm not sure how to get any more detailed version. I don't know whether they are present in bleeding edge

Re: Two long-standing server bugs

2013-09-01 Thread Alan Coopersmith
On 09/ 1/13 10:37 AM, Mouse wrote: I found these in the X shipped with NetBSD 5.2, which is X11R7 of stripe - I'm not sure how to get any more detailed version. We mainly use module versions now that everything is released individually on a more frequent scale than X11R7.* releases, so the

Re: Two long-standing server bugs

2013-09-01 Thread Mouse
I found these in the X shipped with NetBSD 5.2, which is X11R7 of [some] stripe - I'm not sure how to get any more detailed version. Xorg -version should provide that. X.Org X Server 1.6.3 Release Date: 2009-7-7 X Protocol Version 11, Revision 0 Build Operating System: NetBSD/amd64 - Current