Re: glamor versus AIGLX GL context series

2014-04-22 Thread Keith Packard
Adam Jackson writes: > Minor comment on 9/12 that I don't think is a blocker. Otherwise, > series plus Michel's fix are: I found a couple of other spurious glamor_make_current calls which I mentioned. I'm easy as to whether those are fixed before this lands or not; I assume Eric will want to ad

Re: glamor versus AIGLX GL context series

2014-04-22 Thread Keith Packard
Eric Anholt writes: >> BTW, the 'glamor: Add glamor_transfer based glamor_get_image and >> glamor_put_image' commit in your glamor-fixes branch still breaks the >> libreoffice icons for me. Are you guys seeing that as well? > > Nope, don't see that here. I've sent a patch that fixes this to the

Re: glamor versus AIGLX GL context series

2014-04-22 Thread Adam Jackson
On Fri, 2014-04-18 at 11:39 -0700, Eric Anholt wrote: > Here it is, at long last. I was stumped for several days with a weird > fbo incomplete that was happening after my first round of fixes, and > it took a day's detour of cooking up a Xephyr with DRI3 to get a fast > debug environment and figur

Re: glamor versus AIGLX GL context series

2014-04-22 Thread Eric Anholt
Michel Dänzer writes: > On 22.04.2014 04:08, Eric Anholt wrote: >> I think the must-do items for glamor in 1.16 will be done. > > As I mentioned before, there's also at least one fix for a memory leak > in copy_n_to_n that needs to be ported from the standalone glamor tree, > if Keith's copy_n_to

Re: glamor versus AIGLX GL context series

2014-04-22 Thread Eric Anholt
Michel Dänzer writes: > On 22.04.2014 04:08, Eric Anholt wrote: >> Michel Dänzer writes: >>> >>> By changing the context, it may also invalidate the DRI2 buffer information, >>> so we need to get that again. >>> >>> Fixes crashes due to use-after-free with LIBGL_ALWAYS_INDIRECT=1 glxgears >>> a

Re: glamor versus AIGLX GL context series

2014-04-21 Thread Michel Dänzer
On 22.04.2014 04:08, Eric Anholt wrote: > Michel Dänzer writes: >> >> By changing the context, it may also invalidate the DRI2 buffer information, >> so we need to get that again. >> >> Fixes crashes due to use-after-free with LIBGL_ALWAYS_INDIRECT=1 glxgears >> and piglit. > > Glad to see thing

Re: glamor versus AIGLX GL context series

2014-04-21 Thread Eric Anholt
Michel Dänzer writes: > On 19.04.2014 03:39, Eric Anholt wrote: >> Here it is, at long last. I was stumped for several days with a weird >> fbo incomplete that was happening after my first round of fixes, and >> it took a day's detour of cooking up a Xephyr with DRI3 to get a fast >> debug envir

Re: glamor versus AIGLX GL context series

2014-04-21 Thread Michel Dänzer
On 19.04.2014 03:39, Eric Anholt wrote: > Here it is, at long last. I was stumped for several days with a weird > fbo incomplete that was happening after my first round of fixes, and > it took a day's detour of cooking up a Xephyr with DRI3 to get a fast > debug environment and figure out what was

glamor versus AIGLX GL context series

2014-04-18 Thread Eric Anholt
Here it is, at long last. I was stumped for several days with a weird fbo incomplete that was happening after my first round of fixes, and it took a day's detour of cooking up a Xephyr with DRI3 to get a fast debug environment and figure out what was going on (xephyr-glamor-egl is that branch. I