Re: is _X_INLINE still needed

2024-02-06 Thread Alan Coopersmith
On 2/5/24 06:27, Enrico Weigelt, metux IT consult wrote: On 02.02.24 18:33, Alan Coopersmith wrote: For the Xorg server, the ones listed in https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/hw/xfree86/sdksyms.sh is this script actually used somewhere ? It looks like some test script

Re: is _X_INLINE still needed

2024-02-06 Thread Enrico Weigelt, metux IT consult
On 02.02.24 18:33, Alan Coopersmith wrote: For the Xorg server, the ones listed in https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/hw/xfree86/sdksyms.sh is this script actually used somewhere ? It looks like some test script - should we include it into some test stage in the build

Re: is _X_INLINE still needed

2024-02-02 Thread Alan Coopersmith
On 2/2/24 03:42, Enrico Weigelt, metux IT consult wrote: On 01.02.24 19:29, Alan Coopersmith wrote: Hi Alan, Which ones are public ? For the Xorg server, the ones listed in https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/hw/xfree86/sdksyms.sh is this script actually used

Re: is _X_INLINE still needed

2024-02-02 Thread Enrico Weigelt, metux IT consult
On 01.02.24 19:29, Alan Coopersmith wrote: Hi Alan, Which ones are public ? For the Xorg server, the ones listed in https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/hw/xfree86/sdksyms.sh is this script actually used somewhere ? It looks like some test script - should we include

Re: is _X_INLINE still needed

2024-02-01 Thread Alan Coopersmith
On 2/1/24 03:33, Enrico Weigelt, metux IT consult wrote: On 31.01.24 20:22, Alan Coopersmith wrote: Hi Alan, In public headers, I'd say it's still needed, as we've always supported Which ones are public ? For the Xorg server, the ones listed in

Re: is _X_INLINE still needed

2024-02-01 Thread Enrico Weigelt, metux IT consult
On 01.02.24 12:33, Enrico Weigelt, metux IT consult wrote: made a PR on this: https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1264 --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie

Re: is _X_INLINE still needed

2024-02-01 Thread Enrico Weigelt, metux IT consult
On 31.01.24 20:22, Alan Coopersmith wrote: Hi Alan, In public headers, I'd say it's still needed, as we've always supported Which ones are public ? Here's a quick grep of Xserver tree: nekrad@orion:~/src/xorg/xserver$ git grep _X_INLINE Xext/security.c:static _X_INLINE const char *

Re: is _X_INLINE still needed

2024-01-31 Thread Alan Coopersmith
On 1/31/24 11:01, Enrico Weigelt, metux IT consult wrote: Hello folks, I wonder whether the _X_INLINE still needed (inside X server codebase). It's coming from from xproto (>=7.0.9) and seems to tbe just workaround for old compilers that didn't understand the inline keyword yet. (persona

is _X_INLINE still needed

2024-01-31 Thread Enrico Weigelt, metux IT consult
Hello folks, I wonder whether the _X_INLINE still needed (inside X server codebase). It's coming from from xproto (>=7.0.9) and seems to tbe just workaround for old compilers that didn't understand the inline keyword yet. (personally, don't actually recall having one that didn't, m