Re: issues and merge requests

2024-02-08 Thread Enrico Weigelt, metux IT consult
On 07.02.24 12:20, Olivier Fourdan wrote: As Peter explained, "Fixes" refers to a commit in particular (like a regression was introduced, then fixed with a later commit, that later commit "fixes" the first commit) - That is useful for example when backporting between branches, because those can

Re: issues and merge requests

2024-02-07 Thread Olivier Fourdan
Hi, On Wed, Feb 7, 2024 at 11:47 AM Enrico Weigelt, metux IT consult < i...@metux.net> wrote: > On 07.02.24 00:59, Peter Hutterer wrote: > >> Closes: xorg/xserver#1631 > > > > It supports that too, but afaik the use of Fixes is more common in the > > xorg repo. In (some?) gnome OTOH repos Closes

Re: issues and merge requests

2024-02-07 Thread Enrico Weigelt, metux IT consult
On 07.02.24 00:59, Peter Hutterer wrote: Hi, Closes: xorg/xserver#1631 It supports that too, but afaik the use of Fixes is more common in the xorg repo. In (some?) gnome OTOH repos Closes refers to an issue anf Fixes usually to a commit. Okay, so settle to "Fixes:" ? Perhaps it's time to

Re: issues and merge requests

2024-02-07 Thread Enrico Weigelt, metux IT consult
On 05.02.24 22:56, Peter Hutterer wrote: Best approach is to add a line "Fixes #123" into the commit message and/or the merge request and gitlab will automatically link to to issue 123 in the same repo and close it when merged. I believe gitlab reacts on "Closes:", like this: Closes:

Re: issues and merge requests

2024-02-06 Thread Peter Hutterer
On Tue, Feb 06, 2024 at 11:41:06AM +0100, Enrico Weigelt, metux IT consult wrote: > On 05.02.24 22:56, Peter Hutterer wrote: > > > Best approach is to add a line "Fixes #123" into the commit message > > and/or the merge request and gitlab will automatically link to to issue > > 123 in the same

Re: issues and merge requests

2024-02-06 Thread tlaronde
On Tue, Feb 06, 2024 at 07:56:16AM +1000, Peter Hutterer wrote: > On Mon, Feb 05, 2024 at 09:52:50PM +0100, tlaro...@kergis.com wrote: > > Alan Coopersmith has applied the merge request for libXau---thanks! > > > > I had written 2 issues, related, against libXau, that the patches > > address, so

Re: issues and merge requests

2024-02-05 Thread Peter Hutterer
On Mon, Feb 05, 2024 at 09:52:50PM +0100, tlaro...@kergis.com wrote: > Alan Coopersmith has applied the merge request for libXau---thanks! > > I had written 2 issues, related, against libXau, that the patches > address, so I have closed the issues after the merge. > > It seems to me that writing

issues and merge requests

2024-02-05 Thread tlaronde
Alan Coopersmith has applied the merge request for libXau---thanks! I had written 2 issues, related, against libXau, that the patches address, so I have closed the issues after the merge. It seems to me that writing issues against a module; providing patches via a merge request; then closing the