Re: xserver: do we still need Fopen()

2024-02-09 Thread Alan Coopersmith
On 2/8/24 04:25, Enrico Weigelt, metux IT consult wrote: On 08.02.24 00:19, Alan Coopersmith wrote: If the Xserver is run as setuid root, On which platforms is that still the case ? Platforms which support users starting the Xserver directly (startx/xinit/etc instead of via systemd service

Re: xserver: do we still need Fopen()

2024-02-08 Thread Enrico Weigelt, metux IT consult
On 08.02.24 13:41, tlaro...@kergis.com wrote: I'm for example still using it this way (I'm mainly developing and I don't always need a graphical interface and don't want to waste permanently resources by using and administrating a display manager for which I'm the sole and temporary user). Not

Re: xserver: do we still need Fopen()

2024-02-08 Thread tlaronde
On Thu, Feb 08, 2024 at 01:25:24PM +0100, Enrico Weigelt, metux IT consult wrote: > > > > > > On which platforms is that still the case ? > > > > Platforms which support users starting the Xserver directly > > (startx/xinit/etc > > instead of via systemd service or display manager) on devices

xserver: do we still need Fopen()

2024-02-08 Thread Enrico Weigelt, metux IT consult
On 08.02.24 00:19, Alan Coopersmith wrote: Hi, Does WIN32 still mean 32bit Windows or also more modern ones like w10/w11 ? I believe it's still defined for 64-bit Windows, as stated on https://learn.microsoft.com/en-us/windows/win32/winprog64/additional-considerations but I never code or

Re: xserver: do we still need Fopen() ?

2024-02-07 Thread Alan Coopersmith
On 2/5/24 06:41, Enrico Weigelt, metux IT consult wrote: On 02.02.24 21:05, Alan Coopersmith wrote: Hi, I suspect for the OS'es that the xserver code builds on today, that could be replaced by #ifndef WIN32, which would then allow the first half of that #ifdef in Fopen to be deleted, leaving

Re: xserver: do we still need Fopen() ?

2024-02-06 Thread Enrico Weigelt, metux IT consult
On 03.02.24 03:41, Alan Coopersmith wrote: https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1266 great :) I've almost had done it on my own. --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation

Re: xserver: do we still need Fopen() ?

2024-02-05 Thread Enrico Weigelt, metux IT consult
On 02.02.24 21:05, Alan Coopersmith wrote: Hi, I suspect for the OS'es that the xserver code builds on today, that could be replaced by #ifndef WIN32, which would then allow the first half of that #ifdef in Fopen to be deleted, leaving just the simpler case, since Fopen is already not built

Re: xserver: do we still need Fopen() ?

2024-02-02 Thread Alan Coopersmith
On 2/2/24 12:05, Alan Coopersmith wrote: On 2/2/24 05:45, Enrico Weigelt, metux IT consult wrote: Hello folks, I wonder whether we still need the Fopen() function. It's a funny and complicated way of loading a file with dropped privs (by calling `cat` on that file !). It only does the cat

Re: xserver: do we still need Fopen() ?

2024-02-02 Thread Alan Coopersmith
On 2/2/24 05:45, Enrico Weigelt, metux IT consult wrote: Hello folks, I wonder whether we still need the Fopen() function. It's a funny and complicated way of loading a file with dropped privs (by calling `cat` on that file !). It only does the cat if HAS_SAVED_IDS_AND_SETEUID is not

Re: xserver: do we still need Fopen() ?

2024-02-02 Thread Adam Sampson
"Enrico Weigelt, metux IT consult" writes: > But this doesn't make much sense to me: why should the xserver - if > started as root (but dropping privs) - be prevented from reading an > xauth file ? Maybe for NFS? Imagine (it's the late 90s and) you've got a workstation running an X server as

xserver: do we still need Fopen() ?

2024-02-02 Thread Enrico Weigelt, metux IT consult
Hello folks, I wonder whether we still need the Fopen() function. It's a funny and complicated way of loading a file with dropped privs (by calling `cat` on that file !). The only call site is LoadAuthorization() (auth.c) for loading the Xauthority file (if one was passed to xserver via -auth