[PATCH] kdrive: Bump evdev maxKeycode

2010-03-22 Thread Mikhail Gusarov
There are keycodes 193 in evdev, e.g. KEY_WIMAX which is 246 . Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- hw/kdrive/linux/evdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] Atomic query requests

2010-03-22 Thread Peter Hutterer
On Fri, Mar 19, 2010 at 12:07:05PM -0400, Adam Jackson wrote: On Tue, 2010-03-16 at 10:56 +1000, Peter Hutterer wrote: On Mon, Mar 15, 2010 at 12:06:15PM -0400, Adam Jackson wrote: +QueryPointer + + - + + mask: SETofKEYBUTMASK +

Howto load a program as root automaticly(xinitrc-common not work any more)

2010-03-22 Thread yhch
Hi I used to use xinitrc-common to load my program as root automaticly,but this mothod stop working since FC11.What can I do if I still need to load my program as root (in system scripts)? Any kind of help will be appreciated because I can't manage to find any Docs about this change at all.

Re: Multitouch followup: gesture recognition?

2010-03-22 Thread Simon Thum
Am 21.03.2010 10:37, schrieb Florian Echtler: Now, in an Xorg context, I'd very much like to hear your opinions on these concepts. Would it make sense to build this into an X helper library? I'm a bit worried that discussion is inclined towards a library, as opposed to a composite-inspired

Re: [ANNOUNCE] xorg-server 1.7.99.902

2010-03-22 Thread Stefan Dirsch
On Sun, Mar 21, 2010 at 10:45:26PM -0700, Keith Packard wrote: According to the published schedule, we're supposed to be closing in on the release within the next couple of weeks. I'm pretty satisfied with the current state of the code, but I'd love to hear about regressions that people are

Re: [PATCHv10 4/5] dri2: Support the DRI2InvalidateBuffers event.

2010-03-22 Thread Francisco Jerez
Keith Packard kei...@keithp.com writes: On Tue, 16 Mar 2010 10:26:54 -0400, Kristian Høgsberg k...@bitplanet.net wrote: Yes, the series look good and I've updated my branch: I don't like this code. It adds an unnecessary layer between DRI2TrackClient and the dri2ext code, with a 'priv'

Re: [ANNOUNCE] xorg-server 1.7.99.902

2010-03-22 Thread Dan Nicholson
On Mon, Mar 22, 2010 at 3:12 AM, Stefan Dirsch sndir...@suse.de wrote: On Sun, Mar 21, 2010 at 10:45:26PM -0700, Keith Packard wrote: According to the published schedule, we're supposed to be closing in on the release within the next couple of weeks. I'm pretty satisfied with the current

Re: [PATCH] configure: Always define XINPUT.

2010-03-22 Thread Dan Nicholson
On Sun, Mar 21, 2010 at 4:40 PM, Peter Hutterer peter.hutte...@who-t.net wrote: This define was removed in e251c9e75afdc Remove all traces of #ifdef XINPUT and the matching bits from the configure.ac. Drivers that support multiple server versions and still check for ifdef XINPUT now always

[PATCH] dix: Export more input related functions from Xorg

2010-03-22 Thread Adam Tkac
Hello all, I would like to ask you to apply attached patch to both master and server-1.7-branches. The patch exports four functions, AllocDevicePair, GetPointerEvents, GetKeyboardEvents and generate_modkeymap, from Xorg. Those functions are currently used by TigerVNC libvnc.so module which

Re: [PATCH app, driver, libs 0/43] Replace deprecated Automake INCLUDES variable

2010-03-22 Thread Alan Coopersmith
Gaetan Nadon wrote: On Fri, 2010-03-19 at 13:53 -0700, Alan Coopersmith wrote: Gaetan Nadon wrote: The server sticks -fvisibility compiler flag in the pkg Cflags which does not help while 99% of pkg-config files on my distro are compiler flags free. Which is probably a bug in itself - I

Re: [ANNOUNCE] xorg-server 1.7.99.902

2010-03-22 Thread Dan Nicholson
On Mon, Mar 22, 2010 at 7:15 AM, Stefan Dirsch sndir...@suse.de wrote: On Mon, Mar 22, 2010 at 05:56:03AM -0700, Dan Nicholson wrote: On Mon, Mar 22, 2010 at 3:12 AM, Stefan Dirsch sndir...@suse.de wrote: On Sun, Mar 21, 2010 at 10:45:26PM -0700, Keith Packard wrote: According to the

Re: [PATCHv10 4/5] dri2: Support the DRI2InvalidateBuffers event.

2010-03-22 Thread Keith Packard
On Mon, 22 Mar 2010 12:51:36 +0100, Francisco Jerez curroje...@riseup.net wrote: v9 of this patch is almost what you're describing (link: [1]). The AIGLX code also makes use of this interface and in that case it didn't make a lot of sense to deal with resources, so we decided to kick resource

Xorg multitouch support

2010-03-22 Thread Micki Balanga
Hi My name is Micki I work at N-trig (http://www.n-trig.com/). I would like to participate in the Multi-touch support in Xorg. Can you show me relevant threads. As you know we have starting the release of our kernel driver to the open source. We have user space application which receive the

Re: [ANNOUNCE] xorg-server 1.7.99.902

2010-03-22 Thread Dan Nicholson
On Mon, Mar 22, 2010 at 7:59 AM, Dan Nicholson dbn.li...@gmail.com wrote: On Mon, Mar 22, 2010 at 7:15 AM, Stefan Dirsch sndir...@suse.de wrote: On Mon, Mar 22, 2010 at 05:56:03AM -0700, Dan Nicholson wrote: On Mon, Mar 22, 2010 at 3:12 AM, Stefan Dirsch sndir...@suse.de wrote: On Sun, Mar

Re: [ANNOUNCE] xorg-server 1.7.99.902

2010-03-22 Thread Stefan Dirsch
On Mon, Mar 22, 2010 at 07:59:18AM -0700, Dan Nicholson wrote: No, once you have an empty xorg.conf you're lost, an empty xorg.conf.d directory is still ok though. That makes sense. There are two ways to handle this. 1. Make the full autoconfig kick in when only xorg.conf is missing. I

Re: [PATCH] kdrive: Bump evdev maxKeycode

2010-03-22 Thread Adam Jackson
On Mon, 2010-03-22 at 12:15 +0600, Mikhail Gusarov wrote: There are keycodes 193 in evdev, e.g. KEY_WIMAX which is 246 . Ack in theory, but: --- a/hw/kdrive/linux/evdev.c +++ b/hw/kdrive/linux/evdev.c @@ -362,7 +362,7 @@ readMapping (KdKeyboardInfo *ki) return;

Re: [PATCH app, driver, libs 0/43] Replace deprecated Automake INCLUDES variable

2010-03-22 Thread Gaetan Nadon
On Mon, 2010-03-22 at 07:52 -0700, Alan Coopersmith wrote: Gaetan Nadon wrote: On Fri, 2010-03-19 at 13:53 -0700, Alan Coopersmith wrote: Gaetan Nadon wrote: The server sticks -fvisibility compiler flag in the pkg Cflags which does not help while 99% of pkg-config files on my distro

Re: Howto load a program as root automaticly(xinitrc-common not work any more)

2010-03-22 Thread Dan Nicholson
On Mon, Mar 22, 2010 at 1:11 AM, yhch y...@generaltouch.com wrote: Hi I used to use xinitrc-common to load my program as root automaticly,but this mothod stop working since FC11.What can I do if I still need to load my program as root (in system scripts)? Any kind of help will be appreciated

clang static analysis of xorg-server

2010-03-22 Thread Jeremy Huddleston
I ran the static analyzer on a build of the current git master of xorg-server. Here are the results: http://people.freedesktop.org/~jeremyhu/clang/2010-03-22-1/ There are quite a number of hidden issues. Would people find it useful to have this data part of tinderbox.x.org? If so, I'll look

[PATCH] GLX: Fix initialization of some glXDispSwap requests

2010-03-22 Thread Jeremy Huddleston
Found by the clang static analyzer __glXDispSwap_DestroyPbuffer __glXDispSwap_DestroyGLXPbufferSGIX __glXDispSwap_ChangeDrawableAttributes __glXDispSwap_ChangeDrawableAttributesSGIX Signed-off-by: Jeremy Huddleston jerem...@apple.com --- glx/glxcmdsswap.c |8 1 files changed, 4

[PATCH] GLX/DRI2: Fix build against Mesa 7.7.

2010-03-22 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Seems to work as well... Signed-off-by: Michel Dänzer daen...@vmware.com --- configure.ac |2 +- glx/glxdri2.c |9 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index d379b3a..3aeedd3 100644

[PATCH] Xext: Fix cursor reference counting hazard.

2010-03-22 Thread Michel Dänzer
From: Michel Dänzer daen...@vmware.com Make sure the reference count of the new cursor is increased before the old one is decreased, otherwise bad things will happen if they're one and the same and the reference count is 1 initially. Not sure this can actually happen here, but better safe than

Re: clang static analysis of xorg-server

2010-03-22 Thread Matthias Hopf
On Mar 22, 10 09:58:59 -0700, Jeremy Huddleston wrote: I ran the static analyzer on a build of the current git master of xorg-server. Here are the results: http://people.freedesktop.org/~jeremyhu/clang/2010-03-22-1/ There are quite a number of hidden issues. Would people find it useful to

[xserver patch] Optimize shadowUpdatePacked()

2010-03-22 Thread Adrian Bunk
From: Ilpo Ruotsalainen ilpo.ruotsalai...@movial.com http://bugs.freedesktop.org/show_bug.cgi?id=26973 Signed-off-by: Adrian Bunk adrian.b...@movial.com --- We already ship this patch in the ARM Linux Internet Platform, and it looks like a good candidate for upstream inclusion. The #define

[PATCH] Fix typos in the swap functions

2010-03-22 Thread Ian Romanick
From: Tomas Carnecky t...@dbservice.com This should fix bug #3539. Signed-off-by: Tomas Carnecky t...@dbservice.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- glx/glxcmdsswap.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/glx/glxcmdsswap.c

Re: [PATCH libX11] Clean up some pointer signedness and qualifier warnings

2010-03-22 Thread Jeff Smith
In all cases here, the contents (i.e. the individual char/unsigned char elements) are never being accessed directly. I am just changing the casting so that they match the prototype of the function they are subsequently being passed into. Is this any more odd than simplifying (char *)(unsigned

Re: [xserver patch] Optimize shadowUpdatePacked()

2010-03-22 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Adrian Bunk wrote: From: Ilpo Ruotsalainen ilpo.ruotsalai...@movial.com http://bugs.freedesktop.org/show_bug.cgi?id=26973 Signed-off-by: Adrian Bunk adrian.b...@movial.com --- We already ship this patch in the ARM Linux Internet Platform,

Re: [PATCH] GLX: Fix initialization of some glXDispSwap requests

2010-03-22 Thread Jeremy Huddleston
On Mar 22, 2010, at 11:24, Ian Romanick wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeremy Huddleston wrote: Found by the clang static analyzer __glXDispSwap_DestroyPbuffer __glXDispSwap_DestroyGLXPbufferSGIX __glXDispSwap_ChangeDrawableAttributes

[PATCH v2] kdrive: Bump evdev maxKeycode

2010-03-22 Thread Mikhail Gusarov
There are keycodes 193 in evdev, e.g. KEY_WIMAX which is 246 . Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Adam Jackson a...@nwnk.net --- hw/kdrive/linux/evdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [PATCHv10 4/5] dri2: Support the DRI2InvalidateBuffers event.

2010-03-22 Thread Kristian Høgsberg
On Sun, Mar 21, 2010 at 8:10 PM, Keith Packard kei...@keithp.com wrote: On Tue, 16 Mar 2010 10:26:54 -0400, Kristian Høgsberg k...@bitplanet.net wrote: Yes, the series look good and I've updated my branch: I don't like this code. It adds an unnecessary layer between DRI2TrackClient and the

[PATCH] Use arc4random instead of rand where available

2010-03-22 Thread Jeremy Huddleston
Mainly to shut up clang. These are not security-sensitive uses of rand() Signed-off-by: Jeremy Huddleston jerem...@apple.com --- configure.ac|2 +- dix/window.c| 18 ++ exa/exa_glyphs.c|8 include/dix-config.h.in |3 +++ 4

[PATCH] Fix crash when all glyphs of a given depth are freed, but not all glyphsets

2010-03-22 Thread Peter Harris
This is how the crash can be triggered with only two clients on the system: Client A: (already running) Client B: Connect Client B: CreateGlyphSet(depthN) Client A: Disconnect Server: free globalGlyphs(depthN) Client B: AddGlyphs(depthN) Server: SEGV This crash was introduced with the

Re: [xserver patch v5 3/5] glx: Enforce a 1:1 correspondence between GLX and X11 windows.

2010-03-22 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Kristian Høgsberg wrote: 2010/2/8 Francisco Jerez curroje...@riseup.net: The spec says (regarding glXCreateWindow): If there is already a GLXFBConfig associated with win (as a result of a previous glXCreateWindow call), then a BadAlloc error is

Re: [PATCH] Use arc4random instead of rand where available

2010-03-22 Thread Tiago Vignatti
Jeremy Huddleston wrote: Mainly to shut up clang. These are not security-sensitive uses of rand() Signed-off-by: Jeremy Huddleston jerem...@apple.com --- configure.ac|2 +- dix/window.c| 18 ++ exa/exa_glyphs.c|8

Re: [PATCH xhost] Resource cleanup fixes

2010-03-22 Thread Alan Coopersmith
Reviewed-by: Alan Coopersmith alan.coopersm...@sun.com Jeff Smith wrote: Running xhost through valgrind (with no arguments to xhost) produced still reachable: 27,720 bytes in 25 blocks. This patch reduces this to still reachable: 15 bytes in 1 blocks. Signed-off-by: Jeff Smith

Re: [PATCH xset] Resource cleanup fixes

2010-03-22 Thread Alan Coopersmith
Jeff Smith wrote: + /* There is no funtion to complement XF86MiscGetFilePaths */ Typo: s/funtion/function/ Other than that, looks good. Reviewed-by: Alan Coopersmith alan.coopersm...@sun.com -- -Alan Coopersmith- alan.coopersm...@sun.com Oracle Solaris

Re: clang static analysis of xorg-server

2010-03-22 Thread Alan Coopersmith
Jeremy Huddleston wrote: I aree ... some of the dead store issues are more stylistic or future proofing. The real ones we should consider are the logic errors... garbage assignment and null dereference. Some of the errors seem outright bogus

Re: [PATCH] GLX/DRI2: Fix build against Mesa 7.7.

2010-03-22 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com Seems to work as well... Signed-off-by: Michel Dänzer daen...@vmware.com I've applied this to my GLX-fixes tree. It seems like this should be in X server 1.8, yes? -BEGIN PGP

Re: [PATCH xserver/dri2 3/3] DRI2SwapBuffers: Return SBC correctly, handle target_msc correctly.

2010-03-22 Thread Jesse Barnes
On Mon, 22 Mar 2010 13:59:44 -0700 Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jesse Barnes wrote: On Sun, 21 Feb 2010 05:26:01 +0100 Mario Kleiner mario.klei...@tuebingen.mpg.de wrote: Returns expected SBC after completion of swap to

Re: [xserver patch v5 3/5] glx: Enforce a 1:1 correspondence between GLX and X11 windows.

2010-03-22 Thread Kristian Høgsberg
2010/3/22 Ian Romanick i...@freedesktop.org: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Kristian Høgsberg wrote: 2010/2/8 Francisco Jerez curroje...@riseup.net: The spec says (regarding glXCreateWindow): If there is already a GLXFBConfig associated with win (as a result of a previous

Re: [PATCH xdriinfo] Resource cleanup fixes

2010-03-22 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Smith wrote: Running xdriinfo through valgrind (with no arguments to xdriinfo) and screen 'not direct rendering capable' produced still reachable: 41,240 bytes in 30 blocks. This patch reduces this to still reachable: 35 bytes in 2 blocks.

Re: [PATCH libxtrans] Clean up some 'unused variable' warnings

2010-03-22 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Specific comments below. Given the nature of the changes and some of my comments, I think these should be broken into a separate patch for each variable. If nothing else, it makes reviewing the changes easier. Jeff Smith wrote: Signed-off-by: Jeff

DRI2 fixes

2010-03-22 Thread Jesse Barnes
This is a collection of fixes from my personal server tree targeting the 1.8 release. They're mostly small fixes, but they fix a few important (i.e. common) cases with the new protocol code. Please review; I'll make any necessary changes, add the Reviewed-by tags, and push to Keith. Thanks,

[PATCH 01/12] DRI2: fixup handling of last_swap_target

2010-03-22 Thread Jesse Barnes
We need to initialize the swap target, which is passed to the driver to schedule events. Rather than using -1 to indicate that the field is uninitialized, just make sure we initialize it at drawable creation time. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- hw/xfree86/dri2/dri2.c |

[PATCH 04/12] DRI2WaitSbc(): Fixes for correct semantic of glXWaitForSbcOML()

2010-03-22 Thread Jesse Barnes
From: Mario Kleiner mario.klei...@tuebingen.mpg.de Added implementation for case target_sbc == 0. In that case, the function shall schedule a wait until all pending swaps for the drawable have completed. Fix for non-blocking case. Old implementation returned random, uninitialized values for

[PATCH 02/12] DRI2: make target_sbc signed

2010-03-22 Thread Jesse Barnes
We need to track invalid targets as well as 0 targets, so just make it signed so our comparisons work like they should. Reported-by: Kristian Høgsberg k...@bitplanet.net Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- hw/xfree86/dri2/dri2.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 06/12] DRI2: drawable lifetime fixes

2010-03-22 Thread Jesse Barnes
Handle drawable destruction and lifetime correctly. Check whether the drawable priv is valid in DRI2SwapInterval(), DRI2WaitSBC() and DRI2WaitMSC(); it may have gone away, so be sure to check it before using it. If more than 1 outstanding swap is queued, we may complete several after an app has

[PATCH 05/12] DRI2SwapBuffers: Return SBC correctly, handle target_msc correctly

2010-03-22 Thread Jesse Barnes
Returns expected SBC after completion of swap to caller, as required by OML_sync_control spec, instead of the last_swap_target value. Passes target_msc, divisor, remainder, correctly for glXSwapBuffersMscOML() call, while retaining old behaviour for simple glXSwapBuffers() call. Signed-off-by:

[PATCH 07/12] DRI2: handle swap_interval of 0 correctly

2010-03-22 Thread Jesse Barnes
A 0 swap interval means that swaps shouldn't be sync'd to vblank, so just complete the swap immediately in that case. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- hw/xfree86/dri2/dri2.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/dri2/dri2.c

[PATCH 08/12] DRI2: handle target_msc of 0 case

2010-03-22 Thread Jesse Barnes
An OML swap can have a 0 target_msc, which just means it needs to satisfy the divisor/remainder equation. Pass this down to the driver as needed so we can support it. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- hw/xfree86/dri2/dri2.c |8 +--- 1 files changed, 1

[PATCH 09/12] DRI2: advertise lowest supported DRI2 protocol version

2010-03-22 Thread Jesse Barnes
Update our supported DRI2 protocol version as each driver does DRI2ScreenInit, since depending on available kernel features, each DDX may support different callbacks and therefore protocol. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- hw/xfree86/dri2/dri2.c | 12

Re: [PATCH 08/12] DRI2: handle target_msc of 0 case

2010-03-22 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jesse Barnes wrote: An OML swap can have a 0 target_msc, which just means it needs to satisfy the divisor/remainder equation. Pass this down to the driver as needed so we can support it. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org ---

Re: [PATCH 09/12] DRI2: advertise lowest supported DRI2 protocol version

2010-03-22 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jesse Barnes wrote: Update our supported DRI2 protocol version as each driver does DRI2ScreenInit, since depending on available kernel features, each DDX may support different callbacks and therefore protocol. Signed-off-by: Jesse Barnes

[PATCH 10/12] DRI2: throttle swaps at submission time too

2010-03-22 Thread Jesse Barnes
We need to throttle swaps here in addition to when the context is made current to avoid causing problems with clients that just swap. Throttling here also ensures our swaps get ordered as long as we block the client occasionally. Reported-by: Mario Kleiner mario.klei...@tuebingen.mpg.de

[PATCH 12/12] DRI2: prevent swap wakes from waking MSC waiters

2010-03-22 Thread Jesse Barnes
If a few swaps were queued leading to a throttle related block on the client, and then the client submitted an MSC wait, one of the previous swap wakeups could have caused the MSC wait to complete early. Add a flag for this to prevent a swap wake from prematurely waking an MSC waiter.

[PATCH 11/12] DRI2: handle swapsPending better

2010-03-22 Thread Jesse Barnes
Avoid a potential swapsPending underflow by incrementing it before ScheduleSwap, which may complete it immediately. And be sure to decrement it again in case the schedule failed. Reported-by: Mario Kleiner mario.klei...@tuebingen.mpg.de Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org ---

Re: [PATCH 08/12] DRI2: handle target_msc of 0 case

2010-03-22 Thread Jesse Barnes
On Mon, 22 Mar 2010 15:30:57 -0700 Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jesse Barnes wrote: An OML swap can have a 0 target_msc, which just means it needs to satisfy the divisor/remainder equation. Pass this down to the driver as needed

Re: [PATCH 09/12] DRI2: advertise lowest supported DRI2 protocol version

2010-03-22 Thread Jesse Barnes
On Mon, 22 Mar 2010 15:34:54 -0700 Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jesse Barnes wrote: Update our supported DRI2 protocol version as each driver does DRI2ScreenInit, since depending on available kernel features, each DDX may

Re: [RFC] Multitouch support, step one

2010-03-22 Thread Ping Cheng
On Mon, Mar 22, 2010 at 4:57 PM, Henrik Rydberg rydb...@euromail.se wrote: Ping Cheng wrote: 2010/3/20 Ping Cheng pingli...@gmail.com: I might have mistaken the definition of tracking ID here. After reading the Multi-touch (MT) Protocol again,  I think combining ABS_MT_TRACKING_ID with

[PATCH] xfree86: remove if 1 from the dawn of time.

2010-03-22 Thread Peter Hutterer
7+ years for an if 1 should be enough to just admit that there's no other option. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/os-support/shared/posix_tty.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git

Re: [PATCH] Use arc4random instead of rand where available

2010-03-22 Thread Jeremy Huddleston
I was thinking smaller would be more acceptable ... but I too would prefer something like OsRandom() in os/utils.c ... is that something that should be exported to drivers or just internal to the server? On Mar 22, 2010, at 13:51, Tiago Vignatti wrote: Jeremy Huddleston wrote: Mainly to

Re: [xserver patch v5 3/5] glx: Enforce a 1:1 correspondence between GLX and X11 windows.

2010-03-22 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Kristian Høgsberg wrote: 2010/3/22 Ian Romanick i...@freedesktop.org: Kristian Høgsberg wrote: 2010/2/8 Francisco Jerez curroje...@riseup.net: The spec says (regarding glXCreateWindow): If there is already a GLXFBConfig associated with win (as a

[PATCH] Fix x86emu builds when using non-gnu compilers

2010-03-22 Thread Alan Coopersmith
Before this fix, the u64 type would not be defined, causing x86emu/sys.c to fail to build: sys.c, line 102: syntax error before or at: ldq_u sys.c, line 102: syntax error before or at: * Since 64-bit types are now required by x86emu, assumes all platforms either have a 64-bit long or a 64-bit

Re: [PATCH] xfree86: remove if 1 from the dawn of time.

2010-03-22 Thread Corbin Simpson
On Mon, Mar 22, 2010 at 5:36 PM, Peter Hutterer peter.hutte...@who-t.net wrote: 7+ years for an if 1 should be enough to just admit that there's no other option. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---  hw/xfree86/os-support/shared/posix_tty.c |   10 --  1 files

Re: [PATCH] xfree86: remove if 1 from the dawn of time.

2010-03-22 Thread Fernando Carrijo
Peter Hutterer peter.hutte...@who-t.net wrote: 7+ years for an if 1 should be enough to just admit that there's no other option. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Fernando Carrijo fcarr...@yahoo.com.br ___

Re: [PATCH libxtrans] Clean up some 'unused variable' warnings

2010-03-22 Thread Jeff Smith
- Original Message From: Ian Romanick i...@freedesktop.org To: Jeff Smith whydo...@yahoo.com Cc: xorg-devel@lists.x.org Sent: Mon, March 22, 2010 4:38:08 PM Subject: Re: [PATCH libxtrans] Clean up some 'unused variable' warnings Specific comments below. Given the nature of the changes

[PATCH] xfree86: merge driver from the input class into the options.

2010-03-22 Thread Peter Hutterer
A driver that is assigned by an input class is only present as idev-driver. The driver itself has no access to this information once PreInit is called. For devices that rely on chain-hotplugging (wacom), this means that for the second device the driver information is lost and the second device

Re: [PATCH libxtrans] Clean up some 'unused variable' warnings

2010-03-22 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Smith wrote: From: Ian Romanick i...@freedesktop.org To: Jeff Smith whydo...@yahoo.com Cc: xorg-devel@lists.x.org Sent: Mon, March 22, 2010 4:38:08 PM Subject: Re: [PATCH libxtrans] Clean up some 'unused variable' warnings Specific