[PATCH v2] Print git describe output into the log file.

Run git describe on build and push the output into xorg-git-version.h. Then print that out in the logfile. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Changes to first version: - target is PHONY to always regenerate - script reshuffled, no == anymore - don't print anything if no

Re: [PATCH 1/5] xkb: Post PointerKeys through the XTEST device.

On Thu, Apr 15, 2010 at 01:21:31PM +1000, Daniel Stone wrote: On Wed, Apr 14, 2010 at 11:08:10AM +1000, Peter Hutterer wrote: Posting an event through a master device may cause pointer jumps once lastSlave == master, caused by double scaling. To avoid this, post the fake event generated by

[PATCH] xfree86: dga needs to the master keyboard state (#27573)

GetPairedDevice() may not always return the keyboard, resulting in a null-pointer derefernce when accessing the XKB state. X.Org Bug 27573 http://bugs.freedesktop.org/show_bug.cgi?id=27573 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/common/xf86DGA.c |2 +- 1 files

[PATCHv3 1/4] glx: Track GLX 1.3 style GLX drawables under their X drawable ID as well

This ensures that the DrawableGone callback gets called as necessary when the X drawable goes away. Otherwise, using a GLX drawable (say, glXSwapBuffers) in indirect mode after the X drawable has been destroyed will crash the server. Signed-off-by: Kristian Høgsberg k...@bitplanet.net

Re: [PATCH v2] Print git describe output into the log file.

On Thu, Apr 15, 2010 at 11:04 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Run git describe on build and push the output into xorg-git-version.h. Then print that out in the logfile. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Changes to first version: - target is PHONY

Re: Xv to pixmaps (was Xv Xdbe combination)

On 14-04-10 12:12, Michel Dänzer wrote: Generally speaking, find all the relevant places which assume the drawable is a window, and fix them up to handle pixmaps as well. Note that there may be some in the drivers as well. I am happy to do it and test it, but I am going to need some

Re: Xv to pixmaps (was Xv Xdbe combination)

On Fre, 2010-04-16 at 15:37 +0200, Matthew Fincham wrote: On 14-04-10 12:12, Michel Dänzer wrote: Generally speaking, find all the relevant places which assume the drawable is a window, and fix them up to handle pixmaps as well. Note that there may be some in the drivers as well.

[PATCH xserver] fix unreachable code

Hi, I was playing a bit with coverity tool and from our 400 outstanding bugs found I solved all unreachable code \o/ I haven't test _any_, but all seems pretty trivial to check. Please, take a look on them. Thanks, Tiago Vignatti (4): xfree86: fix not reached code in parser xfree86:

[PATCH] xfree86: fix not reached code in tty code

CLEARRTS_SUPPORT cannot be triggered at all. Both commit logs and google don't show any clear reference about it, so I'd vote to just delete. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/os-support/shared/posix_tty.c | 13 - 1 files changed, 0

[PATCH] xfree86: fix not reached code in parser

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/parser/read.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/parser/read.c b/hw/xfree86/parser/read.c index 1091be5..4e42b24 100644 --- a/hw/xfree86/parser/read.c +++

[PATCH] xfree86: fix not reached code in fi1236 driver from i2c

This issue was introduced in the first dump of the code in 2004. I haven't check what's the correct fix for it so I simply kept the behaviour of someone calling this and removed the unreachable code. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/i2c/fi1236.c |4

[PATCH] Xi: fix not reached code in XSendExtensionEvent

Error was introduced in 31a7994a. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Xi/sendexev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Xi/sendexev.c b/Xi/sendexev.c index 8629dd2..bd96d74 100644 --- a/Xi/sendexev.c +++ b/Xi/sendexev.c @@ -138,9

Re: Merged proto package

The merger would probably also be the ideal time to finally get around to moving *proto.pc to $(datadir)/pkgconfig as we've discussed a bunch but never followed through on. (See https://bugs.freedesktop.org/show_bug.cgi?id=27444 for instance.) -- -Alan Coopersmith-

[PATCH 0/3] GLX changes in support of XWin AIGLX

I have done a rewrite of the Xwin DDX AIGLX code to actually make it do something useful again, which requires a few changes to DIX GLX. The actual XWin DDX changes aren't in this patch-set because they are probably only of niche interest, and reasonably large. They are available at

[PATCH 1/3] Do not create visuals from fbConfigs which don't support window drawables.

It is implicit that visuals are suitable for use with a window. Glean (for e.g.) assumes all visuals support window drawables. glXChooseVisual() documentation also says: There is no direct filter for picking only visuals that support GLXPixmaps. GLXPixmaps are supported for visuals whose

[PATCH 2/3] Move GLX extension string utility functions into the GLX extension

This way other DDX which don't have DRI can use them I don't think this can generate ABI problems with the DRI1 loader, but what do I know... Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk --- glx/Makefile.am |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 3/3] Let configure --enable/disable-aiglx control building of AIGLX for all DDXs

Can't use --enable/disable-aiglx to control if Xwin DDX is built with AIGLX enabled, as at the moment it's forced off if we aren't building the X.Org DDX DRI loader Rearrange things a bit, introducing a new configure symbol, DRI1_AIGLX to specifically indicate if the X.Org DDX DRI loader should

Re: Merged proto package

On Fri, Apr 16, 2010 at 8:19 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: The merger would probably also be the ideal time to finally get around to moving *proto.pc to $(datadir)/pkgconfig as we've discussed a bunch but never followed through on.   (See

Re: [PATCH 4/5] xkb: purge unneeded includes from ddxDevBtn.c

On Wed, Apr 14, 2010 at 11:08:13AM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- xkb/ddxDevBtn.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/xkb/ddxDevBtn.c b/xkb/ddxDevBtn.c index b8a222d..b8a1255 100644 ---

Re: [PATCH:lndir 1/4] Move to xorg-macros 1.4 use INSTALL_CMD to generate INSTALL file

On Fri, Apr 16, 2010 at 1:29 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Dan Nicholson dbn.li...@gmail.com ___ xorg-devel@lists.x.org: X.Org development Archives:

[PATCH] exa: check for NULL pointer before dereferences it

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- exa/exa_classic.c |3 ++- exa/exa_driver.c |4 +++- exa/exa_mixed.c |3 ++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/exa/exa_classic.c b/exa/exa_classic.c index c31e2d4..e1ead6c 100644 ---

[PATCH xserver] fix check pointer dereferences before using them

Hi, Playing a bit more with coverity tool I found these pointer dereferences before them be actually checked. Probably mostly are harmless, but it's bad habit of codification. I just compiled and ran here, without checking properly if they are all working fine. Please, take a look on it.

[PATCH] Xi: check for NULL pointer before dereferences it in DeviceFocusEvent

Both mouse and mouse-button are already used before their checking were being performed. So check on the beginning. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Xi/exevents.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Xi/exevents.c b/Xi/exevents.c

[PATCH] xkb: check for NULL pointer before dereferences it in XkbWriteXKBSymbols

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- xkb/xkbout.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/xkb/xkbout.c b/xkb/xkbout.c index 68ede90..084d72b 100644 --- a/xkb/xkbout.c +++ b/xkb/xkbout.c @@ -353,9 +353,12 @@ XkbClientMapPtrmap;

[PATCH] xkb: check for NULL pointer before dereferences it in XkbAddClientResource

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- xkb/xkbEvents.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xkb/xkbEvents.c b/xkb/xkbEvents.c index 33741e9..c7f6a66 100644 --- a/xkb/xkbEvents.c +++ b/xkb/xkbEvents.c @@ -1042,8 +1042,8 @@ XkbInterestPtr

Re: [PATCH 5/5] xkb: rename XkbFakeDeviceButton and XkbFakeDeviceMotion, move into xkbActions.c

On Wed, Apr 14, 2010 at 11:08:14AM +1000, Peter Hutterer wrote: The name XkbDDXFakeDeviceButton and XkbDDXFakeDeviceMotion is somewhat misleading, there's no DDX involved in the game at all anymore. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- include/xkbsrv.h | 13 ---

Re: [PATCH] xfree86: check for NULL pointer before dereferences it in parser code

Tiago Vignatti wrote: Seems to be harmless. Meh. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/parser/scan.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/parser/scan.c b/hw/xfree86/parser/scan.c index

Re: [PATCH] xkb: check for NULL pointer before dereferences it in XkbAddClientResource

Tiago Vignatti wrote: Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- xkb/xkbEvents.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xkb/xkbEvents.c b/xkb/xkbEvents.c index 33741e9..c7f6a66 100644 --- a/xkb/xkbEvents.c +++ b/xkb/xkbEvents.c @@

Re: [PATCH] exa: check for NULL pointer before dereferences it

On Fre, 2010-04-16 at 18:42 +0300, Tiago Vignatti wrote: Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com [...] diff --git a/exa/exa_driver.c b/exa/exa_driver.c index dcf1a98..25254c9 100644 --- a/exa/exa_driver.c +++ b/exa/exa_driver.c @@ -134,6 +134,8 @@

Re: [PATCH] exa: don't need to check for NULL pointer if we already assumed it has a value

On Fre, 2010-04-16 at 18:42 +0300, Tiago Vignatti wrote: the alternative would be to check ps in the beginning of the function. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- exa/exa.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/exa/exa.c

Re: [PATCH v2] Print git describe output into the log file.

On 16/04/2010 11:21, Kristian Høgsberg wrote: On Fri, Apr 16, 2010 at 2:04 AM, Peter Hutterer + +xorg-git-version.h: + sh $(top_srcdir)/GIT-GENERATE-VERSION + +.PHONY: xorg-git-version.h Make it depend on .git/$(git symbolic-ref HEAD) instead of using phony? I think this needs to be

Re: [PATCH 2/3] Move GLX extension string utility functions into the GLX extension

On Fri, Apr 16, 2010 at 11:24 AM, Jon TURNEY jon.tur...@dronecode.org.uk wrote: This way other DDX which don't have DRI can use them I don't think this can generate ABI problems with the DRI1 loader, but what do I know... Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk This looks ok.

Re: [PATCH] xfree86: check for NULL pointer before dereferences it in parser code

On 16/04/10 18:17, Alan Coopersmith wrote: Tiago Vignatti wrote: Seems to be harmless. Meh. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/parser/scan.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/parser/scan.c

Re: [PATCH v2] Print git describe output into the log file.

On Fri, 2010-04-16 at 06:31 -0700, Dan Nicholson wrote: It might be nicer, but could get messy when you consider all the corner cases. True, and the mess can be contained in a macro. Reusing the design for ChangeLog is worth a shot. Not to mention the script brings a mess of it's own in the

Re: [PATCH v2] Print git describe output into the log file.

Gaetan Nadon wrote: On Fri, 2010-04-16 at 06:31 -0700, Dan Nicholson wrote: It might be nicer, but could get messy when you consider all the corner cases. True, and the mess can be contained in a macro. And putting it in a macro in xorg-macros may be worthwhile too, since I can imagine other

Re: [PATCH v2] Print git describe output into the log file.

On Fri, Apr 16, 2010 at 10:32 AM, Gaetan Nadon mems...@videotron.ca wrote: On Fri, 2010-04-16 at 06:31 -0700, Dan Nicholson wrote: It might be nicer, but could get messy when you consider all the corner cases. True, and the mess can be contained in a macro. Reusing the design for ChangeLog

Re: Merged proto package

On Fri, 2010-04-16 at 08:34 -0700, Dan Nicholson wrote: Although orthogonal to the merging, I think this is a good change. Furthermore, we already have modules installing .pc files to $datadir, so people will have to deal with this type of change anyway. It's just the right thing to do.

Re: [PATCH] xfree86: check for NULL pointer before dereferences it in parser code

On Fri, Apr 16, 2010 at 10:16 AM, Éric Piel e.a.b.p...@tudelft.nl wrote: On 16/04/10 18:17, Alan Coopersmith wrote: Tiago Vignatti wrote: Seems to be harmless. Meh. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com ---  hw/xfree86/parser/scan.c |    9 +++--  1 files changed, 7

Re: Merged proto package

Gaetan Nadon wrote: On Fri, 2010-04-16 at 08:34 -0700, Dan Nicholson wrote: Although orthogonal to the merging, I think this is a good change. Furthermore, we already have modules installing .pc files to $datadir, so people will have to deal with this type of change anyway. It's just the

Re: Merged proto package

On Fri, 2010-04-16 at 08:34 -0700, Dan Nicholson wrote: Do any of the proto packages install arch-specific headers? Certainly there are arch-dependent definitions in the headers, but they go in the same file with #ifdefs, right? If you look at build.sh. none of the libraries have platform

Re: [PATCH v2] Print git describe output into the log file.

On Fri, 2010-04-16 at 11:00 -0700, Dan Nicholson wrote: On Fri, Apr 16, 2010 at 10:32 AM, Gaetan Nadon mems...@videotron.ca wrote: On Fri, 2010-04-16 at 06:31 -0700, Dan Nicholson wrote: It might be nicer, but could get messy when you consider all the corner cases. True, and the mess

Re: Merged proto package

On Fri, Apr 16, 2010 at 11:18 AM, Gaetan Nadon mems...@videotron.ca wrote: On Fri, 2010-04-16 at 08:34 -0700, Dan Nicholson wrote: Do any of the proto packages install arch-specific headers? Certainly there are arch-dependent definitions in the headers, but they go in the same file with

[PATCH input-acecad] config: remove extension check for unused RANDR extension

The randr protocol is not used, no randr*.h are included. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index bbf7f0f..19d3c66 100644 --- a/configure.ac +++ b/configure.ac @@

[PATCH input-acecad] config: optional extension check for inputproto not required

The check should be in PKG_CHECK_MODULES permanently. The XORG_DRIVER_CHECK_EXT will add inputproto to PKG_CHECK_MODULES only if the extension is available. By definition, this extension is always available and the acecad driver cannot function without it. This is evidenced by the absence of

Re: [PATCH resent] configure: introduce --{enable, disable}-syscall-clock

On Fri, Apr 16, 2010 at 12:39 PM, Eric Anholt e...@anholt.net wrote: On Fri, 16 Apr 2010 15:10:19 +0300, Tiago Vignatti tiago.vigna...@nokia.com wrote: Some Linux systems might not want to link against rt and pthread libraries simply to implement monotonic clock (GetTimeInMillis). For those,

Cherry-picking an EXA patch for 1.7-nominations

Hi, Michel kindly explained the issue at hand in the Debian bug#576816 (http://bugs.debian.org/576816), and I tried cherry-picking 342f3689d17256c92cbfee079d24501d27aa1153 accordingly, on top of 1.7-branch. The conflicts are: ++ HEAD ++=== + /* During a fallback we must finish access,

[PATCH] exa: handle pixmap create/destroy in lower layers

- Pixmaps that are created during a fallback are automatically prepared access. - During the fallback accelerated ops are blocked to prevent new/scratch gc's from triggering accelerated ops on mapped pixmaps. - A few cases of incorrect wrapping (on the top level pointer instead of between