Re: [PATCH xserver 2/2] glamor: Always purge the FBO cache in BlockHandler

2017-03-15 Thread Max Staudt
On 03/06/2017 07:02 PM, Eric Anholt wrote: > For re-adding an FBO cache, I would need to see that we have > APPLE_object_purgeable used so that the FBO cache can be evicted, [...] When I checked a few months ago, only the i915 Mesa and kernel drivers implemented this. Maybe we can enable the FBO

Re: [PATCH xserver] glamor: Fix dashed line rendering.

2017-03-15 Thread Keith Packard
Eric Anholt writes: > We were binding the screen pixmap as the dash and sampling its alpha, > which is usually just 1.0 (no dashing at all). > > Please cherry-pick this to active stable branches. > > Signed-off-by: Eric Anholt Thank you for finding this!

Re: [PATCH xserver] sdksyms: Tighten up the symbols we add to the magic table

2017-03-15 Thread Emil Velikov
On 13 March 2017 at 17:07, Adam Jackson wrote: > On Fri, 2017-03-10 at 23:23 +, Emil Velikov wrote: >> > On 10 March 2017 at 16:32, Adam Jackson wrote: >> > I neither expect nor want this to happen. dummy might have some minor >> > utility, but the nested driver

Re: [PATCH xserver] glamor: Paint first and last pixel of lines

2017-03-15 Thread Eric Anholt
Keith Packard writes: > [ Unknown signature status ] > Adam Jackson writes: > >> Is there some reason you believe GL's rasterisation rules for lines >> match fb's zero-width lines? Section 14.5.1 of the 4.5 spec looks quite >> a bit looser than fb to me. > > I

[PATCH xserver] glamor: Fix dashed line rendering.

2017-03-15 Thread Eric Anholt
We were binding the screen pixmap as the dash and sampling its alpha, which is usually just 1.0 (no dashing at all). Please cherry-pick this to active stable branches. Signed-off-by: Eric Anholt --- glamor/glamor_dash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH xdriinfo] Fix xdriinfo not working with glvnd

2017-03-15 Thread Eric Anholt
Hans de Goede writes: > For glx calls to work on libglvnd as glx provider we must first call > glXGetClientString. This also means that we can no longer take the > shortcut to not open the Display when a driver name is past to options. This seems sensible. Hopefully

Re: [PATCH xf86-input-libinput] Support for rel+abs composite devices on the same node

2017-03-15 Thread Peter Hutterer
On Sat, Mar 11, 2017 at 12:26:38PM +0100, Gergely Nagy wrote: > Largely based on work by Peter Hutterer, this patch makes composite relative + > absolute devices work with the driver. Such devices are anything that presents > itself as both a mouse, and - for example - a touch screen, like the >

Re: [PATCH xserver] glamor: Fix dashed line rendering.

2017-03-15 Thread Michel Dänzer
On 16/03/17 10:24 AM, Eric Anholt wrote: > We were binding the screen pixmap as the dash and sampling its alpha, > which is usually just 1.0 (no dashing at all). > > Please cherry-pick this to active stable branches. > > Signed-off-by: Eric Anholt > --- > glamor/glamor_dash.c

Re: xwayland pull request for 1.19 branch

2017-03-15 Thread Adam Jackson
On Mon, 2017-03-13 at 06:06 -0400, Olivier Fourdan wrote: > Hi, > > I have cherry-picked a couple of fixes for Xwayland for the > server-1.19-branch. > > _Important_: I squashed two commits from upstream for 1.19, namely: > >   64ca14b xwayland: make sure client is not gone in sync callback >  

Re: [PATCH xserver 1/4] xfree86: Remove 24bpp pixmap format support (v2)

2017-03-15 Thread Eric Anholt
Adam Jackson writes: > There's really no reason to pretend to support this, apps hate it, all > we're doing is giving people a way to injure themselves. It doesn't work > anyway with any Radeon, any NVIDIA chip, or any Intel chip since i810. > Rip out all the logic for handling

Re: [PATCH xserver] xinerama: Implement graphics exposures for window->pixmap copies (v4)

2017-03-15 Thread Adam Jackson
On Wed, 2016-11-02 at 12:49 -0400, Adam Jackson wrote: > This code is using GetImage to accumulate a logical view of the window > image (since the windows will be clipped to their containing screen), > and then PutImage to load that back into the pixmap.  What it wasn't > doing was constructing a

Re: [PATCH xserver 0/2] Check initial screen resources creations in Xephyr

2017-03-15 Thread Adam Jackson
On Wed, 2017-03-15 at 10:23 +0900, Michel Dänzer wrote: > On 14/03/17 11:22 PM, Olivier Fourdan wrote: > > On startup, Xephyr does not check for the successful creation of its > > screen pixmap, and would crash if it fails. > > > > The following patches aim at exiting cleanly instead of

Re: [PATCH RFC xserver 0/2] glamor pixmap FBO array can be NULL

2017-03-15 Thread Adam Jackson
On Tue, 2017-03-14 at 14:58 +0100, Olivier Fourdan wrote: > There are some cases where we don't have a fallback code path, in which > case we'll avoid the crash in glamor_set_destination_drawable() but won't > render properly, but this is a rare occurence and not rendering properly > is still

Re: [PATCH RFC xserver 0/2] glamor pixmap FBO array can be NULL

2017-03-15 Thread Adam Jackson
On Wed, 2017-03-15 at 15:55 -0400, Adam Jackson wrote: > On Tue, 2017-03-14 at 14:58 +0100, Olivier Fourdan wrote: > > > There are some cases where we don't have a fallback code path, in which > > case we'll avoid the crash in glamor_set_destination_drawable() but won't > > render properly, but