Re: [PATCH libICE v2] Use getentropy() if arc4random_buf() is not available

2017-04-05 Thread Mark Kettenis
> From: Benjamin Tissoires > Date: Tue, 4 Apr 2017 19:12:53 +0200 > > This allows to fix CVE-2017-2626 on Linux platforms without pulling in > libbsd. > The libc getentropy() is available since glibc 2.25 but also on OpenBSD. > For Linux, we need at least a v3.17

Re: [PATCH v2 xserver 0/7] Minor build system corrections

2017-04-05 Thread Mihail Konev
On Wed, Apr 05, 2017 at 04:49:39AM +0500, Mihail Konev wrote: > v2 (Emil Velikov): > 2/7: Figure out what exactly happens. > 3/7: Add missing ifdef. > 5/7: Move DESTDIR to configure. >Add missing Cc. > 1-5/7: Reword. > > The 7/7 has also been suggested to use "ln -s". > Kept

Re: [PATCH v2 xserver 6/7] os-support/solaris: add asm to gitignore

2017-04-05 Thread Alan Coopersmith
On 04/ 4/17 04:49 PM, Mihail Konev wrote: Signed-off-by: Mihail Konev --- hw/xfree86/os-support/solaris/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 hw/xfree86/os-support/solaris/.gitignore diff --git a/hw/xfree86/os-support/solaris/.gitignore

Re: [PATCH xserver] xf86_crtc_supports_gamma: Return FALSE if RandR is disabled

2017-04-05 Thread Alex Deucher
On Wed, Apr 5, 2017 at 11:23 PM, Michel Dänzer wrote: > From: Michel Dänzer > > E.g. becuase Xinerama is enabled. > > Fixes crash on server startup when RandR is disabled and all other > conditions in xf86_crtc_supports_gamma are satisfied. > >

[PATCH xserver] xf86_crtc_supports_gamma: Return FALSE if RandR is disabled

2017-04-05 Thread Michel Dänzer
From: Michel Dänzer E.g. becuase Xinerama is enabled. Fixes crash on server startup when RandR is disabled and all other conditions in xf86_crtc_supports_gamma are satisfied. Bugzilla: https://bugs.freedesktop.org/100293 Signed-off-by: Michel Dänzer

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-04-05 Thread Daniel Vetter
On Sun, Apr 02, 2017 at 12:58:33PM -0700, Keith Packard wrote: > Daniel Vetter writes: > > > On that, I think we could just unconditionally hand leases all encoders. > > Encoders turned out to be a bit an uapi mistake. > > Well, given the complexity of hardware these days, even

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-04-05 Thread Daniel Vetter
On Sat, Apr 01, 2017 at 03:58:58PM -0700, "Keith Packard" wrote: > > As a part of the DRM leasing work, we need a way to have the X server > create a lease and pass it back to an X client. Here's a proposal for > the RandR specification changes necessary for that. The basic plan is > pretty

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-04-05 Thread Daniel Vetter
On Tue, Apr 04, 2017 at 08:53:45AM -0700, Keith Packard wrote: > Daniel Vetter writes: > > > The multi-seat thing sounds like vapourware, I think we should care about > > the vr use-case for now, and only that one. > > Ok, I can live with that, even if I like the idea of a

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-04-05 Thread Daniel Vetter
On Mon, Apr 03, 2017 at 09:41:34AM -0700, Keith Packard wrote: > Daniel Vetter writes: > > > Hm, if you restrict getresources and getplanes, you'll get your leased > > objects query api. Iirc that part was missing in your kernel patch. And it > > gives you exaclty what you want:

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

2017-04-05 Thread Quentin Glidic
On 4/3/17 3:47 PM, Olivier Fourdan wrote: Hi Quentin, I think it may be worth it to add a little safety net: “Compositors are required to restrict this interface to Xwayland alone, and raise a protocol error for native Wayland clients.” Yes, agreed, good point! But do we really need to kill

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

2017-04-05 Thread Quentin Glidic
On 4/2/17 2:57 AM, Peter Hutterer wrote: woohoo, grabs. My favourite topic! ;) On Wed, Mar 22, 2017 at 05:27:22PM +0100, Olivier Fourdan wrote: >> [snip] + + This protocol specifies a way for Xwayland to request all keyboard + events to be forwarded to a surface even when the

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

2017-04-05 Thread Bill Spitzak
I cannot see why this api cannot be correctly emulated using some wayland api that normal wayland clients can also use. Allowing X clients to have more rights and abilities than Wayland clients seems horrendously wrong. The X emulation does not have to do 1:1 translation of X11 calls into Wayland

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

2017-04-05 Thread Bill Spitzak
On Tue, Apr 4, 2017 at 3:11 AM, Olivier Fourdan wrote: > > Hi > >> I cannot see why this api cannot be correctly emulated using some >> wayland api that normal wayland clients can also use. Allowing X >> clients to have more rights and abilities than Wayland clients seems >>

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-05 Thread Daniel Vetter
On Mon, Apr 3, 2017 at 8:25 AM, Manasi Navare wrote: >> So in that case you do need userspace to re-request the same mode at the >> same bpp? > > So yes because when userspace requests the same mode at same bpp, > kernel will still call intel_dp->mod_valid which

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-04-05 Thread Daniel Vetter
On Mon, Apr 03, 2017 at 03:50:33PM -0700, Keith Packard wrote: > Daniel Vetter writes: > > > Also if this confuses VR, then another reason why we want to make leases > > invariant and only allow pure revoke, not changing the list. > > I'm not sure why you want this to be

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-05 Thread Daniel Vetter
On Fri, Mar 31, 2017 at 05:22:09PM -0700, Eric Anholt wrote: > Manasi Navare writes: > > > On Fri, Mar 31, 2017 at 01:08:41PM -0700, Eric Anholt wrote: > >> Manasi Navare writes: > >> > >> > On Thu, Mar 30, 2017 at 05:37:55PM -0700, Eric

Re: [RFC] Visual Class for On-Screen HDR Drawables

2017-04-05 Thread Adam Jackson
On Tue, 2017-02-28 at 19:23 -0800, Alex Goins wrote: > > FYI - it's only the texture_from_pixmap texture target attributes that they > base > off of the root window, e.g. GLX_TEXTURE_2D_EXT, GLX_TEXTURE_RECTANGLE_EXT, > GLX_TEXTURE_FORMAT_RBGA_EXT. They get the fbconfig from the X pixmap's

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-05 Thread Manasi Navare
On Mon, Apr 03, 2017 at 09:19:35AM +0200, Daniel Vetter wrote: > On Mon, Apr 3, 2017 at 8:25 AM, Manasi Navare > wrote: > >> So in that case you do need userspace to re-request the same mode at the > >> same bpp? > > > > So yes because when userspace requests the same

[PATCH 1/2 v3] Introduce keyboard grabbing protocol for Xwayland

2017-04-05 Thread Olivier Fourdan
This patch introduces a new protocol for grabbing the keyboard from Xwayland. This is needed for X11 applications that map an override redirect window (thus not focused by the window manager) and issue an active grab on the keyboard to capture all keyboard events. Signed-off-by: Olivier Fourdan

[PATCH 2/2 v3] Add keyboard shortcuts inhibitor

2017-04-05 Thread Olivier Fourdan
This adds a new protocol to let Wayland clients specify that they want all keyboard events to be send to the client, regardless of the compositor own shortcuts. This is for use by virtual machine and remote connections viewers. Signed-off-by: Olivier Fourdan --- v2:

Re: [PATCH libXdmcp v2] Use getentropy() if arc4random_buf() is not available

2017-04-05 Thread Mark Kettenis
> From: Benjamin Tissoires > Date: Tue, 4 Apr 2017 19:13:38 +0200 > > This allows to fix CVE-2017-2625 on Linux platforms without pulling in > libbsd. > The libc getentropy() is available since glibc 2.25 but also on OpenBSD. > For Linux, we need at least a v3.17

[PATCH v2a xserver] sdksyms: fix typo in export keyword index

2017-04-05 Thread Mihail Konev
In headers, the symbols exported from Xorg are declared as "extern _X_EXPORT type name [...]". In 3dad57b1 ("sdksyms: Tighten up the symbols we add to the magic table"), a check has been inserted that ensures the word at the index matches the _X_EXPORT expansion. With GCC 5, the "skip line

Re: [PATCH v2a xserver] sdksyms: fix typo in export keyword index

2017-04-05 Thread Mihail Konev
On Thu, Apr 06, 2017 at 05:14:22AM +0500, Mihail Konev wrote: > > v2a: Fix GCC 4 paragraph: "when extern and type are on the same line" -> > "expansion is put on a single line". > v2 was the correct one, sorry. Wrongly assumed there are no declarations on a single line, yet "I saw the