Re: Request for feedback for my GSoC project to improve Present support in Xwayland

2017-07-25 Thread Michel Dänzer
On 24/07/17 11:07 AM, Roman Gilg wrote:> > I'm writing this mail in order to get some feedback from the X.Org > community regarding my current approach and the progress I've made so > far. You can find my main working branch at > https://github.com/subdiff/xserver/tree/presentInXwayland > > I've

Re: [Mesa-dev] [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-25 Thread Nicolai Hähnle
On 22.07.2017 14:00, Daniel Stone wrote: On 21 July 2017 at 18:32, Michel Dänzer wrote: On 20/07/17 01:08 PM, Daniel Stone wrote: DRI3 version 1.1 adds support for explicit format modifiers, including multi-planar buffers. Adding mesa-dev, Nicolai and Marek. We just ran

[PATCH xserver 2/2] glamor: Avoid overflow between box32 and box16 box

2017-07-25 Thread Olivier Fourdan
glamor_compute_transform_clipped_regions() uses a temporary box32 internally which is copied back to a box16 to init the regions16, thus causing a potential overflow. If an overflow occurs, the given region is invalid and the pixmap init region will fail. Simply check that the coordinates won't

[PATCH xserver 0/2] glamor: avoid overflow and crash with largepixmap

2017-07-25 Thread Olivier Fourdan
Hi all, There are a few (rare) occurence of a crash in glamor with largepixmap(), and I traced it back to an overflow in glamor_compute_transform_clipped_regions() when copying the box32 back into a box16. The following two (trivial) patches do two things: 1. Make sure the values do not

Re: [RFC dri3proto 01/16] Add modifier/multi-plane requests, bump to v1.1

2017-07-25 Thread Daniel Stone
On 25 July 2017 at 21:43, Eric Anholt wrote: > Daniel Stone writes: >> Mm, we did have that originally, but anyone including XSync headers >> very helpfully gets #define CARD64 XSyncValue, which blows up into int >> + unsigned int. [...] >> >> I'd

Re: [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-25 Thread Eric Anholt
Daniel Stone writes: > DRI3 version 1.1 adds support for explicit format modifiers, including > multi-planar buffers. I still want proper 64-bit values, and I don't think the little XSync mess will be much of a blocker. > Signed-off-by: Daniel Stone

Re: [RFC dri3proto 01/16] Add modifier/multi-plane requests, bump to v1.1

2017-07-25 Thread Eric Anholt
Daniel Stone writes: > On 17 June 2017 at 02:21, Eric Anholt wrote: >> With the Present extension, we started putting CARD64s on the wire. >> Let's use them here, too. > > Mm, we did have that originally, but anyone including XSync headers > very helpfully

[PATCH xserver 1/2] glamor: handle NULL source pixmap

2017-07-25 Thread Olivier Fourdan
COMPOSITE_REGION() can pass NULL as a source pixmap, make sure we handle that nicely in glamor_composite_clipped_region(). Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=101894 Signed-off-by: Olivier Fourdan --- glamor/glamor_render.c | 2 +- 1 file changed, 1

Re: [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-25 Thread Michel Dänzer
On 26/07/17 06:20 AM, Eric Anholt wrote: > Daniel Stone writes: > >> DRI3 version 1.1 adds support for explicit format modifiers, including >> multi-planar buffers. > > I still want proper 64-bit values, and I don't think the little XSync > mess will be much of a blocker.