Re: [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-28 Thread Daniel Stone
Hi, Sorry, I've been sick the past couple of days - exactly when this thread exploded ... On 25 July 2017 at 22:20, Eric Anholt wrote: > Daniel Stone writes: >> DRI3 version 1.1 adds support for explicit format modifiers, including >> multi-planar buffers. > > I still want proper 64-bit values,

Re: [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-28 Thread Daniel Stone
Hi Michel, On 26 July 2017 at 07:21, Michel Dänzer wrote: > On 26/07/17 10:48 AM, Michel Dänzer wrote: >> On 26/07/17 06:20 AM, Eric Anholt wrote: >>> Daniel Stone writes: + The exact configuration of the buffer is specified by 'format', + a DRM FourCC format token as defined in th

Re: [PATCH xserver] composite: Make compIsAlternateVisual safe even if Composite is off

2017-07-28 Thread walter harms
Am 27.07.2017 22:02, schrieb Adam Jackson: > As of ea483af9 we're calling this unconditionally from the GLX code so > the synthetic visual is in a lower select group. If Composite has been > disabled then GetCompScreen() will return NULL, and this would crash. > > Rather than force the caller to

Re: [Mesa-dev] [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-28 Thread Daniel Stone
Hi Nicolai, Trying to tackle the stride subthread in one go ... On 25 July 2017 at 09:28, Nicolai Hähnle wrote: > On 22.07.2017 14:00, Daniel Stone wrote: >> On 21 July 2017 at 18:32, Michel Dänzer wrote: >>> We just ran into an issue which might mean that there's still something >>> missing in

Re: [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-28 Thread Daniel Stone
Hi, On 28 July 2017 at 01:11, Keith Packard wrote: > Eric Anholt writes: >> I think one option would be to have this extension create pixmaps with a >> depth equal to the highest populated bit of the fourcc plus one. Sure, >> it's weird that rgbx and xrgb888 have a different depth, but "dep

Re: [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-28 Thread Michel Dänzer
On 28/07/17 05:03 PM, Daniel Stone wrote: > On 28 July 2017 at 01:11, Keith Packard wrote: >> Eric Anholt writes: >>> I think one option would be to have this extension create pixmaps with a >>> depth equal to the highest populated bit of the fourcc plus one. Sure, >>> it's weird that rgbx a

Re: [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-28 Thread Michel Dänzer
On 28/07/17 04:14 PM, Daniel Stone wrote: > On 26 July 2017 at 07:21, Michel Dänzer wrote: >> On 26/07/17 10:48 AM, Michel Dänzer wrote: >>> On 26/07/17 06:20 AM, Eric Anholt wrote: Daniel Stone writes: > + The exact configuration of the buffer is specified by 'format', > + a DRM

Re: [Mesa-dev] [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-28 Thread Nicolai Hähnle
On 28.07.2017 09:44, Daniel Stone wrote: Hi Nicolai, Trying to tackle the stride subthread in one go ... On 25 July 2017 at 09:28, Nicolai Hähnle wrote: On 22.07.2017 14:00, Daniel Stone wrote: On 21 July 2017 at 18:32, Michel Dänzer wrote: We just ran into an issue which might mean that th

Re: [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-28 Thread Daniel Stone
Hi, On 28 July 2017 at 09:54, Michel Dänzer wrote: > On 28/07/17 05:03 PM, Daniel Stone wrote: >> By implementation if not spec, DRI3 v1.0 enforces that depth 16 is >> RGB565, depth 24 is XRGB, and depth 32 is ARGB. > > No, it doesn't. How the bits stored in a pixmap are interpreted is >

Re: [Mesa-dev] [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-28 Thread Daniel Stone
Hi, On 28 July 2017 at 10:24, Nicolai Hähnle wrote: > On 28.07.2017 09:44, Daniel Stone wrote: >> No, I don't think it is. Tiled layouts still have a stride: if you >> look at i915 X/Y/Yf/Y_CCS/Yf_CCS (the latter two containing an >> auxiliary compression/fast-clear buffer), iMX/etnaviv >> tiled/

Re: [Mesa-dev] [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-28 Thread Nicolai Hähnle
Hi Daniel, On 28.07.2017 12:46, Daniel Stone wrote: On 28 July 2017 at 10:24, Nicolai Hähnle wrote: On 28.07.2017 09:44, Daniel Stone wrote: No, I don't think it is. Tiled layouts still have a stride: if you look at i915 X/Y/Yf/Y_CCS/Yf_CCS (the latter two containing an auxiliary compression/

Re: [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-28 Thread Keith Packard
Daniel Stone writes: > You're right that it makes little to no sense to mix the two, but I'm > not sure what practical gain we get from expressing things as > Pictures. Well, abstractly, a Picture can represent any of the formats you've talked about -- they have explicit knowledge of color and t

Re: [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

2017-07-28 Thread Keith Packard
Michel Dänzer writes: > Declaring where? Once a pixmap is created, it only has a depth, no > format, so there's nothing to base on that e.g. CopyArea between two > pixmaps of the same depth is undefined. I think we'd need some extension request which provides the format data and other attributes

Re: [PATCH xserver] glx: Allow arbitrary context attributes for direct contexts

2017-07-28 Thread Eric Anholt
Adam Jackson writes: > For direct contexts, most context attributes don't require any > particular awareness on the part of the server. Examples include > GLX_ARB_create_context_no_error and GLX_ARB_context_flush_control, where > all of the behavior change lives in the renderer; since that's on t

Re: [PATCH xserver] glx: Allow arbitrary context attributes for direct contexts

2017-07-28 Thread Adam Jackson
On Fri, 2017-07-28 at 09:56 -0700, Eric Anholt wrote: > Adam Jackson writes: > > > For direct contexts, most context attributes don't require any > > particular awareness on the part of the server. Examples include > > GLX_ARB_create_context_no_error and GLX_ARB_context_flush_control, where > > a

Re: [PATCH xserver] glx: Allow arbitrary context attributes for direct contexts

2017-07-28 Thread Eric Anholt
Adam Jackson writes: > On Fri, 2017-07-28 at 09:56 -0700, Eric Anholt wrote: >> Adam Jackson writes: >> >> > For direct contexts, most context attributes don't require any >> > particular awareness on the part of the server. Examples include >> > GLX_ARB_create_context_no_error and GLX_ARB_cont