Re: [PATCH] xwayland: Avoid repeatedly looping through window ancestor chain

I've just sent another version with different naming and the additional function for comparing the private field's xwl_window with its creator as reply to your mail. Take a look how you like it. One other difference: I realized that the xwl_window_find(..) function is unneeded, since when putting

Re: [PATCH xserver v2 7/7] xwin: automake: remove unused {SRCS, DEFS}_{NATIVEGDI, PRIMARYFB}

On Tue, 2017-08-22 at 11:48 +0100, Emil Velikov wrote: > Left over from the following commits: > > 8465ee788fd xwin: Remove native GDI engine (v2) > c79f824bf66 xwin: Remove primary DirectDraw engine > > v2: drop leading - in the makefile > > Cc: Adam Jackson > Signed-off-by:

[PATCH xserver] glx: Fix error generation for non-reply vendor private requests

Discarding the return value here is just wrong. Signed-off-by: Adam Jackson --- glx/glxcmds.c | 3 +-- glx/glxcmdsswap.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 6a763970da..241abc6a58 100644 ---

Re: [PATCH] modesetting: Add common 16by9 and 16by10 resolutions to mode list

On Tue, 2017-08-22 at 13:20 -0500, Michael Cronenworth wrote: > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1339930 Nak, at least in this form. If these are really common modes then the DMT spec or similar should define real timings for them, and we should use those timings rather than

[PATCH] modesetting: Add common 16by9 and 16by10 resolutions to mode list

Related: https://bugzilla.redhat.com/show_bug.cgi?id=1339930 Signed-off-by: Michael Cronenworth --- hw/xfree86/drivers/modesetting/drmmode_display.c | 78 +++- 1 file changed, 76 insertions(+), 2 deletions(-) diff --git

Re: [PATCH xserver] glx: Fix error generation for non-reply vendor private requests

On Tue, Aug 22, 2017 at 12:19 PM, Adam Jackson wrote: > Discarding the return value here is just wrong. > > Signed-off-by: Adam Jackson Reviewed-by: Alex Deucher > --- > glx/glxcmds.c | 3 +-- > glx/glxcmdsswap.c | 3 +-- > 2

Re: [PATCH] modesetting: Add common 16by9 and 16by10 resolutions to mode list

On 08/22/2017 02:28 PM, Adam Jackson wrote: On Tue, 2017-08-22 at 13:20 -0500, Michael Cronenworth wrote: Related:https://bugzilla.redhat.com/show_bug.cgi?id=1339930 Nak, at least in this form. If these are really common modes then the DMT spec or similar should define real timings for them,

[PATCH xserver v2 4/7] xwin: remove always true/set XWIN_CLIPBOARD conditional/define

v2: drop trailing endif (Jon) Signed-off-by: Emil Velikov Reviewed-by: Jon Turney --- configure.ac | 1 - hw/xwin/InitInput.c | 4 hw/xwin/InitOutput.c | 11 --- hw/xwin/Makefile.am | 5 +

[PATCH xserver v2 6/7] xwin: remove always true/set XWIN_RANDR conditional/define

Signed-off-by: Emil Velikov Reviewed-by: Jon Turney --- configure.ac| 1 - hw/xwin/Makefile.am | 6 +- hw/xwin/meson.build | 2 -- 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index

[PATCH xserver v2 5/7] xwin: remove always true/set XWIN_MULTIWINDOW conditional/define

v2: drop trailing endif (Jon) Signed-off-by: Emil Velikov Reviewed-by: Jon Turney --- configure.ac | 1 - hw/xwin/InitOutput.c | 6 -- hw/xwin/Makefile.am | 4 hw/xwin/glx/Makefile.am |

[PATCH xserver v2 1/7] xwin/glx: remove unused __GLXWinScreen::glx_enable_bits

All the relevant code already uses the ::base::glx_enable_bits one. Signed-off-by: Emil Velikov Reviewed-by: Jon Turney --- hw/xwin/glx/indirect.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/xwin/glx/indirect.h

[PATCH xserver v2 3/7] os: make MitGenerateCookie() independent of XCSECURITY

Analogous to previous commit. Signed-off-by: Emil Velikov Reviewed-by: Jon Turney --- hw/xwin/winauth.c | 26 -- os/mitauth.c | 4 2 files changed, 30 deletions(-) diff --git a/hw/xwin/winauth.c

[PATCH xserver v2 2/7] os: make GenerateRandomData() independent of XCSECURITY

The function itself does not depend on the macro. Move it outside of the ifdef guard and remove the identical copy in XWIN. This is step 1 towards removing the duplication in winauth.c and moving the OS specifics to os/ Signed-off-by: Emil Velikov Reviewed-by: Jon

Re: [PATCH xserver 0/7] xwin: misc small fixes

On 14 August 2017 at 18:15, Jon Turney wrote: > On 03/08/2017 20:15, Emil Velikov wrote: >> >> Hi all, >> >> Here's a few small cleanups that I had lying around for months. >> Patches are dead trivial, although completely untested. >> >> Please review, > > > Thanks

[PATCH xserver v2 7/7] xwin: automake: remove unused {SRCS, DEFS}_{NATIVEGDI, PRIMARYFB}

Left over from the following commits: 8465ee788fd xwin: Remove native GDI engine (v2) c79f824bf66 xwin: Remove primary DirectDraw engine v2: drop leading - in the makefile Cc: Adam Jackson Signed-off-by: Emil Velikov Reviewed-by: Jon Turney

[PATCH] xwayland: Avoid repeatedly looping through window ancestor chain

Calling xwl_window_from_window means looping through the window ancestor chain whenever it is called on a child window or on an automatically redirected window. Since these properties and the potential ancestor's xwl_window are constant between window realization and unrealization, we can omit