[PATCH xserver] xfree86: Remove broken RANDR disabling logic (v4)

2018-01-24 Thread Adam Jackson
The only way to get at xf86Info.disableRandR from configuration is Option "RANDR" "foo" in ServerFlags, which probably nobody is using seeing as it's not documented. The other way it could be set is if a screen supports RANDR 1.2, in which case we set it to avoid trying to use the RANDR 1.1 compat

Re: [PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)

2018-01-24 Thread Adam Jackson
On Wed, 2018-01-24 at 10:54 +1100, Keith Packard wrote: > Adam Jackson writes: > > For the actual 1.6 enablement I've been using this for a merged > > protocol repo: > > > > https://cgit.freedesktop.org/~ajax/xorgproto > > That's awesome. It sounds like we should do a release of

Re: [PATCH xserver] modesetting: setup colormap

2018-01-24 Thread Adam Jackson
On Wed, 2017-11-15 at 19:36 +0300, Rinat Ibragimov wrote: > Ping. Just found this in the backlog. Merged, thanks: remote: I: patch #184223 updated using rev ac138f9b31b0fba00742edbc3326afe66e28099a. remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver

Re: [PATCH xserver] composite: Propagate damagedDescendants when reparented

2018-01-24 Thread Adam Jackson
On Thu, 2017-12-14 at 12:21 -0500, Peter Harris wrote: > If a window that is fully covered by an automatic-redirected descendant > (even implicitly, eg. via BackingStores) is reparented, the automatic > updates could be broken if the new parent is not marked as having > damaged descendants. > >

Re: [PATCH] os/inputthread: Force unlock when stopping thread.

2018-01-24 Thread Adam Jackson
On Mon, 2017-11-27 at 09:59 +0100, m...@suse.com wrote: > From: Michal Srb > > The inputthread is kept locked all the time while X server's VT is not active. > If the X server is terminated while not active, it will be stuck forever in > InputThreadFini waiting for the thread to

Re: [PATCH xserver] xwayland: avoid a crash with empty window pixmaps

2018-01-24 Thread Olivier Fourdan
On Wed, Jan 24, 2018 at 5:17 PM, Adam Jackson wrote: > On Wed, 2018-01-24 at 11:36 +0100, Olivier Fourdan wrote: > > > So basically, just remove the “if > > (RegionNotEmpty(DamageRegion(xwl_window->damage)))” would suffice? > > Worth a try anyway. I'm still just guessing at the

[PATCH xserver] xwayland: remove dirty window unconditionally on unrealize

2018-01-24 Thread Olivier Fourdan
This is a rare occurrence of a crash in Xwayland for which I don't have the reproducing steps, just a core file. The backtrace looks as follow: #0 raise () from /usr/lib64/libc.so.6 #1 abort () from /usr/lib64/libc.so.6 #2 OsAbort () at utils.c:1361 #3 AbortServer () at log.c:877

Re: [PATCH v3 xserver 1/2] xwayland: Add optional xdg-output support

2018-01-24 Thread Adam Jackson
On Wed, 2018-01-24 at 11:31 +0100, Olivier Fourdan wrote: > Small bump, would need to land this patch for 1.20 so we can continue > with fixing mutter once this is available in an Xwayland release :) Thanks for the poke. This didn't quite build with meson, needed to generate the new client

Re: [PATCH xserver] xwayland: avoid a crash with empty window pixmaps

2018-01-24 Thread Daniel Stone
Hi, On 24 January 2018 at 16:17, Adam Jackson wrote: > On Wed, 2018-01-24 at 11:36 +0100, Olivier Fourdan wrote: >> So basically, just remove the “if >> (RegionNotEmpty(DamageRegion(xwl_window->damage)))” would suffice? > > Worth a try anyway. I'm still just guessing at the root

Re: [PATCH v3 xserver 1/2] xwayland: Add optional xdg-output support

2018-01-24 Thread Olivier Fourdan
Hi, On Mon, Dec 18, 2017 at 8:52 AM, Olivier Fourdan wrote: > Hi, > > xdg-support has now been added to mutter (in git master), can we consider > this patch (only this one for now) which adds xdg-output support to > Xwayland? > > Because of the difference between

Re: [PATCH xserver] xwayland: avoid a crash with empty window pixmaps

2018-01-24 Thread Olivier Fourdan
Hi Adam, On Tue, Jan 23, 2018 at 6:41 PM, Adam Jackson wrote: > > Map / draw / unmap without hitting BlockHandler? I think > xwl_unrealize_window() might be broken for that case: > > /* ... */ > wl_surface_destroy(xwl_window->surface); > if

[PATCH xserver] xf86XvMCScreenInit: Clear pScreenPriv->dixinfo when freeing pAdapt

2018-01-24 Thread Michel Dänzer
From: Michel Dänzer Fixes double-free later in xf86XvMCCloseScreen, which would generally cause fireworks. Signed-off-by: Michel Dänzer --- hw/xfree86/common/xf86xvmc.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH xf86-input-evdev] Print cause of a failed open(..) call

2018-01-24 Thread Christian Gmeiner
This is quite helpful for debugging. Signed-off-by: Christian Gmeiner --- src/evdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index cffed7f..84d50c8 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -2453,7

Re: [PATCH xserver] xwayland: avoid a crash with empty window pixmaps

2018-01-24 Thread Adam Jackson
On Wed, 2018-01-24 at 11:36 +0100, Olivier Fourdan wrote: > So basically, just remove the “if > (RegionNotEmpty(DamageRegion(xwl_window->damage)))” would suffice? Worth a try anyway. I'm still just guessing at the root cause. - ajax ___

Re: [PATCH xserver] xf86XvMCScreenInit: Clear pScreenPriv->dixinfo when freeing pAdapt

2018-01-24 Thread Adam Jackson
On Wed, 2018-01-24 at 12:28 +0100, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes double-free later in xf86XvMCCloseScreen, which would generally > cause fireworks. > > Signed-off-by: Michel Dänzer remote: I: patch #200379 updated using