Re: [RFC dri3proto v6 01/14] Add modifier/multi-plane requests, bump to v1.1

Hi, On Wed, 2018-02-21 at 11:32 -0800, Keith Packard wrote: > Louis-Francis Ratté-Boulianne writes: > > I'll review just the specification today; once we've got that wired, > I'll go ahead and verify that the encoding matches this spec. > > > diff --git a/dri3proto.txt

[PATCH xserver 2/3] render: Cosmetic cleanup to default format creation

Signed-off-by: Adam Jackson --- render/picture.c | 70 ++-- 1 file changed, 27 insertions(+), 43 deletions(-) diff --git a/render/picture.c b/render/picture.c index 1952785b2..f0638a39f 100644 --- a/render/picture.c +++

[PATCH xserver 1/3] render: Remove some 24bpp handling

This can't happen anymore. Signed-off-by: Adam Jackson --- render/picture.c | 8 1 file changed, 8 deletions(-) diff --git a/render/picture.c b/render/picture.c index 9e4036e7d..1952785b2 100644 --- a/render/picture.c +++ b/render/picture.c @@ -293,14 +293,6 @@

[PATCH xserver 0/3] Render format list cleanups

Testing Mario's depth-30 series revealed some non-glamor bugs. I'm a little nervous about 3/3 removing the 'depth 32' x8r8g8b8 format as there could easily be code relying on it existing, but at least cairo seems to get this right. - ajax ___

[PATCH xserver 3/3] render: Fix default picture format initialization

"depth" for a picture format is the sum of bits of a/r/g/b, and not x. The default format list was creating an x8r8g8b8 format at depth 32, which is wrong. Likewise, servers supporting depth 30 would get an x8r8g8b8 format at depth 30, which is nonsense. Signed-off-by: Adam Jackson

RE: [PATCH xserver 3/3] render: Fix default picture format initialization

> "depth" for a picture format is the sum of bits of a/r/g/b, and not x. > The default format list was creating an x8r8g8b8 format at depth 32, > which is wrong. Likewise, servers supporting depth 30 would get an > x8r8g8b8 format at depth 30, which is nonsense. > formats[nformats].format =

[PATCH xserver] composite: Fix use-after-free in compReparentWindow

If an implicitly redirected window is unredirected by the reparent operation, cw will be a stale pointer. Signed-off-by: Peter Harris --- composite/compwindow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/composite/compwindow.c

Re: [PATCH xserver 2/3] render: Cosmetic cleanup to default format creation

Adam Jackson writes: > Signed-off-by: Adam Jackson Reviewed-by: Keith Packard -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH xserver 1/3] render: Remove some 24bpp handling

Adam Jackson writes: > This can't happen anymore. > > Signed-off-by: Adam Jackson Reviewed-by: Keith Packard -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org:

Re: [PATCH xserver 3/3] render: Fix default picture format initialization

Adam Jackson writes: > "depth" for a picture format is the sum of bits of a/r/g/b, and not x. > The default format list was creating an x8r8g8b8 format at depth 32, > which is wrong. Likewise, servers supporting depth 30 would get an > x8r8g8b8 format at depth 30, which is

Re: [PATCH xserver] composite: Fix use-after-free in compReparentWindow

Peter Harris writes: > If an implicitly redirected window is unredirected by the reparent > operation, cw will be a stale pointer. > > Signed-off-by: Peter Harris Reviewed-by: Keith Packard -- -keith signature.asc Description: