Re: [PATCH xkbcomp] Ignore xkb_keycodes.maximum of > 255

2018-06-07 Thread Daniel Stone
On 7 June 2018 at 05:13, Peter Hutterer wrote: > Continuation from 7fdfabd75 "keycodes: Ignore high keycodes" > > A keymap with a key > 255 will have a xkb_keycodes.maximum of that keycode. > Let's not throw a fatal error on that, just crop it back to the maximum of > 255. This doesn't set the "hi

Re: [PATCH xserver] glamor: Enable modifier support for xfree86 too

2018-06-07 Thread Daniel Stone
On 6 June 2018 at 20:56, Adam Jackson wrote: > This was left disabled in 1.20.0, it's time to start being sure it > works. > > Signed-off-by: Adam Jackson Acked-by: Daniel Stone ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.or

Re: [PATCH xserver] exa: Use PictureMatchFormat for source-only picture format description

2018-06-07 Thread Michel Dänzer
On 2018-06-06 10:26 PM, Adam Jackson wrote: > On Fri, 2018-06-01 at 11:58 +0200, Michel Dänzer wrote: >> From: Michel Dänzer >> >> Their pFormat member is NULL, which resulted in a crash in >> miRenderColorToPixel. >> >> Fixes: 8171d4c2d67b "render: Store and use all 16bpc of precision for >>

Re: [PATCH app/xauth 2/2] Sort entries from most specific to most generic.

2018-06-07 Thread Walter Harms
> Michal Srb hat am 6. Juni 2018 um 08:34 geschrieben: > > > On úterý 5. června 2018 17:46:05 CEST Walter Harms wrote: > > MMh, so far i understand you do an add and then sort the whole thing. > > perhaps it would be more easy to start with a sorted field and insert (add) > > a key on the corr

Re: [PATCH app/xauth 2/2] Sort entries from most specific to most generic.

2018-06-07 Thread Michal Srb
On čtvrtek 7. června 2018 14:59:44 CEST Walter Harms wrote: > I was thinking about a more permanent solution and sofar i see the correct > way would to add the two functions to libXau since i do not see that other > applications would be more clever that xauth. That would be nice, sadly libXau doe

Re: Obtaining Xorg DDX commit privilege

2018-06-07 Thread Adam Jackson
On Thu, 2018-06-07 at 00:10 +0200, Kevin Brace wrote: > I was thinking that it is not really desirable to let VBE start > tinkering with I2C bus related registers this early in the PreInit > callback, That's probably a reasonable intuition, these days. I was just trying to describe the context be

[PATCH xserver] present/wnmd: Preserve window pixmap's screen_x/y on flip

2018-06-07 Thread Michel Dänzer
From: Michel Dänzer The incorrect values could result in the new pixmap's contents getting corrupted down the line. Bugzilla: https://bugs.freedesktop.org/106841 Fixes: 029608dd8020 "present: Add window flip mode" Signed-off-by: Michel Dänzer --- present/present_wnmd.c | 2 ++ 1 file changed,

[PATCH xserver] xfree86: Inline xf86{Read, Write}Mmio{8, 16, 32} on alpha

2018-06-07 Thread Matt Turner
In commit 9db2af6f757e (xfree86: Remove xf86{Map,Unmap}VidMem) we somehow stopped exporting xf86{Read,Write}Mmio{8,16,32}. Since the function pointer indirection was intended to support dense vs sparse and sparse support is now gone, we can just make the functions static inline in compiler.h and av

Re: [PATCH xserver] xfree86: Inline xf86{Read, Write}Mmio{8, 16, 32} on alpha

2018-06-07 Thread Adam Jackson
On Thu, 2018-06-07 at 09:31 -0700, Matt Turner wrote: > In commit 9db2af6f757e (xfree86: Remove xf86{Map,Unmap}VidMem) we > somehow stopped exporting xf86{Read,Write}Mmio{8,16,32}. Since the > function pointer indirection was intended to support dense vs sparse and > sparse support is now gone, we

Re: [PATCH xserver] present/wnmd: Preserve window pixmap's screen_x/y on flip

2018-06-07 Thread Adam Jackson
On Thu, 2018-06-07 at 18:27 +0200, Michel Dänzer wrote: > From: Michel Dänzer > > The incorrect values could result in the new pixmap's contents > getting corrupted down the line. > > Bugzilla: https://bugs.freedesktop.org/106841 > Fixes: 029608dd8020 "present: Add window flip mode" > Signed-off

Re: [PATCH xserver] present/wnmd: Preserve window pixmap's screen_x/y on flip

2018-06-07 Thread Keith Packard
Michel Dänzer writes: > From: Michel Dänzer > > The incorrect values could result in the new pixmap's contents > getting corrupted down the line. > > Bugzilla: https://bugs.freedesktop.org/106841 > Fixes: 029608dd8020 "present: Add window flip mode" Ah. Makes sense. Screen flips are always at 0

[PATCH xserver] modesetting: Also disable CRTC in drmmode_output_disable()

2018-06-07 Thread Lyude Paul
So, this did actually work on older kernels at one point in time, however it seems that this working was a result of some of the Linux kernel's atomic modesetting helpers not preserving the CRTC's enabled state in the right spots. This was fixed in: 846c7dfc1193 ("drm/atomic: Try to preserve the c

Re: [PATCH] Improve the ButtonInfo description.

2018-06-07 Thread Peter Hutterer
On Thu, Jun 07, 2018 at 03:32:08AM +0200, Roman Kapl wrote: > It failed to mention it is followed by a bit-mask and then the atoms. > > Signed-off-by: Roman Kapl > --- > include/X11/extensions/XI2proto.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Patch content is correct, than

Re: [PATCH xserver 2/2] Xi: add forgotten byte-swaps for Valuator fields

2018-06-07 Thread Peter Hutterer
On Thu, Jun 07, 2018 at 03:31:42AM +0200, Roman Kapl wrote: > This has caused nonsensical values in xinput output. > > Signed-off-by: Roman Kapl > --- > Xi/xiquerydevice.c | 3 +++ > 1 file changed, 3 insertions(+) pushed, thanks remote: Updating patchwork state for https://patchwork.freedesk

Re: [PATCH xserver] present/wnmd: Preserve window pixmap's screen_x/y on flip

2018-06-07 Thread Olivier Fourdan
Hi Michel, On Thu, Jun 7, 2018 at 6:27 PM, Michel Dänzer wrote: > From: Michel Dänzer > > The incorrect values could result in the new pixmap's contents > getting corrupted down the line. > > Bugzilla: https://bugs.freedesktop.org/106841 > Fixes: 029608dd8020 "present: Add window flip mode" > Si