Re: [PATCH app/sessreg] Replace strncpy calls with a sane version that always terminates

2018-09-12 Thread Walter Harms
> Peter Hutterer hat am 12. September 2018 um 06:50 > geschrieben: > > > Fixes coverity complaints about potentially unterminated strings > > Signed-off-by: Peter Hutterer > --- > sessreg.c | 26 +- > 1 file changed, 17 insertions(+), 9 deletions(-) > > diff --git

Re: [PATCH app/sessreg] Replace strncpy calls with a sane version that always terminates

2018-09-12 Thread Peter Hutterer
On Wed, Sep 12, 2018 at 09:09:22AM +0200, Walter Harms wrote: > > > > Peter Hutterer hat am 12. September 2018 um 06:50 > > geschrieben: > > > > > > Fixes coverity complaints about potentially unterminated strings > > > > Signed-off-by: Peter Hutterer > > --- > > sessreg.c | 26

Re: [PATCH] devices: break after finding and removing device from lists

2018-09-12 Thread Dave Airlie
On Wed, 12 Sep 2018 at 23:39, Walter Harms wrote: > > > > > Dave Airlie hat am 12. September 2018 um 03:40 > > geschrieben: > > > > > > From: Dave Airlie > > > > Coverity complains about a use after free in here after the > > freeing, I can't follow the linked list so well, but whot > > says

Re: [PATCH app/sessreg] Replace strncpy calls with a sane version that always terminates

2018-09-12 Thread Alan Coopersmith
On 09/12/18 12:09 AM, Walter Harms wrote: Peter Hutterer hat am 12. September 2018 um 06:50 geschrieben: Fixes coverity complaints about potentially unterminated strings Signed-off-by: Peter Hutterer --- sessreg.c | 26 +- 1 file changed, 17 insertions(+), 9

[PATCH app/xrandr] init the name to 0

2018-09-12 Thread Peter Hutterer
There are a few conditions where coverity finds a use of an uninitialized field of the name_t struct. These are rather messy combinations of conditions, so let's go with the simple solution here and just init everything to 0. This may still have side-effects but at least they'll be more obvious

Re: [PATCH] devices: break after finding and removing device from lists

2018-09-12 Thread Walter Harms
> Dave Airlie hat am 12. September 2018 um 03:40 > geschrieben: > > > From: Dave Airlie > > Coverity complains about a use after free in here after the > freeing, I can't follow the linked list so well, but whot > says the device can only be on one list once, so break should > fix it. > >