Re: [PATCH xserver v8 05/14] modesetting: Use atomic modesetting API for pageflip if available

2018-10-01 Thread Adam Jackson
On Wed, 2018-09-12 at 11:01 +1000, Dave Airlie wrote: > On Wed, 28 Feb 2018 at 11:21, Daniel Stone wrote: > > > > +static Bool > > +drmmode_prop_info_copy(drmmode_prop_info_ptr dst, > > + const drmmode_prop_info_rec *src, > > + unsigned int num_props, >

Re: [PATCH xserver v8 05/14] modesetting: Use atomic modesetting API for pageflip if available

2018-10-01 Thread Adam Jackson
On Mon, 2018-10-01 at 11:31 -0400, Adam Jackson wrote: > AFAICT the free(dst) is always wrong. The other places we use > drmmode_prop_info_copy, we're initializing an array in the middle of a > drmmode_{crtc,output}_private_rec. https://gitlab.freedesktop.org/xorg/xserver/merge_requests/33 -

XDC 2018 feedback and comments

2018-10-01 Thread Daniel Vetter
Hi all, Once more huge thanks to the entire team from g.p.u.l. and Igalia, personally I think this was an extremely well organized XDC! As usual we're looking for feedback on both XDC itself, and the CFP process and program selection. Both about what was great and should be kept for next year's

Re: [PATCH app/xcursorgen] Update README for gitlab migration

2018-10-01 Thread Alan Coopersmith
Does anyone have feedback on changing our README's like this? While I sent this out as a patch to a specific repo, I figured once we have an agreed upon template, we'd apply it to all of the repos. -alan- On 09/22/18 12:11 PM, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith

Re: [PATCH libXpm] After fdopen(), use fclose() instead of close() in error path

2018-10-01 Thread Peter Hutterer
On Sun, Sep 30, 2018 at 03:14:00PM -0700, Alan Coopersmith wrote: > Found by Oracle's Parfait 2.2 static analyzer: > > Error: File Leak >File Leak [file-ptr-leak]: > Leaked File fp > at line 94 of lib/libXpm/src/RdFToBuf.c in function > 'XpmReadFileToBuffer > '. > fp

Re: [PATCH app/xcursorgen] Update README for gitlab migration

2018-10-01 Thread Peter Hutterer
On Mon, Oct 01, 2018 at 10:11:07AM -0700, Alan Coopersmith wrote: > Does anyone have feedback on changing our README's like this? While I > sent this out as a patch to a specific repo, I figured once we have > an agreed upon template, we'd apply it to all of the repos. oh well, if you ask... :)

error x11

2018-10-01 Thread Dem Bat
On 2018-10-01 12:19 p.m., Dem Bat wrote: > (==)Using system config directory "/usr/share/X11/xorg.conf.d" > (EE) > (EE) Backtrace: > (EE) 0: /usr/lib/xorg/Xorg (xorg_backtrace+0x4d) [0x560589b14e3d] > (EE) 1: /usr/lib/xorg/Xorg (0x56058995d000+bbbd9) [0x560589b18bd9] > (EE) 2: