[PATCH xf86-video-v4l 4/4] Fix ioctl return value handling

Found by coverity Signed-off-by: Peter Hutterer --- src/v4l.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/v4l.c b/src/v4l.c index 8c2408c..9c6fabe 100644 --- a/src/v4l.c +++ b/src/v4l.c @@ -769,12 +769,15 @@ V4lSetPortAttribute(ScrnInfoPtr pScrn,

[PATCH xf86-video-v4l 3/4] Fix handling of realloc failure

Coverity complaint and whatnot Signed-off-by: Peter Hutterer --- src/v4l.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/v4l.c b/src/v4l.c index 583c7b8..8c2408c 100644 --- a/src/v4l.c +++ b/src/v4l.c @@ -1120,6 +1120,7 @@ V4LInit(ScrnInfoPtr pScrn,

[PATCH xf86-video-v4l 2/4] Ensure the device name is null-terminated

And expand the size to 18, because the stack array we copied this into is 18 bytes long. This covers us for up to 999 (kernel) v4l devices and that is definitely not a reason to use the "640k ought to be enough" meme. Found by - you guessed it - coverity! Signed-off-by: Peter Hutterer ---

[PATCH xf86-video-v4l 1/4] Remove unused variable osname

Coverity is unhappy and there's enough unhappiness in this world already, so let's go for the low-hanging fruit. Signed-off-by: Peter Hutterer --- src/v4l.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/v4l.c b/src/v4l.c index 8db8f7d..0f1058e 100644 --- a/src/v4l.c +++ b/src/v4l.c @@

Re: [PATCH xf86-video-v4l 1/4] Remove unused variable osname

yay, for all 4. Reviewed-by: Dave Airlie On Mon, 8 Oct 2018 at 13:20, Peter Hutterer wrote: > > Coverity is unhappy and there's enough unhappiness in this world already, so > let's go for the low-hanging fruit. > > Signed-off-by: Peter Hutterer > --- > src/v4l.c | 1 - > 1 file changed, 1