Re: Current tinderbox regression (xserver, randr)

On Tue, Feb 22, 2011 at 10:36 PM, Chris Ball wrote: > Hi Keith, > > On Fri, Feb 18, 2011 at 09:21:06AM +0100, Cyril Brulebois wrote: > > Chris Ball (17/02/2011): > > > http://tinderbox.x.org/builds/2011-02-17-0007/logs/xserver/#build > > > > > > rrcrtc.c: In function 'RRConvertCrtcConfig': > > >

Re: [PATCH] Unbreak the .m.c rule

On Tue, Feb 22, 2011 at 05:57:26PM -0500, Adam Jackson wrote: > Some builds of gnu make apparently know how to go straight from .m to .o. > That's great if your .m file is Objective C source, but for us, it's not. > > Signed-off-by: Adam Jackson > --- > xts5/common.mk |4 > 1 files chan

Re: [PATCH libXi] Fix invalid read in XIGrabDevice.

On Wed, Feb 23, 2011 at 01:22:36AM +0100, Julien Cristau wrote: > On Wed, Feb 23, 2011 at 09:36:06 +1000, Peter Hutterer wrote: > > > Miscalculation of length caused Data() to memcpy too many bytes. > > > > ==2865== Invalid read of size 1 > > ==2865==at 0x4A07480: memcpy (mc_replace_strmem.c:

Re: Current tinderbox regression (xserver, randr)

Hi Keith, On Fri, Feb 18, 2011 at 09:21:06AM +0100, Cyril Brulebois wrote: > Chris Ball (17/02/2011): > > http://tinderbox.x.org/builds/2011-02-17-0007/logs/xserver/#build > > > > rrcrtc.c: In function 'RRConvertCrtcConfig': > > rrcrtc.c:1512: error: 'RR_CurrentScanoutPixmap' undeclared (first u

Re: [PATCH libXi] Fix invalid read in XIGrabDevice.

On Wed, Feb 23, 2011 at 09:36:06 +1000, Peter Hutterer wrote: > Miscalculation of length caused Data() to memcpy too many bytes. > > ==2865== Invalid read of size 1 > ==2865==at 0x4A07480: memcpy (mc_replace_strmem.c:602) > ==2865==by 0x544271E: XIGrabDevice (XIGrabDevice.c:69) > ==2865==

[PATCH libXi] Fix invalid read in XIGrabDevice.

Miscalculation of length caused Data() to memcpy too many bytes. ==2865== Invalid read of size 1 ==2865==at 0x4A07480: memcpy (mc_replace_strmem.c:602) ==2865==by 0x544271E: XIGrabDevice (XIGrabDevice.c:69) ==2865==by 0x400B0A: main (gnome642481.c:56) ==2865== Address 0x642f614 is 0 b

[PATCH] Unbreak the .m.c rule

Some builds of gnu make apparently know how to go straight from .m to .o. That's great if your .m file is Objective C source, but for us, it's not. Signed-off-by: Adam Jackson --- xts5/common.mk |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/xts5/common.mk b/xts5/com

Re: [PATCH 10/20] Switch to use IsFloating()

On 02/22/2011 11:31 PM, Peter Hutterer wrote: On Tue, Feb 22, 2011 at 08:17:32AM +0100, Benjamin Tissoires wrote: Hi Peter, Except two unnecessary parenthesis here, you can add my Reviewed-by for the series ;) On 02/18/2011 04:52 AM, Peter Hutterer wrote: [...] diff --git a/Xi/xipassivegra

Re: [PATCH 10/20] Switch to use IsFloating()

On Tue, Feb 22, 2011 at 08:17:32AM +0100, Benjamin Tissoires wrote: > Hi Peter, > > Except two unnecessary parenthesis here, you can add my Reviewed-by > for the series ;) > > On 02/18/2011 04:52 AM, Peter Hutterer wrote: [...] > >diff --git a/Xi/xipassivegrab.c b/Xi/xipassivegrab.c > >index e9

Re: [PATCH v2 2/6] Input: Don't freeze unrelated devices in DeliverGrabbedEvent

On Tue, Feb 22, 2011 at 01:43:28PM +, Daniel Stone wrote: > When delivering an event to a device grabbed with SyncBoth, > DeliverGrabbedEvent walks the device tree looking for associated devices > to freeze them. Unfortunately, it froze all devices instead of just the > paired device, and the

Re: Spinning in _XReply

Rami Ylimäki writes: > Today I found out that even Mozilla code is > suffering from this problem > (http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsX11ErrorHandler.cpp). > > Adding Karl into CC. It looks like nsX11ErrorHandler.cpp is also > calling Xlib functions resulting in protocol

Re: [PATCH] include: document list interface.

On 02/21/11 07:29 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > include/list.h | 182 > +++- > 1 files changed, 180 insertions(+), 2 deletions(-) > > diff --git a/include/list.h b/include/list.h > index 4ce20a8..3c8c754 10

[PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

Also includes resolutions for dependent devices and implicit grabs and how to handle slave touch device attachment and touch selections. Signed-off-by: Chase Douglas --- Diff is against latest patch sent by Daniel Stone. See http://cgit.freedesktop.org/~cndougla/inputproto for the cumulative XI

Re: [PATCH 2/6] Input: Don't freeze unrelated devices in DeliverGrabbedEvent

On Thu, Feb 17, 2011 at 09:13:07AM +1000, Peter Hutterer wrote: > On Tue, Feb 15, 2011 at 08:11:25PM +0100, Simon Thum wrote: > > On 02/15/2011 12:27 PM, Daniel Stone wrote: > > > --- a/dix/events.c > > > +++ b/dix/events.c > > > @@ -3884,14 +3884,14 @@ DeliverGrabbedEvent(InternalEvent *event, >

[PATCH v2 2/6] Input: Don't freeze unrelated devices in DeliverGrabbedEvent

When delivering an event to a device grabbed with SyncBoth, DeliverGrabbedEvent walks the device tree looking for associated devices to freeze them. Unfortunately, it froze all devices instead of just the paired device, and the previous fix in 4fbadc8b17237f3c would still break if the same client

Re: Spinning in _XReply

On 02/22/2011 11:14 AM, Julien Cristau wrote: On Sat, Jan 29, 2011 at 09:54:37 -0800, Jeremy Huddleston wrote: 2) emacs' error handler seems bugged. Is it legal to call XSync() within the error handler? It certainly seems like it shouldn't. Did we used to actually support this with the xtr

Re: Spinning in _XReply

On Sat, Jan 29, 2011 at 09:54:37 -0800, Jeremy Huddleston wrote: > 2) emacs' error handler seems bugged. Is it legal to call XSync() within the > error handler? It certainly seems like it shouldn't. Did we used to > actually support this with the xtrans version of libX11? > Not as far as I c

Re: [PATCH v2 setxkbmap] man: multiple layouts can be specified (#34118)

On Tue, Feb 22, 2011 at 14:50:57 +1000, Peter Hutterer wrote: > Same applies to variant. > > X.Org Bug 34118 > > Signed-off-by: Peter Hutterer > --- > I guess the matching should be explained with an example somewhere, but for > now this will