Re: [PATCH:macros 2/2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

2011-04-27 Thread Dan Nicholson
On Mon, Apr 25, 2011 at 8:35 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Still only adds it to CWARNFLAGS if --enable-strict-compilation is passed, but sets the variable with the right flags for the compiler so it's available for other checks in configure scripts. Signed-off-by:

[PATCH libXt] Only link with ws2_32 for mingw target

2011-04-27 Thread Jon TURNEY
For the Cygwin target, we will be using the socket functions provided by the Cygwin DLL, so linking with ws2_32 is unnecessary, even though it may be present. Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk --- configure.ac |9 - 1 files changed, 8 insertions(+), 1 deletions(-)

Why no activity on this (nasty X segfault) bug?

2011-04-27 Thread Ian Pilcher
On 04/23/2011 09:25 PM, Ian Pilcher wrote: If there's a different iteration of the patch that you would like me to test, please point me to it. Otherwise, I would urge you to get this thing pushed. https://bugs.freedesktop.org/show_bug.cgi?id=35452 Anybody out there? What is needed to get

[PULL] hw/xwin: Various fixes

2011-04-27 Thread Jon TURNEY
Hi Keith, The following set of patches contain various fixes to the XWin DDX. Please consider pulling into master. Thanks. The following changes since commit 918a9c99cf2ebc73acb34b95f597904b93c690d9: Merge remote-tracking branch 'jeremyhu/master' (2011-04-22 11:20:16 -0700) are available

EVoC

2011-04-27 Thread Saurabh Sood
hi all, one of my friends vikash's gsoc proposal for xorg was accepted. i found the proposal and project very interesting and was interested to help him on the same. is it possible that i do this project as part of EVoC? With him, I have started going through the xcb, and xkb documentations. I am

Re: Why no activity on this (nasty X segfault) bug?

2011-04-27 Thread Mario Kleiner
On Apr 27, 2011, at 2:45 PM, Ian Pilcher wrote: On 04/23/2011 09:25 PM, Ian Pilcher wrote: If there's a different iteration of the patch that you would like me to test, please point me to it. Otherwise, I would urge you to get this thing pushed.

Re: Why no activity on this (nasty X segfault) bug?

2011-04-27 Thread Ian Pilcher
On 04/27/2011 10:00 AM, Mario Kleiner wrote: Original thread was this, between Michel and Keith: http://lists.x.org/archives/xorg-devel/2011-March/020716.html The refined patch of Keith that needs testing: http://www.mail-archive.com/xorg-devel@lists.x.org/msg20650.html The two

Re: [Xcb] EVoC

2011-04-27 Thread Alan Coopersmith
On 04/27/11 06:32 AM, Saurabh Sood wrote: hi all, one of my friends vikash's gsoc proposal for xorg was accepted. i found the proposal and project very interesting and was interested to help him on the same. is it possible that i do this project as part of EVoC? We will not approve EVoC

Re: Why no activity on this (nasty X segfault) bug?

2011-04-27 Thread Mario Kleiner
On Apr 27, 2011, at 5:12 PM, Ian Pilcher wrote: On 04/27/2011 10:00 AM, Mario Kleiner wrote: Original thread was this, between Michel and Keith: http://lists.x.org/archives/xorg-devel/2011-March/020716.html The refined patch of Keith that needs testing:

Re: Why no activity on this (nasty X segfault) bug?

2011-04-27 Thread Ian Pilcher
On 04/27/2011 10:45 AM, Mario Kleiner wrote: No, Keith patch is more efficient. It avoids walking parts of the window tree. OK. I will test with that patch and post post back. -- Ian Pilcher

Re: [PATCH:macros 2/2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

2011-04-27 Thread Jeremy Huddleston
Actually, I think you should do this for gcc since it doesn't automatically error on unknown attributes (then I can pull that into the xorg-tls macro): STRICT_CFLAGS=-pedantic -Werror -Werror=attributes On Apr 27, 2011, at 3:54 AM, Dan Nicholson wrote: On Mon, Apr 25, 2011 at 8:35 PM, Alan

Re: [PULL] Render and region changes

2011-04-27 Thread Keith Packard
On Sat, 23 Apr 2011 04:24:30 +0200, Soeren Sandmann sandm...@cs.au.dk wrote: Søren Sandmann Pedersen (7): Track damage for fbTrapezoids() and fbTriangles(). Add RegionInitBoxes(), and fix some buggy callers of RegionInit(). render: Delete PictureGradientColor()

Re: [PULL] duplicate includes, clang warnings, static analyzer bugfixes, and XQuartz

2011-04-27 Thread Keith Packard
On Mon, 25 Apr 2011 20:01:11 -0700, Jeremy Huddleston jerem...@apple.com wrote: Emanuele Giaquinta (1): XQuartz: pbproxy: LP64: Fix itteration through XGetWindowProperty where sizeof(long) != 4 Jeremy Huddleston (21): os: Add missing _X_ATTRIBUTE_PRINTF to va_list variants

Re: [PULL] hw/xwin: Various fixes

2011-04-27 Thread Keith Packard
On Wed, 27 Apr 2011 14:31:44 +0100, Jon TURNEY jon.tur...@dronecode.org.uk wrote: Jon TURNEY (7): Cygwin/X: Internal WM workaround for Java AWT bug Cygwin/X: Fix a GDI bitmap resource leak of window icons Cygwin/X: Don't make InputOnly windows visible Cygwin/X:

Re: [PULL] hw/xwin: Find GL specs, rather than downloading them

2011-04-27 Thread Keith Packard
On Tue, 26 Apr 2011 10:48:41 +0100, Jon TURNEY jon.tur...@dronecode.org.uk wrote: Hi Keith, The following set of patches removes the downloading of GL specs from hw/xwin. Please consider pulling into master. I'm getting a failure in distcheck with this merged in: make[3]: Entering

Re: [PULL] hw/xwin: Find GL specs, rather than downloading them

2011-04-27 Thread Jon TURNEY
On 27/04/2011 20:18, Keith Packard wrote: On Tue, 26 Apr 2011 10:48:41 +0100, Jon TURNEY jon.tur...@dronecode.org.uk wrote: Hi Keith, The following set of patches removes the downloading of GL specs from hw/xwin. Please consider pulling into master. I'm getting a failure in distcheck

Re: [PATCH sis 00/15] a bunch of cleanups, and a taste of things to come

2011-04-27 Thread TImo Aaltonen
On 13.04.2011 18:22, TImo Aaltonen wrote: On 06.04.2011 19:50, Timo Aaltonen wrote: Here's a first set of patches to xf86-video-sis, hoping to narrow down the diff against Thomas Winischofer's 'sisfree' (*) package and the forked versions from Intel and SiS (and Mandriva). The first 13 are

Re: Why no activity on this (nasty X segfault) bug?

2011-04-27 Thread Ian Pilcher
On 04/27/2011 10:12 AM, Ian Pilcher wrote: On 04/27/2011 10:00 AM, Mario Kleiner wrote: Original thread was this, between Michel and Keith: http://lists.x.org/archives/xorg-devel/2011-March/020716.html The refined patch of Keith that needs testing:

[PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-04-27 Thread Matt Turner
Text size reduction of ~33k (1.8%): textdata bss dec hex filename 1879739 72212 55328 2007279 1ea0ef hw/xfree86/Xorg.before 1845291 72212 55328 1972831 1e1a5f hw/xfree86/Xorg On x86[-64], the number of bswap instructions goes up from 5 to 1006. By defining lswapl as

[PATCH 3/6] Use abs() on integers, not fabs()

2011-04-27 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/modes/xf86Crtc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes/xf86Crtc.c index c2814d4..92c75b1 100644 --- a/hw/xfree86/modes/xf86Crtc.c +++

[PATCH 4/6] Remove unnecessary #undefs of [f]abs and old comments

2011-04-27 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- glx/glxserver.h |6 -- hw/dmx/glxProxy/glxserver.h |6 -- 2 files changed, 0 insertions(+), 12 deletions(-) diff --git a/glx/glxserver.h b/glx/glxserver.h index 891315b..6bcf7d3 100644 --- a/glx/glxserver.h +++

[PATCH 5/6] Replace Fabs() macro with fabs() function

2011-04-27 Thread Matt Turner
gcc generates better code with fabs() anyway. Signed-off-by: Matt Turner matts...@gmail.com --- include/misc.h |3 --- mi/miarc.c |2 +- mi/mifpoly.h|6 +++--- mi/miwideline.c |2 +- 4 files changed, 5 insertions(+), 8 deletions(-) diff --git a/include/misc.h

[PATCH 6/6] Silence printf format warnings in helper_exec.c

2011-04-27 Thread Matt Turner
Signed-off-by: Matt Turner matts...@gmail.com --- hw/xfree86/int10/helper_exec.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/xfree86/int10/helper_exec.c b/hw/xfree86/int10/helper_exec.c index ec84200..8cca28a 100644 ---

[PATCH 1/2] Add _X_UNUSED attribute to designate unused variables and silence warnings

2011-04-27 Thread Jeremy Huddleston
Signed-off-by: Jeremy Huddleston jerem...@apple.com --- Alan, what SunCC magic needs to go here? Xfuncproto.h.in |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/Xfuncproto.h.in b/Xfuncproto.h.in index 2b8a226..88d91c0 100644 --- a/Xfuncproto.h.in +++

[PATCH 2/2] Add _X_NONNULL macro to annotate when a function expects arguments to be non-null

2011-04-27 Thread Jeremy Huddleston
This will allow with compiler optimization and better static analysis. Signed-off-by: Jeremy Huddleston jerem...@apple.com --- Alan, what SunCC magic needs to go here? Xfuncproto.h.in |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/Xfuncproto.h.in

Re: [PATCH:macros 2/2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

2011-04-27 Thread Alan Coopersmith
On 04/27/11 03:54 AM, Dan Nicholson wrote: IMO, you should at least AC_SUBST the variable if you want to use it somewhere else. I just wanted to make it available to the XORG_TLS macro Jeremy's working on, not in a Makefile - is AC_SUBST needed for that? On the other hand it doesn't hurt, so I

Re: [PATCH:macros 2/2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

2011-04-27 Thread Dan Nicholson
On Wed, Apr 27, 2011 at 5:32 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 04/27/11 03:54 AM, Dan Nicholson wrote: IMO, you should at least AC_SUBST the variable if you want to use it somewhere else. I just wanted to make it available to the XORG_TLS macro Jeremy's working on,

Question about the modesetting on X server

2011-04-27 Thread Huang, FrankR
Hi, all Right now, I am working on the graphics driver and use X server architecture as our base. I finished the modeset part now. But I encounter a problem that puzzled me. As you know, in dix_main(), the mode will be set in xf86CrtcCreateScreenResources. Then the code will go to

Question about the modesetting on X server

2011-04-27 Thread Huang, FrankR
Hi, all Right now, I am working on the graphics driver and use X server architecture as our base. I finished the modeset part now. But I encounter a problem that puzzled me. As you know, in dix_main(), the mode will be set in xf86CrtcCreateScreenResources. Then the code will go to

Re: Question about the modesetting on X server

2011-04-27 Thread Alan Coopersmith
On 04/27/11 07:46 PM, Huang, FrankR wrote: Hi, all Right now, I am working on the graphics driver and use X server architecture as our base. I finished the modeset part now. But I encounter a problem that puzzled me. As you know, in dix_main(), the mode will be set in

Re: [PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-04-27 Thread Keith Packard
On Wed, 27 Apr 2011 19:33:01 -0400, Matt Turner matts...@gmail.com wrote: Signed-off-by: Matt Turner matts...@gmail.com Reviewed-by: Keith Packard kei...@keithp.com --- The follow-up patch to this which removes the temporary variables used by the swap macros is too big for the mailing

Re: [PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-04-27 Thread Matt Turner
On Thu, Apr 28, 2011 at 12:44 AM, Keith Packard kei...@keithp.com wrote: On Wed, 27 Apr 2011 19:33:01 -0400, Matt Turner matts...@gmail.com wrote: The follow-up patch to this which removes the temporary variables used by the swap macros is too big for the mailing list, so please review it

RE: Question about the modesetting on X server

2011-04-27 Thread Huang, FrankR
Okay. I understand that. But how the X server knows that no cliens are connected again? Is there any time stamp to record it? Let me describe my debug process. I use GDB to debug the X server. When the X server is booting up, I set the breakpoint on modesetting function. Then I run xrandr -s

Re: [PATCH 1/6] make byte swapping macros less opaque to the optimizer

2011-04-27 Thread Jeremy Huddleston
For 1,2,4,5: Reviewed-by: Jeremy Huddleston jerem...@apple.com Tested-by: Jeremy Huddleston jerem...@apple.com For 3,6: Reviewed-by: Jeremy Huddleston jerem...@apple.com On Apr 27, 2011, at 16:33, Matt Turner wrote: Text size reduction of ~33k (1.8%): text data bss dec