[PATCH:xwininfo] When matching window names, ensure name lengths match too

2011-06-08 Thread Alan Coopersmith
Prevents strncmp returning on partial matches when one is shorter. https://bugs.freedesktop.org/show_bug.cgi?id=37710 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- dsimple.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/dsimple.c

[PATCH:xkbcomp] Replace repeated checks for gcc with _X_ATTRIBUTE_PRINTF from xproto

2011-06-08 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- utils.h | 63 +-- 1 files changed, 9 insertions(+), 54 deletions(-) diff --git a/utils.h b/utils.h index 65e37c8..61a5987 100644 --- a/utils.h +++ b/utils.h @@ -115,12

[PATCH:ico] Replace local checks for gcc with _X_NORETURN from xproto 7.0.17

2011-06-08 Thread Alan Coopersmith
Also declare icoFatal as static since it's only used in this one file. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |2 +- ico.c|9 - 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index

Re: [PATCH:xwininfo] When matching window names, ensure name lengths match too

2011-06-08 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Tue, 7 Jun 2011 23:13:46 -0700 Prevents strncmp returning on partial matches when one is shorter. https://bugs.freedesktop.org/show_bug.cgi?id=37710 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark

Re: [PATCH:xkbcomp] Replace repeated checks for gcc with _X_ATTRIBUTE_PRINTF from xproto

2011-06-08 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Tue, 7 Jun 2011 23:55:25 -0700 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Strangely formatted code, but that's not your fault. Reviewed-by: Mark Kettenis kette...@openbsd.org utils.h | 63

Re: [PATCH:ico] Replace local checks for gcc with _X_NORETURN from xproto 7.0.17

2011-06-08 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Wed, 8 Jun 2011 00:04:34 -0700 Also declare icoFatal as static since it's only used in this one file. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- configure.ac

Re: [PATCH:ico] Replace local checks for gcc with _X_NORETURN from xproto 7.0.17

2011-06-08 Thread Cyril Brulebois
Alan Coopersmith alan.coopersm...@oracle.com (08/06/2011): Also declare icoFatal as static since it's only used in this one file. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Cyril Brulebois k...@debian.org Mraw, KiBi. signature.asc Description: Digital

[PATCH xf86-video-mga 0/9] Silence compile warnings and remove redundant defines

2011-06-08 Thread Nicolas Kaiser
These patches silence compile warnings, and remove some unused or duplicated defines. Tested on a Matrox G550 AGP. [PATCH 1/9] include unistd.h for usleep() [PATCH 2/9] fix formats in xf86DrvMsg() [PATCH 3/9] hide conditionally used variable in mga_read_and_process_bios [PATCH 4/9] remove unused

[PATCH xf86-video-mga 1/9] include unistd.h for usleep()

2011-06-08 Thread Nicolas Kaiser
Silences compile warning src/mga_vga.c:65: warning: implicit declaration of function 'usleep' Additionally silences Gentoo QA warning * QA Notice: Package has poor programming practices which may compile *fine but exhibit random runtime failures. Signed-off-by: Nicolas Kaiser

[PATCH xf86-video-mga 2/9] fix formats in xf86DrvMsg()

2011-06-08 Thread Nicolas Kaiser
Silences compile warnings src/mga_exa.c:869: warning: format '%x' expects type 'unsigned int', but argument 5 has type 'long unsigned int' and src/mga_exa.c:869: warning: format '%x' expects type 'unsigned int', but argument 6 has type 'long unsigned int' Signed-off-by: Nicolas Kaiser

[PATCH xf86-video-mga 3/9] hide conditionally used variable in mga_read_and_process_bios

2011-06-08 Thread Nicolas Kaiser
Silences compile warning src/mga_bios.c:303: warning: unused variable 'rlen' Signed-off-by: Nicolas Kaiser ni...@nikai.net --- src/mga_bios.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mga_bios.c b/src/mga_bios.c index b533dd1..e40bb86 100644 ---

[PATCH xf86-video-mga 4/9] remove unused variables in MGAG200EHPIXPLLSET

2011-06-08 Thread Nicolas Kaiser
Silence compile warnings src/mga_dacG.c: In function 'MGAG200EHPIXPLLSET': src/mga_dacG.c:545: warning: unused variable 'ucS' src/mga_dacG.c:544: warning: unused variable 'ucP' src/mga_dacG.c:543: warning: unused variable 'ucN' src/mga_dacG.c:542: warning: unused variable 'ucM' src/mga_dacG.c:540:

[PATCH xf86-video-mga 5/9] remove unused variables in CopyMungedScanlineFilterDown_AXP

2011-06-08 Thread Nicolas Kaiser
Silence compile warnings src/mga_video.c: In function 'CopyMungedScanlineFilterDown_AXP': src/mga_video.c:1472: warning: unused variable 'vf' src/mga_video.c:1472: warning: unused variable 'uf' Signed-off-by: Nicolas Kaiser ni...@nikai.net --- src/mga_video.c |2 +- 1 files changed, 1

[PATCH xf86-video-mga 6/9] hide conditionally used variable in MGACopyILOAD

2011-06-08 Thread Nicolas Kaiser
Silence compile warning src/mga_video.c: In function 'MGACopyILOAD': src/mga_video.c:1801: warning: unused variable 'k' Signed-off-by: Nicolas Kaiser ni...@nikai.net --- src/mga_video.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/mga_video.c b/src/mga_video.c

[PATCH xf86-video-mga 7/9] maven: remove duplicated defines

2011-06-08 Thread Nicolas Kaiser
Remove duplicated defines. Signed-off-by: Nicolas Kaiser ni...@nikai.net --- src/mga_maven.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/mga_maven.h b/src/mga_maven.h index 219d91e..478e0db 100644 --- a/src/mga_maven.h +++ b/src/mga_maven.h @@ -4,9 +4,6 @@

[PATCH xf86-video-mga 8/9] storm: remove unused define PSZ

2011-06-08 Thread Nicolas Kaiser
Remove unused define PSZ. Signed-off-by: Nicolas Kaiser ni...@nikai.net --- src/mga_storm.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/mga_storm.c b/src/mga_storm.c index f0e6194..df18f4a 100644 --- a/src/mga_storm.c +++ b/src/mga_storm.c @@ -1,5 +1,3 @@

[PATCH xf86-video-mga 9/9] include xf86Modes.h for xf86ModeBandwidth()

2011-06-08 Thread Nicolas Kaiser
Fixes compile warning src/mga_driver.c: In function 'MGAValidMode': src/mga_driver.c:4340: warning: implicit declaration of function 'xf86ModeBandwidth' Additionally silences Gentoo QA warning * QA Notice: Package has poor programming practices which may compile *fine but exhibit

[PATCH] dri2: Pass AsyncSwap [vblank_mode=0] requests to the drivers

2011-06-08 Thread Chris Wilson
Currently, the midlayer dri2 code intercepts vblank_mode=0 SwapBuffers and converts it to a CopyRegion request. This prevents the backend from doing anything meaningful in this case and typically ends up being vsync'ed since the drivers cannot distinguish it from a regular CopyRegion request.

Re: [PATCH 3/3] dix: support the transformation matrix for relative devices.

2011-06-08 Thread Simon Thum
(I removed some text) I think my wiki page has a scenario for high-resolution mice, plus some users asked for that. Perhaps the man page can be improved. the problem with pointer acceleration is that the UI to tweak it is is suboptimal. yes, there's xinput but we don't have a ubiquitous GUI

Re: [PATCH 1/4] xserver: Use lists and constants for matching modes in Match entries

2011-06-08 Thread Dan Nicholson
On Sat, Jun 4, 2011 at 10:48 PM, Oleh Nykyforchyn oleh@gmail.com wrote: Use lists and constants for matching modes in Match entries You're leaving out some critical information here. Particularly that each Match entry would take multiple arguments. I'm going to ignore those details for now

[PATCH] dri2: Pass AsyncSwap [vblank_mode=0] requests to the drivers

2011-06-08 Thread Chris Wilson
Currently, the midlayer dri2 code intercepts vblank_mode=0 SwapBuffers and converts it to a CopyRegion request. This prevents the backend from doing anything meaningful in this case and typically ends up being vsync'ed since the drivers cannot distinguish it from a regular CopyRegion request.

Re: [PATCH] dri2: Pass AsyncSwap [vblank_mode=0] requests to the drivers

2011-06-08 Thread Jesse Barnes
On Wed, 8 Jun 2011 19:06:11 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: Currently, the midlayer dri2 code intercepts vblank_mode=0 SwapBuffers and converts it to a CopyRegion request. This prevents the backend from doing anything meaningful in this case and typically ends up being

[PATCH xserver] Update .gitignore as new tests have been added

2011-06-08 Thread Gaetan Nadon
Refactor to follow the pattern one Makefile, one .gitignore where needed. Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Gaetan Nadon mems...@videotron.ca --- test/.gitignore | 16 test/xi2/.gitignore | 10 ++ 2 files changed, 14

[PATCH xserver] docbook.am: --path is also required for xsltproc

2011-06-08 Thread Gaetan Nadon
The XSLT processor also needs to know about the entities defined in xserver.ent. It removes error messages. Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com Signed-off-by: Gaetan Nadon mems...@videotron.ca --- docbook.am |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

Re: [PATCH] dri2: Pass AsyncSwap [vblank_mode=0] requests to the drivers

2011-06-08 Thread Eric Anholt
On Wed, 8 Jun 2011 12:03:04 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: On Wed, 8 Jun 2011 19:06:11 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: Currently, the midlayer dri2 code intercepts vblank_mode=0 SwapBuffers and converts it to a CopyRegion request. This prevents the

Re: [PATCH xf86-video-mga 0/9] Silence compile warnings and remove redundant defines

2011-06-08 Thread Alan Coopersmith
On 06/ 8/11 01:57 AM, Nicolas Kaiser wrote: These patches silence compile warnings, and remove some unused or duplicated defines. Tested on a Matrox G550 AGP. [PATCH 1/9] include unistd.h for usleep() [PATCH 2/9] fix formats in xf86DrvMsg() [PATCH 3/9] hide conditionally used variable in

Re: [PATCH 1/4] xserver: Use lists and constants for matching modes in Match entries

2011-06-08 Thread Oleh Nykyforchyn
On Wed, 8 Jun 2011 10:39:40 -0700 Dan Nicholson dbn.li...@gmail.com wrote: On Sat, Jun 4, 2011 at 10:48 PM, Oleh Nykyforchyn oleh@gmail.com wrote: Use lists and constants for matching modes in Match entries You're leaving out some critical information here. Particularly that each Match

Re: [PATCH 2/4] Remove the cacheing of the last scratch PixmapRec

2011-06-08 Thread Aaron Plattner
On Sun, Jun 05, 2011 at 10:36:07PM -0700, Chris Wilson wrote: In order for the driver to be notified of when the resource backing the scratch pixmap becomes no longer accessible, it needs to be called on every FreeScratchPixmapHeader(). As we instead maybe cached the PixmapRec (to avoid the

Re: [PATCH 1/4] xserver: Use lists and constants for matching modes in Match entries

2011-06-08 Thread Oleh Nykyforchyn
On Wed, 8 Jun 2011 10:39:40 -0700 Dan Nicholson dbn.li...@gmail.com wrote: Why did you change all the breaks to continues? If there was code below the switch you'd be skipping it. Sorry, You are right, it does not matter here. Oleh ___

Re: [PATCH xf86-video-mga 1/9] include unistd.h for usleep()

2011-06-08 Thread Cyril Brulebois
Nicolas Kaiser ni...@nikai.net (08/06/2011): Silences compile warning src/mga_vga.c:65: warning: implicit declaration of function 'usleep' Additionally silences Gentoo QA warning * QA Notice: Package has poor programming practices which may compile *fine but exhibit random

Re: [PATCH 3/3] dix: support the transformation matrix for relative devices.

2011-06-08 Thread Peter Hutterer
On Wed, Jun 08, 2011 at 07:30:52PM +0200, Simon Thum wrote: (I removed some text) I think my wiki page has a scenario for high-resolution mice, plus some users asked for that. Perhaps the man page can be improved. the problem with pointer acceleration is that the UI to tweak it is is

Re: [PATCH:xkbcomp] Replace repeated checks for gcc with _X_ATTRIBUTE_PRINTF from xproto

2011-06-08 Thread Alan Coopersmith
On 06/ 8/11 01:06 AM, Mark Kettenis wrote: From: Alan Coopersmith alan.coopersm...@oracle.com Date: Tue, 7 Jun 2011 23:55:25 -0700 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Strangely formatted code, but that's not your fault. Yeah, xkbcomp's utils.h is rather messy all

Re: [PATCH 1/4] xserver: Use lists and constants for matching modes in Match entries

2011-06-08 Thread Peter Hutterer
On Wed, Jun 08, 2011 at 11:58:20PM +0300, Oleh Nykyforchyn wrote: On Wed, 8 Jun 2011 10:39:40 -0700 Dan Nicholson dbn.li...@gmail.com wrote: On Sat, Jun 4, 2011 at 10:48 PM, Oleh Nykyforchyn oleh@gmail.com wrote: Use lists and constants for matching modes in Match entries