[PATCH libXi] Don't use raw serial numbers in XIEvents

2015-10-18 Thread Peter Hutterer
cookie->serial is an Xlib contoction, provided by _XSetLastRequestRead(). This serial may be different to the raw serial number from the wire protocol. This causes issues when the raw serial is used to e.g. compare the event to other non-XI events. Use the cookie's serial number instead.

Re: [PATCH] Also dump passive grabs on XF86LogGrabInfo

2015-10-18 Thread Peter Hutterer
On Thu, Oct 15, 2015 at 09:32:56AM -0700, Michael Stapelberg wrote: > This patch is not entirely finished, I’ve marked the places that need further > attention with TODO. Any input on these, and on the patch in general, is > appreciated. > > Listing passive grabs is useful for debugging the case

Re: [PATCH xserver] xorg-wrapper: when starting the server as root, reset its environment

2015-10-18 Thread Jeremy Huddleston Sequoia
I would suggest maybe instead doing: int main(int argc, char *argv[], char *envp[]) { ... if (getuid() != geteuid()) envp = {NULL, }; (void)execve(argv[0], argv, envp); ... } Or at least name the variable something like empty_envp to distinguish it more clearly from the

[PATCH] xorg-wrapper: fix build without libdrm

2015-10-18 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- configure.ac | 2 -- hw/xfree86/xorg-wrapper.c | 6 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index e434720..818026f 100644 --- a/configure.ac +++ b/configure.ac

[PATCH xserver] xorg-wrapper: when starting the server as root, reset its environment

2015-10-18 Thread Julien Cristau
When the server is privileged, we shouldn't be passing the user's environment directly. Signed-off-by: Julien Cristau --- hw/xfree86/xorg-wrapper.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) It's possible some variables should be passed, in which case we