Cygwin and upstream (Was: Re: [PATCH xserver v2.1] os: Treat ssh as a non-local client (v2))

On 11 December 2015 at 15:47, Jon Turney wrote: > On 11/12/2015 10:31, Emil Velikov wrote: >> There's no (intentional) MSVC or mingw support in xserver that I know >> of - only Cygwin. There is also the GNU version of the function >> (#define _GNU_SOURCE + #include )

Re: [PATCH xserver 4/8] Create a threaded mechanism for input [v3]

> From: Keith Packard > Date: Fri, 11 Dec 2015 15:37:24 -0800 > > Keith Packard writes: > > > Mark Kettenis writes: > > > >> However, is there a reason why you didn't use the > >> PTHREAD_MUTEX_RECURSIVE mtex type that is

Re: [PATCH xserver] os: Treat ssh as a non-local client (v2)

> From: =?UTF-8?q?Michel=20D=C3=A4nzer?= > Date: Fri, 11 Dec 2015 11:28:51 +0900 > > By the time we get to ComputeLocalClient, we've already done > NextAvailableClient → ReserveClientIds → > DetermineClientCmd (assuming we're built with #define CLIENTIDS), so > we can

Re: [PATCH xserver 4/8] Create a threaded mechanism for input [v3]

Mark Kettenis writes: > I'd say that would be overkill. The use of recursive mutexes is > somewhat controversal, which is almost certainly why they weren't part > of POSIX initially. But they were part of Unix98 and present as an > XSI extension in POSIX until they

Re: [PATCH xserver 4/8] Create a threaded mechanism for input [v3]

Mark Kettenis writes: > It isn't odd, because PTHREAD_RECURSIVE_MUTEX_INITIALIZE isn't in the > standard. You'll have to explicitly initialize the mutex with > pthread_mutex_init() to get a recursive mutex. Sigh. That's a pain in this case; the first use of the mutex

Re: [PATCH xserver 4/8] Create a threaded mechanism for input [v3]

> From: Keith Packard > Date: Sat, 12 Dec 2015 13:19:59 -0800 > > Mark Kettenis writes: > > > I'd say that would be overkill. The use of recursive mutexes is > > somewhat controversal, which is almost certainly why they weren't part > > of POSIX